[GitHub] williaster commented on a change in pull request #5039: [Ready]Allow domain-sharding option for dashboard

[GitBox <gi...@apache.org>]

williaster commented on a change in pull request #5039: [Ready]Allow domain-sharding option for dashboard
URL: https://github.com/apache/incubator-superset/pull/5039#discussion_r233154328
 
 

 ##########
 File path: superset/assets/src/explore/exploreUtils.js
 ##########
 @@ -105,7 +123,11 @@ export function getExploreUrlAndPayload({
 }
 
 export function exportChart(formData, endpointType) {
-  const { url, payload } = getExploreUrlAndPayload({ formData, endpointType });
+  const { url, payload } = getExploreUrlAndPayload({
+    formData,
+    endpointType,
+    allowDomainSharding: false,
 
 Review comment:
   is there any downside to allowing domain sharding for `exportChart`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org