You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/10/22 04:34:08 UTC

[GitHub] [incubator-superset] mistercrunch opened a new pull request #11383: style: make disabled buttons more readable

mistercrunch opened a new pull request #11383:
URL: https://github.com/apache/incubator-superset/pull/11383


   ### SUMMARY
   I know it sounds paradoxy, but I'm making disabled button more accessible.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   #### after
   <img width="436" alt="Screen Shot 2020-10-21 at 9 31 17 PM" src="https://user-images.githubusercontent.com/487433/96825001-03601880-13e5-11eb-9a4f-4522e194df70.png">
   #### before 
   ![96285976-896b0200-0f94-11eb-9c6d-f3d8d786081d](https://user-images.githubusercontent.com/487433/96825040-17a41580-13e5-11eb-8d66-c1d9d8034481.png)
   
   
   ### TEST PLAN
   🙏 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] mistercrunch commented on a change in pull request #11383: style: make disabled buttons more readable

Posted by GitBox <gi...@apache.org>.
mistercrunch commented on a change in pull request #11383:
URL: https://github.com/apache/incubator-superset/pull/11383#discussion_r509878122



##########
File path: superset-frontend/src/components/Button/index.tsx
##########
@@ -221,7 +221,7 @@ const SupersetButton = styled(BootstrapButton)`
     &[disabled],
     &[disabled]:hover {
       background-color: ${({ theme }) => theme.colors.grayscale.light2};
-      color: ${({ theme }) => theme.colors.grayscale.light1};
+      color: ${({ theme }) => theme.colors.grayscale.base};

Review comment:
       makes disabled button a bit more readable/accessible




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] mistercrunch commented on a change in pull request #11383: style: make disabled buttons more readable

Posted by GitBox <gi...@apache.org>.
mistercrunch commented on a change in pull request #11383:
URL: https://github.com/apache/incubator-superset/pull/11383#discussion_r509878275



##########
File path: superset-frontend/src/addSlice/AddSliceContainer.tsx
##########
@@ -134,6 +134,7 @@ export default class AddSliceContainer extends React.PureComponent<
                 name="select-vis-type"
                 onChange={this.changeVisType}
                 value={this.state.visType}
+                labelBsStyle="primary"

Review comment:
       more of a CTA on choosing the viz type




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11383: style: improve the "Create New Chart" screen's usability

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11383:
URL: https://github.com/apache/incubator-superset/pull/11383#issuecomment-714233137


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11383?src=pr&el=h1) Report
   > Merging [#11383](https://codecov.io/gh/apache/incubator-superset/pull/11383?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/a2a614d76070c1f4b0d11571743a7a056cbfc245?el=desc) will **decrease** coverage by `5.73%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11383/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11383?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11383      +/-   ##
   ==========================================
   - Coverage   60.94%   55.21%   -5.74%     
   ==========================================
     Files         394      406      +12     
     Lines       24955    13600   -11355     
     Branches        0     3450    +3450     
   ==========================================
   - Hits        15209     7509    -7700     
   + Misses       9746     5913    -3833     
   - Partials        0      178     +178     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `55.21% <100.00%> (?)` | |
   | #python | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11383?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset-frontend/src/components/Button/index.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11383/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQnV0dG9uL2luZGV4LnRzeA==) | `96.66% <100.00%> (ø)` | |
   | [...src/explore/components/controls/VizTypeControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11383/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9WaXpUeXBlQ29udHJvbC5qc3g=) | `92.15% <100.00%> (ø)` | |
   | [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11383/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | | |
   | [superset/models/sql\_types/presto\_sql\_types.py](https://codecov.io/gh/apache/incubator-superset/pull/11383/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL3NxbF90eXBlcy9wcmVzdG9fc3FsX3R5cGVzLnB5) | | |
   | [superset/migrations/versions/ae19b4ee3692\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11383/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy9hZTE5YjRlZTM2OTJfLnB5) | | |
   | [superset/app.py](https://codecov.io/gh/apache/incubator-superset/pull/11383/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXBwLnB5) | | |
   | [superset/db\_engine\_specs/gsheets.py](https://codecov.io/gh/apache/incubator-superset/pull/11383/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2dzaGVldHMucHk=) | | |
   | [superset/migrations/versions/b347b202819b\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11383/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy9iMzQ3YjIwMjgxOWJfLnB5) | | |
   | [...s/versions/eca4694defa7\_sqllab\_setting\_defaults.py](https://codecov.io/gh/apache/incubator-superset/pull/11383/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy9lY2E0Njk0ZGVmYTdfc3FsbGFiX3NldHRpbmdfZGVmYXVsdHMucHk=) | | |
   | [...ons/versions/e96dbf2cfef0\_datasource\_cluster\_fk.py](https://codecov.io/gh/apache/incubator-superset/pull/11383/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy9lOTZkYmYyY2ZlZjBfZGF0YXNvdXJjZV9jbHVzdGVyX2ZrLnB5) | | |
   | ... and [792 more](https://codecov.io/gh/apache/incubator-superset/pull/11383/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11383?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11383?src=pr&el=footer). Last update [a2a614d...5afe8c4](https://codecov.io/gh/apache/incubator-superset/pull/11383?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] mistercrunch commented on pull request #11383: style: improve the "Create New Chart" screen's usability

Posted by GitBox <gi...@apache.org>.
mistercrunch commented on pull request #11383:
URL: https://github.com/apache/incubator-superset/pull/11383#issuecomment-714224757


   @nytai sorry about the confusion, I ended up fixing a few things here and changed the title to reflect that. Spoke to @junlincc and it now does address #11299


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11383: style: improve the "Create New Chart" screen's usability

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11383:
URL: https://github.com/apache/incubator-superset/pull/11383#issuecomment-714233137


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11383?src=pr&el=h1) Report
   > Merging [#11383](https://codecov.io/gh/apache/incubator-superset/pull/11383?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/a2a614d76070c1f4b0d11571743a7a056cbfc245?el=desc) will **decrease** coverage by `5.08%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11383/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11383?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11383      +/-   ##
   ==========================================
   - Coverage   60.94%   55.86%   -5.09%     
   ==========================================
     Files         394      406      +12     
     Lines       24955    13600   -11355     
     Branches        0     3450    +3450     
   ==========================================
   - Hits        15209     7597    -7612     
   + Misses       9746     5833    -3913     
   - Partials        0      170     +170     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `55.86% <100.00%> (?)` | |
   | #python | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11383?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset-frontend/src/components/Button/index.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11383/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQnV0dG9uL2luZGV4LnRzeA==) | `96.66% <100.00%> (ø)` | |
   | [...src/explore/components/controls/VizTypeControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11383/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9WaXpUeXBlQ29udHJvbC5qc3g=) | `92.15% <100.00%> (ø)` | |
   | [...ions/versions/7e3ddad2a00b\_results\_key\_to\_query.py](https://codecov.io/gh/apache/incubator-superset/pull/11383/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy83ZTNkZGFkMmEwMGJfcmVzdWx0c19rZXlfdG9fcXVlcnkucHk=) | | |
   | [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/11383/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | | |
   | [superset/tasks/slack\_util.py](https://codecov.io/gh/apache/incubator-superset/pull/11383/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3Mvc2xhY2tfdXRpbC5weQ==) | | |
   | [superset/migrations/env.py](https://codecov.io/gh/apache/incubator-superset/pull/11383/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy9lbnYucHk=) | | |
   | [superset/models/slice.py](https://codecov.io/gh/apache/incubator-superset/pull/11383/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL3NsaWNlLnB5) | | |
   | [...versions/0c5070e96b57\_add\_user\_attributes\_table.py](https://codecov.io/gh/apache/incubator-superset/pull/11383/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy8wYzUwNzBlOTZiNTdfYWRkX3VzZXJfYXR0cmlidXRlc190YWJsZS5weQ==) | | |
   | [superset/dashboards/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11383/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9kYW8ucHk=) | | |
   | [...et/migrations/versions/ddd6ebdd853b\_annotations.py](https://codecov.io/gh/apache/incubator-superset/pull/11383/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy9kZGQ2ZWJkZDg1M2JfYW5ub3RhdGlvbnMucHk=) | | |
   | ... and [792 more](https://codecov.io/gh/apache/incubator-superset/pull/11383/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11383?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11383?src=pr&el=footer). Last update [a2a614d...5afe8c4](https://codecov.io/gh/apache/incubator-superset/pull/11383?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-io commented on pull request #11383: style: improve the "Create New Chart" screen's usability

Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #11383:
URL: https://github.com/apache/incubator-superset/pull/11383#issuecomment-714233137


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11383?src=pr&el=h1) Report
   > Merging [#11383](https://codecov.io/gh/apache/incubator-superset/pull/11383?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/a2a614d76070c1f4b0d11571743a7a056cbfc245?el=desc) will **decrease** coverage by `5.72%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11383/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11383?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11383      +/-   ##
   ==========================================
   - Coverage   60.94%   55.22%   -5.73%     
   ==========================================
     Files         394      406      +12     
     Lines       24955    13601   -11354     
     Branches        0     3450    +3450     
   ==========================================
   - Hits        15209     7511    -7698     
   + Misses       9746     5912    -3834     
   - Partials        0      178     +178     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `55.22% <100.00%> (?)` | |
   | #python | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11383?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset-frontend/src/components/Button/index.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11383/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQnV0dG9uL2luZGV4LnRzeA==) | `96.66% <100.00%> (ø)` | |
   | [superset/stats\_logger.py](https://codecov.io/gh/apache/incubator-superset/pull/11383/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3RhdHNfbG9nZ2VyLnB5) | | |
   | [superset/utils/decorators.py](https://codecov.io/gh/apache/incubator-superset/pull/11383/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGVjb3JhdG9ycy5weQ==) | | |
   | [superset/examples/random\_time\_series.py](https://codecov.io/gh/apache/incubator-superset/pull/11383/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvcmFuZG9tX3RpbWVfc2VyaWVzLnB5) | | |
   | [superset/security/manager.py](https://codecov.io/gh/apache/incubator-superset/pull/11383/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc2VjdXJpdHkvbWFuYWdlci5weQ==) | | |
   | [superset/utils/feature\_flag\_manager.py](https://codecov.io/gh/apache/incubator-superset/pull/11383/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZmVhdHVyZV9mbGFnX21hbmFnZXIucHk=) | | |
   | [superset/utils/dict\_import\_export.py](https://codecov.io/gh/apache/incubator-superset/pull/11383/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGljdF9pbXBvcnRfZXhwb3J0LnB5) | | |
   | [...ations/versions/f162a1dea4c4\_d3format\_by\_metric.py](https://codecov.io/gh/apache/incubator-superset/pull/11383/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy9mMTYyYTFkZWE0YzRfZDNmb3JtYXRfYnlfbWV0cmljLnB5) | | |
   | [superset/utils/import\_datasource.py](https://codecov.io/gh/apache/incubator-superset/pull/11383/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvaW1wb3J0X2RhdGFzb3VyY2UucHk=) | | |
   | [superset/sql\_validators/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11383/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvX19pbml0X18ucHk=) | | |
   | ... and [791 more](https://codecov.io/gh/apache/incubator-superset/pull/11383/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11383?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11383?src=pr&el=footer). Last update [a2a614d...5afe8c4](https://codecov.io/gh/apache/incubator-superset/pull/11383?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] mistercrunch commented on a change in pull request #11383: style: make disabled buttons more readable

Posted by GitBox <gi...@apache.org>.
mistercrunch commented on a change in pull request #11383:
URL: https://github.com/apache/incubator-superset/pull/11383#discussion_r509878009



##########
File path: superset-frontend/src/addSlice/AddSliceContainer.tsx
##########
@@ -103,7 +103,7 @@ export default class AddSliceContainer extends React.PureComponent<
                   name="select-datasource"
                   onChange={this.changeDatasource}
                   options={this.props.datasources}
-                  placeholder={t('Choose a datasource')}
+                  placeholder={t('Choose a dataset')}

Review comment:
       bycatch




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] nytai commented on pull request #11383: style: make disabled buttons more readable

Posted by GitBox <gi...@apache.org>.
nytai commented on pull request #11383:
URL: https://github.com/apache/incubator-superset/pull/11383#issuecomment-714219072


   Does this actually address #11299? That issue seems to be about the label button for the viz type


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11383: style: improve the "Create New Chart" screen's usability

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11383:
URL: https://github.com/apache/incubator-superset/pull/11383#issuecomment-714233137


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11383?src=pr&el=h1) Report
   > Merging [#11383](https://codecov.io/gh/apache/incubator-superset/pull/11383?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/a2a614d76070c1f4b0d11571743a7a056cbfc245?el=desc) will **decrease** coverage by `5.07%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11383/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11383?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11383      +/-   ##
   ==========================================
   - Coverage   60.94%   55.87%   -5.08%     
   ==========================================
     Files         394      406      +12     
     Lines       24955    13601   -11354     
     Branches        0     3450    +3450     
   ==========================================
   - Hits        15209     7599    -7610     
   + Misses       9746     5832    -3914     
   - Partials        0      170     +170     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `55.87% <100.00%> (?)` | |
   | #python | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11383?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset-frontend/src/components/Button/index.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11383/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQnV0dG9uL2luZGV4LnRzeA==) | `96.66% <100.00%> (ø)` | |
   | [superset/migrations/versions/6414e83d82b7\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11383/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy82NDE0ZTgzZDgyYjdfLnB5) | | |
   | [...et/migrations/versions/7467e77870e4\_remove\_aggs.py](https://codecov.io/gh/apache/incubator-superset/pull/11383/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy83NDY3ZTc3ODcwZTRfcmVtb3ZlX2FnZ3MucHk=) | | |
   | [superset/migrations/versions/fee7b758c130\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11383/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy9mZWU3Yjc1OGMxMzBfLnB5) | | |
   | [superset/css\_templates/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11383/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY3NzX3RlbXBsYXRlcy9hcGkucHk=) | | |
   | [superset/migrations/versions/ef8843b41dac\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11383/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy9lZjg4NDNiNDFkYWNfLnB5) | | |
   | [superset/migrations/versions/45e7da7cfeba\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11383/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy80NWU3ZGE3Y2ZlYmFfLnB5) | | |
   | [...ions/versions/e553e78e90c5\_add\_druid\_auth\_py\_py.py](https://codecov.io/gh/apache/incubator-superset/pull/11383/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy9lNTUzZTc4ZTkwYzVfYWRkX2RydWlkX2F1dGhfcHlfcHkucHk=) | | |
   | [superset/datasets/commands/delete.py](https://codecov.io/gh/apache/incubator-superset/pull/11383/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvZGVsZXRlLnB5) | | |
   | [superset/views/chart/views.py](https://codecov.io/gh/apache/incubator-superset/pull/11383/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY2hhcnQvdmlld3MucHk=) | | |
   | ... and [791 more](https://codecov.io/gh/apache/incubator-superset/pull/11383/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11383?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11383?src=pr&el=footer). Last update [a2a614d...5afe8c4](https://codecov.io/gh/apache/incubator-superset/pull/11383?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] mistercrunch merged pull request #11383: style: improve the "Create New Chart" screen's usability

Posted by GitBox <gi...@apache.org>.
mistercrunch merged pull request #11383:
URL: https://github.com/apache/incubator-superset/pull/11383


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org