You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by GitBox <gi...@apache.org> on 2020/02/24 14:54:51 UTC
[GitHub] [hadoop] bgaborg opened a new pull request #1857: HADOOP-16878.
Copy command in FileUtil to LOG at warn level if the source and destination
is the same
bgaborg opened a new pull request #1857: HADOOP-16878. Copy command in FileUtil to LOG at warn level if the source and destination is the same
URL: https://github.com/apache/hadoop/pull/1857
Change-Id: Ibaa6e8a23ba575d0092b6d67989dc58c93a3a2d7
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] steveloughran commented on issue #1857: HADOOP-16878. Copy
command in FileUtil to LOG at warn level if the source and destination is
the same
Posted by GitBox <gi...@apache.org>.
steveloughran commented on issue #1857: HADOOP-16878. Copy command in FileUtil to LOG at warn level if the source and destination is the same
URL: https://github.com/apache/hadoop/pull/1857#issuecomment-590909093
* findbugs is rejecting this as two different Path types are being referred.
* I'd like an exception to be raised, as this is clearly an error. Or log @ error and return -1, I guess...whichever looks best on the CLI
* going to need a test, I'm afraid
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] hadoop-yetus commented on issue #1857: HADOOP-16878. Copy
command in FileUtil to LOG at warn level if the source and destination is
the same
Posted by GitBox <gi...@apache.org>.
hadoop-yetus commented on issue #1857: HADOOP-16878. Copy command in FileUtil to LOG at warn level if the source and destination is the same
URL: https://github.com/apache/hadoop/pull/1857#issuecomment-603969827
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 35s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 1s | No case conflicting files found. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 1 new or modified test files. |
||| _ trunk Compile Tests _ |
| +1 :green_heart: | mvninstall | 20m 23s | trunk passed |
| +1 :green_heart: | compile | 26m 15s | trunk passed |
| +1 :green_heart: | checkstyle | 1m 7s | trunk passed |
| +1 :green_heart: | mvnsite | 2m 3s | trunk passed |
| +1 :green_heart: | shadedclient | 24m 30s | branch has no errors when building and testing our client artifacts. |
| +1 :green_heart: | javadoc | 1m 21s | trunk passed |
| +0 :ok: | spotbugs | 3m 24s | Used deprecated FindBugs config; considering switching to SpotBugs. |
| +1 :green_heart: | findbugs | 3m 20s | trunk passed |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 1m 16s | the patch passed |
| -1 :x: | compile | 20m 30s | root in the patch failed. |
| -1 :x: | javac | 20m 30s | root in the patch failed. |
| -0 :warning: | checkstyle | 0m 40s | The patch fails to run checkstyle in hadoop-common |
| -1 :x: | mvnsite | 0m 39s | hadoop-common in the patch failed. |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | shadedclient | 0m 40s | patch has no errors when building and testing our client artifacts. |
| -1 :x: | javadoc | 0m 35s | hadoop-common in the patch failed. |
| -1 :x: | findbugs | 0m 40s | hadoop-common in the patch failed. |
||| _ Other Tests _ |
| -1 :x: | unit | 0m 38s | hadoop-common in the patch failed. |
| +0 :ok: | asflicense | 0m 41s | ASF License check generated no output? |
| | | 106m 39s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1857/2/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hadoop/pull/1857 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle |
| uname | Linux a814db013b44 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | personality/hadoop.sh |
| git revision | trunk / 2d294bd |
| Default Java | 1.8.0_242 |
| compile | https://builds.apache.org/job/hadoop-multibranch/job/PR-1857/2/artifact/out/patch-compile-root.txt |
| javac | https://builds.apache.org/job/hadoop-multibranch/job/PR-1857/2/artifact/out/patch-compile-root.txt |
| checkstyle | https://builds.apache.org/job/hadoop-multibranch/job/PR-1857/2/artifact/out//home/jenkins/jenkins-slave/workspace/hadoop-multibranch_PR-1857/out/maven-patch-checkstyle-hadoop-common-project_hadoop-common.txt |
| mvnsite | https://builds.apache.org/job/hadoop-multibranch/job/PR-1857/2/artifact/out/patch-mvnsite-hadoop-common-project_hadoop-common.txt |
| javadoc | https://builds.apache.org/job/hadoop-multibranch/job/PR-1857/2/artifact/out/patch-javadoc-hadoop-common-project_hadoop-common.txt |
| findbugs | https://builds.apache.org/job/hadoop-multibranch/job/PR-1857/2/artifact/out/patch-findbugs-hadoop-common-project_hadoop-common.txt |
| unit | https://builds.apache.org/job/hadoop-multibranch/job/PR-1857/2/artifact/out/patch-unit-hadoop-common-project_hadoop-common.txt |
| Test Results | https://builds.apache.org/job/hadoop-multibranch/job/PR-1857/2/testReport/ |
| Max. process+thread count | 341 (vs. ulimit of 5500) |
| modules | C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common |
| Console output | https://builds.apache.org/job/hadoop-multibranch/job/PR-1857/2/console |
| versions | git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] hadoop-yetus commented on issue #1857: HADOOP-16878. Copy
command in FileUtil to LOG at warn level if the source and destination is
the same
Posted by GitBox <gi...@apache.org>.
hadoop-yetus commented on issue #1857: HADOOP-16878. Copy command in FileUtil to LOG at warn level if the source and destination is the same
URL: https://github.com/apache/hadoop/pull/1857#issuecomment-590453321
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 25m 11s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| -1 :x: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
||| _ trunk Compile Tests _ |
| +1 :green_heart: | mvninstall | 20m 28s | trunk passed |
| +1 :green_heart: | compile | 18m 35s | trunk passed |
| +1 :green_heart: | checkstyle | 0m 57s | trunk passed |
| +1 :green_heart: | mvnsite | 2m 13s | trunk passed |
| +1 :green_heart: | shadedclient | 24m 17s | branch has no errors when building and testing our client artifacts. |
| +1 :green_heart: | javadoc | 1m 39s | trunk passed |
| +0 :ok: | spotbugs | 3m 45s | Used deprecated FindBugs config; considering switching to SpotBugs. |
| +1 :green_heart: | findbugs | 3m 39s | trunk passed |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 1m 14s | the patch passed |
| -1 :x: | compile | 21m 32s | root in the patch failed. |
| -1 :x: | javac | 21m 32s | root in the patch failed. |
| +1 :green_heart: | checkstyle | 1m 11s | the patch passed |
| +1 :green_heart: | mvnsite | 2m 0s | the patch passed |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| -1 :x: | shadedclient | 18m 15s | patch has errors when building and testing our client artifacts. |
| +1 :green_heart: | javadoc | 1m 1s | the patch passed |
| -1 :x: | findbugs | 2m 21s | hadoop-common-project/hadoop-common generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0) |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 9m 32s | hadoop-common in the patch passed. |
| +1 :green_heart: | asflicense | 0m 45s | The patch does not generate ASF License warnings. |
| | | 155m 32s | |
| Reason | Tests |
|-------:|:------|
| FindBugs | module:hadoop-common-project/hadoop-common |
| | Call to java.nio.file.Path.equals(org.apache.hadoop.fs.Path) in org.apache.hadoop.fs.FileUtil.copy(File, FileSystem, Path, boolean, Configuration) At FileUtil.java:FileSystem, Path, boolean, Configuration) At FileUtil.java:[line 446] |
| | Call to org.apache.hadoop.fs.Path.equals(java.nio.file.Path) in org.apache.hadoop.fs.FileUtil.copy(FileSystem, FileStatus, File, boolean, Configuration) At FileUtil.java:FileStatus, File, boolean, Configuration) At FileUtil.java:[line 501] |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.6 Server=19.03.6 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1857/1/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hadoop/pull/1857 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle |
| uname | Linux f8db1f8f05fc 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | personality/hadoop.sh |
| git revision | trunk / 7f8685f |
| Default Java | 1.8.0_242 |
| compile | https://builds.apache.org/job/hadoop-multibranch/job/PR-1857/1/artifact/out/patch-compile-root.txt |
| javac | https://builds.apache.org/job/hadoop-multibranch/job/PR-1857/1/artifact/out/patch-compile-root.txt |
| findbugs | https://builds.apache.org/job/hadoop-multibranch/job/PR-1857/1/artifact/out/new-findbugs-hadoop-common-project_hadoop-common.html |
| Test Results | https://builds.apache.org/job/hadoop-multibranch/job/PR-1857/1/testReport/ |
| Max. process+thread count | 2316 (vs. ulimit of 5500) |
| modules | C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common |
| Console output | https://builds.apache.org/job/hadoop-multibranch/job/PR-1857/1/console |
| versions | git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] bgaborg commented on issue #1857: HADOOP-16878. Copy
command in FileUtil to LOG at warn level if the source and destination is
the same
Posted by GitBox <gi...@apache.org>.
bgaborg commented on issue #1857: HADOOP-16878. Copy command in FileUtil to LOG at warn level if the source and destination is the same
URL: https://github.com/apache/hadoop/pull/1857#issuecomment-591431634
> * findbugs is rejecting this as two different Path types are being referred.
> * I'd like an exception to be raised, as this is clearly an error. Or log @ error and return -1, I guess...whichever looks best on the CLI
I'll throw an exception then instead of just logging.
> * going to need a test, I'm afraid
I can create a test where I expect the exception. Or 3 patches because it's a modification in 3 different places.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] steveloughran commented on issue #1857: HADOOP-16878. Copy
command in FileUtil to LOG at warn level if the source and destination is
the same
Posted by GitBox <gi...@apache.org>.
steveloughran commented on issue #1857: HADOOP-16878. Copy command in FileUtil to LOG at warn level if the source and destination is the same
URL: https://github.com/apache/hadoop/pull/1857#issuecomment-605994719
didn't build. Try a rebase and resubmit
Also: change PR and JIRA text now that it actually fails
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] hadoop-yetus commented on issue #1857: HADOOP-16878. Copy
command in FileUtil to throw an exception if the source and destination is
the same
Posted by GitBox <gi...@apache.org>.
hadoop-yetus commented on issue #1857: HADOOP-16878. Copy command in FileUtil to throw an exception if the source and destination is the same
URL: https://github.com/apache/hadoop/pull/1857#issuecomment-606106448
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 38s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 1 new or modified test files. |
||| _ trunk Compile Tests _ |
| +1 :green_heart: | mvninstall | 20m 41s | trunk passed |
| +1 :green_heart: | compile | 18m 7s | trunk passed |
| +1 :green_heart: | checkstyle | 0m 54s | trunk passed |
| +1 :green_heart: | mvnsite | 1m 28s | trunk passed |
| +1 :green_heart: | shadedclient | 16m 52s | branch has no errors when building and testing our client artifacts. |
| +1 :green_heart: | javadoc | 1m 3s | trunk passed |
| +0 :ok: | spotbugs | 2m 8s | Used deprecated FindBugs config; considering switching to SpotBugs. |
| +1 :green_heart: | findbugs | 2m 6s | trunk passed |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 0m 49s | the patch passed |
| +1 :green_heart: | compile | 16m 14s | the patch passed |
| +1 :green_heart: | javac | 16m 14s | the patch passed |
| +1 :green_heart: | checkstyle | 0m 51s | the patch passed |
| +1 :green_heart: | mvnsite | 1m 26s | the patch passed |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | shadedclient | 14m 18s | patch has no errors when building and testing our client artifacts. |
| +1 :green_heart: | javadoc | 1m 5s | the patch passed |
| -1 :x: | findbugs | 2m 19s | hadoop-common-project/hadoop-common generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 9m 26s | hadoop-common in the patch passed. |
| +1 :green_heart: | asflicense | 0m 54s | The patch does not generate ASF License warnings. |
| | | 110m 22s | |
| Reason | Tests |
|-------:|:------|
| FindBugs | module:hadoop-common-project/hadoop-common |
| | Nullcheck of src at line 400 of value previously dereferenced in org.apache.hadoop.fs.FileUtil.copy(FileSystem, FileStatus, FileSystem, Path, boolean, boolean, Configuration) At FileUtil.java:400 of value previously dereferenced in org.apache.hadoop.fs.FileUtil.copy(FileSystem, FileStatus, FileSystem, Path, boolean, boolean, Configuration) At FileUtil.java:[line 400] |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1857/3/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hadoop/pull/1857 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle |
| uname | Linux d57b254b260e 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | personality/hadoop.sh |
| git revision | trunk / 960c9eb |
| Default Java | 1.8.0_242 |
| findbugs | https://builds.apache.org/job/hadoop-multibranch/job/PR-1857/3/artifact/out/new-findbugs-hadoop-common-project_hadoop-common.html |
| Test Results | https://builds.apache.org/job/hadoop-multibranch/job/PR-1857/3/testReport/ |
| Max. process+thread count | 1575 (vs. ulimit of 5500) |
| modules | C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common |
| Console output | https://builds.apache.org/job/hadoop-multibranch/job/PR-1857/3/console |
| versions | git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] hadoop-yetus removed a comment on issue #1857:
HADOOP-16878. Copy command in FileUtil to throw an exception if the source
and destination is the same
Posted by GitBox <gi...@apache.org>.
hadoop-yetus removed a comment on issue #1857: HADOOP-16878. Copy command in FileUtil to throw an exception if the source and destination is the same
URL: https://github.com/apache/hadoop/pull/1857#issuecomment-603969827
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 35s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 1s | No case conflicting files found. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 1 new or modified test files. |
||| _ trunk Compile Tests _ |
| +1 :green_heart: | mvninstall | 20m 23s | trunk passed |
| +1 :green_heart: | compile | 26m 15s | trunk passed |
| +1 :green_heart: | checkstyle | 1m 7s | trunk passed |
| +1 :green_heart: | mvnsite | 2m 3s | trunk passed |
| +1 :green_heart: | shadedclient | 24m 30s | branch has no errors when building and testing our client artifacts. |
| +1 :green_heart: | javadoc | 1m 21s | trunk passed |
| +0 :ok: | spotbugs | 3m 24s | Used deprecated FindBugs config; considering switching to SpotBugs. |
| +1 :green_heart: | findbugs | 3m 20s | trunk passed |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 1m 16s | the patch passed |
| -1 :x: | compile | 20m 30s | root in the patch failed. |
| -1 :x: | javac | 20m 30s | root in the patch failed. |
| -0 :warning: | checkstyle | 0m 40s | The patch fails to run checkstyle in hadoop-common |
| -1 :x: | mvnsite | 0m 39s | hadoop-common in the patch failed. |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | shadedclient | 0m 40s | patch has no errors when building and testing our client artifacts. |
| -1 :x: | javadoc | 0m 35s | hadoop-common in the patch failed. |
| -1 :x: | findbugs | 0m 40s | hadoop-common in the patch failed. |
||| _ Other Tests _ |
| -1 :x: | unit | 0m 38s | hadoop-common in the patch failed. |
| +0 :ok: | asflicense | 0m 41s | ASF License check generated no output? |
| | | 106m 39s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1857/2/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hadoop/pull/1857 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle |
| uname | Linux a814db013b44 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | personality/hadoop.sh |
| git revision | trunk / 2d294bd |
| Default Java | 1.8.0_242 |
| compile | https://builds.apache.org/job/hadoop-multibranch/job/PR-1857/2/artifact/out/patch-compile-root.txt |
| javac | https://builds.apache.org/job/hadoop-multibranch/job/PR-1857/2/artifact/out/patch-compile-root.txt |
| checkstyle | https://builds.apache.org/job/hadoop-multibranch/job/PR-1857/2/artifact/out//home/jenkins/jenkins-slave/workspace/hadoop-multibranch_PR-1857/out/maven-patch-checkstyle-hadoop-common-project_hadoop-common.txt |
| mvnsite | https://builds.apache.org/job/hadoop-multibranch/job/PR-1857/2/artifact/out/patch-mvnsite-hadoop-common-project_hadoop-common.txt |
| javadoc | https://builds.apache.org/job/hadoop-multibranch/job/PR-1857/2/artifact/out/patch-javadoc-hadoop-common-project_hadoop-common.txt |
| findbugs | https://builds.apache.org/job/hadoop-multibranch/job/PR-1857/2/artifact/out/patch-findbugs-hadoop-common-project_hadoop-common.txt |
| unit | https://builds.apache.org/job/hadoop-multibranch/job/PR-1857/2/artifact/out/patch-unit-hadoop-common-project_hadoop-common.txt |
| Test Results | https://builds.apache.org/job/hadoop-multibranch/job/PR-1857/2/testReport/ |
| Max. process+thread count | 341 (vs. ulimit of 5500) |
| modules | C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common |
| Console output | https://builds.apache.org/job/hadoop-multibranch/job/PR-1857/2/console |
| versions | git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] steveloughran commented on issue #1857: HADOOP-16878. Copy
command in FileUtil to throw an exception if the source and destination is
the same
Posted by GitBox <gi...@apache.org>.
steveloughran commented on issue #1857: HADOOP-16878. Copy command in FileUtil to throw an exception if the source and destination is the same
URL: https://github.com/apache/hadoop/pull/1857#issuecomment-606824811
findbugs unhappy
```
Nullcheck of src at line 400 of value previously dereferenced in org.apache.hadoop.fs.FileUtil.copy(FileSystem, FileStatus, FileSystem, Path, boolean, boolean, Configuration) At FileUtil.java:400 of value previously dereferenced in org.apache.hadoop.fs.FileUtil.copy(FileSystem, FileStatus, FileSystem, Path, boolean, boolean, Configuration) At FileUtil.java:[line 400]
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] steveloughran commented on issue #1857: HADOOP-16878. Copy
command in FileUtil to LOG at warn level if the source and destination is
the same
Posted by GitBox <gi...@apache.org>.
steveloughran commented on issue #1857: HADOOP-16878. Copy command in FileUtil to LOG at warn level if the source and destination is the same
URL: https://github.com/apache/hadoop/pull/1857#issuecomment-600200242
Have you an update for this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] ayushtkn commented on a change in pull request #1857:
HADOOP-16878. Copy command in FileUtil to throw an exception if the source
and destination is the same
Posted by GitBox <gi...@apache.org>.
ayushtkn commented on a change in pull request #1857: HADOOP-16878. Copy command in FileUtil to throw an exception if the source and destination is the same
URL: https://github.com/apache/hadoop/pull/1857#discussion_r406184443
##########
File path: hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileUtil.java
##########
@@ -398,6 +398,13 @@ public static boolean copy(FileSystem srcFS, FileStatus srcStatus,
Configuration conf) throws IOException {
Path src = srcStatus.getPath();
dst = checkDest(src.getName(), dstFS, dst, overwrite);
+
+ if (dst != null && src != null &&
+ src.toUri().equals(dst.toUri())) {
Review comment:
Can we use :
`srcFS.makeQualified(src).equals(dstFS.makeQualified(dst))`
instead of uri comparison, As I said on Jira, this URI comparison isn't working with HDFS
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] bgaborg edited a comment on issue #1857: HADOOP-16878.
Copy command in FileUtil to LOG at warn level if the source and destination
is the same
Posted by GitBox <gi...@apache.org>.
bgaborg edited a comment on issue #1857: HADOOP-16878. Copy command in FileUtil to LOG at warn level if the source and destination is the same
URL: https://github.com/apache/hadoop/pull/1857#issuecomment-591431634
> * findbugs is rejecting this as two different Path types are being referred.
> * I'd like an exception to be raised, as this is clearly an error. Or log @ error and return -1, I guess...whichever looks best on the CLI
I'll throw an exception then instead of just logging.
> * going to need a test, I'm afraid
I can create a test where I expect the exception. Or 3 tests because it's a modification in 3 different places.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] steveloughran commented on issue #1857: HADOOP-16878. Copy
command in FileUtil to LOG at warn level if the source and destination is
the same
Posted by GitBox <gi...@apache.org>.
steveloughran commented on issue #1857: HADOOP-16878. Copy command in FileUtil to LOG at warn level if the source and destination is the same
URL: https://github.com/apache/hadoop/pull/1857#issuecomment-590427181
* Given how destructive this can be, make it an IOException
* after which, a test is straightforward
positioning of the checks LTGM
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org