[GitHub] [apisix-dashboard] guoqqqi commented on a diff in pull request #2630: feat: Adding a Loading state to buttons

[GitBox <gi...@apache.org>]

guoqqqi commented on code in PR #2630:
URL: https://github.com/apache/apisix-dashboard/pull/2630#discussion_r990899096


##########
web/cypress/e2e/route/create-route-with-advanced-matching-conditions.cy.js:
##########
@@ -70,7 +72,7 @@ context('Create Route with advanced matching conditions', () => {
   it('should create route with advanced matching conditions', function () {
     cy.visit('/routes/list');
     cy.contains('Create').click();
-    cy.contains('Next').click().click();

Review Comment:
   ditto



##########
web/cypress/e2e/route/create-route-with-advanced-matching-conditions.cy.js:
##########
@@ -185,7 +189,9 @@ context('Create Route with advanced matching conditions', () => {
     cy.contains('Next').click();
     cy.get(selector.nodes_0_port).focus();
     cy.contains('Next').click();
+    cy.wait(timeout * 2);
     cy.contains('Next').click();
+    cy.wait(timeout * 2);

Review Comment:
   Remove all new wait 



##########
web/cypress/e2e/route/search-route.cy.js:
##########
@@ -82,7 +82,9 @@ context('Create and Search Route', () => {
     cy.wait(timeout);
     for (let i = 0; i < 3; i += 1) {
       cy.contains('Create').click();
-      cy.contains('Next').click().click();
+      cy.contains('Next').click();

Review Comment:
   Remove all new wait 



##########
web/cypress/e2e/route/create-route-with-advanced-matching-conditions.cy.js:
##########
@@ -185,7 +189,9 @@ context('Create Route with advanced matching conditions', () => {
     cy.contains('Next').click();
     cy.get(selector.nodes_0_port).focus();
     cy.contains('Next').click();
+    cy.wait(timeout * 2);

Review Comment:
   ditto



##########
web/cypress/e2e/route/create-route-with-search-service-and-set-priority.cy.js:
##########
@@ -109,7 +110,9 @@ context('Create Route with search service name', () => {
     cy.visit('/');
     cy.contains('Route').click();
     cy.contains('Create').click();
-    cy.contains('Next').click().click();

Review Comment:
   ditto



##########
web/cypress/e2e/route/create-route-with-chash-upstream.cy.js:
##########
@@ -102,6 +102,7 @@ context('Create and Edit Route With Custom CHash Key Upstream', () => {
     cy.get(selector.chash_key).should('value', data.custom_key);
     cy.get(selector.chash_key).clear().type(data.new_key);
     cy.contains('Next').click();
+    cy.wait(1000);

Review Comment:
   Remove all new wait 



##########
web/cypress/e2e/route/create-route-with-advanced-matching-conditions.cy.js:
##########
@@ -162,7 +164,9 @@ context('Create Route with advanced matching conditions', () => {
     cy.contains('Next').click();
     cy.get(selector.nodes_0_port).focus();
     cy.contains('Next').click();
+    cy.wait(timeout * 2);

Review Comment:
   Remove all new wait 



##########
web/cypress/e2e/route/create-route-both-use-uri-uris.cy.js:
##########
@@ -72,7 +72,7 @@ context('Create Route Both use uri and uris', () => {
     cy.contains('Route').click();
     cy.get(selector.empty).should('be.visible');
     cy.contains('Create').click();
-    cy.contains('Next').click().click();

Review Comment:
   The two clicks here are to ensure that the rendering of the page is finished, and this is a point that can be optimized. 
   Please try to restore it first



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org