[jira] [Commented] (NETBEANS-4832) fxml code completion fails with modular java

["Ernie Rael (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/NETBEANS-4832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17199727#comment-17199727 ] 

Ernie Rael commented on NETBEANS-4832:
--------------------------------------

[~sdedic] I can't even propose a fix for this one... If a fix is not obvious, I can gather info, if you'd like. If you can outline a fix, I can try to put together a PR.

For the error annotator parser (which works ok and has a list of modules)
{code}
 ParserManager.MimeTaskAction.run
 userTask: FxmlParser$1UT
{code}

For the completion parser, after Ctrl-Space
{code}
 ParserManager.UserTaskAction.run
 userTask: FXMLCompletion2$Q$Task@4ccbdf93
{code}

The compiler info for the completion parser does not have the list of modules.


> fxml code completion fails with modular java
> --------------------------------------------
>
>                 Key: NETBEANS-4832
>                 URL: https://issues.apache.org/jira/browse/NETBEANS-4832
>             Project: NetBeans
>          Issue Type: Bug
>          Components: javafx - Editor
>         Environment: NB-12.1, jdk-14, no nb-javac, Win7, no userdir/cachedir,
> startup do not import settings
>            Reporter: Ernie Rael
>            Priority: Major
>              Labels: modularization
>
> To reproduce (create/open fxml file)
>  # NewProject > JavaWithMaven > FXML JavaFX Maven Archetype (Gluon)
>  # Open primary.fxml, in "other sources" "source/main/resources" <package>
>  # put cursor within xml, for example after "<children>"
>  # Enter Ctrl-Space to bring up code completion
> Observe:
>  * Typically have to go through a couple web certification dialogs
>  * Typically repeat Ctrl-Space and there's a "downloading..." that never finishes
> Note: Works OK when running on and using jdk1.8 with nb-javac.
> Fails with JDK assertion: Assert.checkNonNull(allModules)
> (full message log attached)
> {code}
> java.lang.AssertionError at jdk.compiler/com.sun.tools.javac.util.Assert.error(Assert.java:155) at jdk.compiler/com.sun.tools.javac.util.Assert.checkNonNull(Assert.java:62) at jdk.compiler/com.sun.tools.javac.comp.Modules.allModules(Modules.java:1205) at jdk.compiler/com.sun.tools.javac.model.JavacElements.getAllModuleElements(JavacElements.java:126) at org.netbeans.modules.java.source.ElementUtils.getTypeElementByBinaryName(ElementUtils.java:49) at org.netbeans.api.java.source.ElementHandle.getTypeElementByBinaryName(ElementHandle.java:666) at org.netbeans.api.java.source.ElementHandle.resolveImpl(ElementHandle.java:163) at org.netbeans.api.java.source.ElementHandle.resolve(ElementHandle.java:132) at org.netbeans.modules.javafx2.editor.completion.impl.InstanceCompleter.<init>(InstanceCompleter.java:54)
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@netbeans.apache.org
For additional commands, e-mail: commits-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists