You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by "Zili Chen (Jira)" <ji...@apache.org> on 2019/11/22 02:11:00 UTC

[jira] [Updated] (FLINK-14915) SchedulingStrategyFactory#createInstance might not need to know JobGraph

     [ https://issues.apache.org/jira/browse/FLINK-14915?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Zili Chen updated FLINK-14915:
------------------------------
    Description: [~zhuzh] [~GJL] I just notice that {{SchedulingStrategyFactory#createInstance}} take a parameter {{JobGraph}} but neither the parameter is in use nor this class/method should know {{JobGraph}}. Could you explain why we need it or we can safely remove the parameter so that we get rid of confusing parameter?  (was: [~zhuzh] I just notice that {{SchedulingStrategyFactory#createInstance}} take a parameter {{JobGraph}} but neither the parameter is in use nor this class/method should know {{JobGraph}}. Could you explain why we need it or we can safely remove the parameter so that we get rid of confusing parameter?)

> SchedulingStrategyFactory#createInstance might not need to know JobGraph
> ------------------------------------------------------------------------
>
>                 Key: FLINK-14915
>                 URL: https://issues.apache.org/jira/browse/FLINK-14915
>             Project: Flink
>          Issue Type: Bug
>          Components: Runtime / Coordination
>            Reporter: Zili Chen
>            Priority: Major
>
> [~zhuzh] [~GJL] I just notice that {{SchedulingStrategyFactory#createInstance}} take a parameter {{JobGraph}} but neither the parameter is in use nor this class/method should know {{JobGraph}}. Could you explain why we need it or we can safely remove the parameter so that we get rid of confusing parameter?



--
This message was sent by Atlassian Jira
(v8.3.4#803005)