[GitHub] yuxihu commented on a change in pull request #14287: FIX: flaky test exponential generator

[GitBox <gi...@apache.org>]

yuxihu commented on a change in pull request #14287: FIX: flaky test exponential generator
URL: https://github.com/apache/incubator-mxnet/pull/14287#discussion_r261440007
 
 

 ##########
 File path: python/mxnet/test_utils.py
 ##########
 @@ -1933,7 +1933,7 @@ def chi_square_check(generator, buckets, probs, nsamples=1000000):
     _, p = ss.chisquare(f_obs=obs_freq, f_exp=expected_freq)
     return p, obs_freq, expected_freq
 
-def verify_generator(generator, buckets, probs, nsamples=1000000, nrepeat=5, success_rate=0.25, alpha=0.05):
+def verify_generator(generator, buckets, probs, nsamples=1000000, nrepeat=5, success_rate=0.15, alpha=0.05):
 
 Review comment:
   It looks like @ChaiBapchya increased it from 0.15 to 0.25 in the PR in order to fix another flaky test. The question now: if you change back to 0.15, will the other test become flaky again?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services