You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/12/03 15:35:54 UTC
[GitHub] [camel-website] apupier opened a new pull request #502: Provide relative link for Camel webiste
apupier opened a new pull request #502:
URL: https://github.com/apache/camel-website/pull/502
attempt to fix
https://ci-builds.apache.org/job/Camel/job/Camel.website/job/master/226/console
```
public/blog/2020/12/VSCode-LanguageSupport-0.0.29/index.html
1:5181 error For links within camel.apache.org use relative links, found: https://camel.apache.org/blog/2020/10/Camel36-Whatsnew/#api-components-overhaul camel/relative-links
```
not able to build locally so cannot test it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-website] apupier commented on pull request #502: Provide relative link for Camel webiste
Posted by GitBox <gi...@apache.org>.
apupier commented on pull request #502:
URL: https://github.com/apache/camel-website/pull/502#issuecomment-738826777
> If you're having issues building/running checks I would like to hear about them, perhaps we're missing something in the docs or have an issue other contributors might encounter, so I'd like to fix that.
tried again by reading more closely the readme, working fine. I upgraded my node version so maybe it was the reason.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-website] zregvart commented on pull request #502: Provide relative link for Camel webiste
Posted by GitBox <gi...@apache.org>.
zregvart commented on pull request #502:
URL: https://github.com/apache/camel-website/pull/502#issuecomment-738267584
> not able to build locally so cannot test it
You should be, there should be only two dependencies you need, Node v14 and Yarn (1.2 or newer IIRC), we vendor Yarn and all dependencies. If you're not running on Linux the link checker via deadlinks will not work (we only vendor the Linux binary ATM).
If you're having issues building/running checks I would like to hear about them, perhaps we're missing something in the docs or have an issue other contributors might encounter, so I'd like to fix that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-website] zregvart commented on a change in pull request #502: Provide relative link for Camel webiste
Posted by GitBox <gi...@apache.org>.
zregvart commented on a change in pull request #502:
URL: https://github.com/apache/camel-website/pull/502#discussion_r535468881
##########
File path: content/blog/2020/12/VSCode-LanguageSupport-0.0.29/index.md
##########
@@ -10,7 +10,7 @@ A new release of [VS Code Language Support for Apache Camel](https://marketplace
# API based components support
-Camel has several API based components which are source code generated from external API. In [3.6.0](https://camel.apache.org/blog/2020/10/Camel36-Whatsnew/#api-components-overhaul), finer grained information is available through additional metadata (Camel catalog). This release is leveraging these metadata to propose improved completion, documentation and validation for these APU based components.
+Camel has several API based components which are source code generated from external API. In [3.6.0](./../../10/Camel36-Whatsnew/#api-components-overhaul), finer grained information is available through additional metadata (Camel catalog). This release is leveraging these metadata to propose improved completion, documentation and validation for these APU based components.
Review comment:
Absolute links, starting with `https://camel.apache.org` are not allowed (so they can be checked for broken links), but links starting with `/` are okay.
```suggestion
Camel has several API based components which are source code generated from external API. In [3.6.0](/blog/2020/10/Camel36-Whatsnew/#api-components-overhaul), finer grained information is available through additional metadata (Camel catalog). This release is leveraging these metadata to propose improved completion, documentation and validation for these APU based components.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-website] zregvart merged pull request #502: Provide relative link for Camel webiste
Posted by GitBox <gi...@apache.org>.
zregvart merged pull request #502:
URL: https://github.com/apache/camel-website/pull/502
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org