[GitHub] [incubator-doris] kangkaisen commented on a change in pull request #3363: [Bug]Use OlapTableSink::close to replace OlapTableSink::finalize method to avoid OOM

[GitBox <gi...@apache.org>]

kangkaisen commented on a change in pull request #3363:
URL: https://github.com/apache/incubator-doris/pull/3363#discussion_r412600132



##########
File path: fe/src/main/java/org/apache/doris/planner/OlapTableSink.java
##########
@@ -118,7 +118,7 @@ public void updateLoadId(TUniqueId newLoadId) {
     }
 
     // must called after tupleDescriptor is computed
-    public void finalize() throws UserException {
+    public void completeq() throws UserException {

Review comment:
       ```suggestion
       public void complete() throws UserException {
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org