You are viewing a plain text version of this content. The canonical link for it is here.
Posted to wsrp4j-dev@portals.apache.org by jm...@apache.org on 2004/06/15 16:37:34 UTC
cvs commit: ws-wsrp4j/portlets/proxyportlet build.properties.example
jmacna 2004/06/15 07:37:34
Modified: portlets/wsrptest build.properties.example
portlets/proxyportlet build.properties.example
Log:
Fix default property values for each portlet to be consistent with eachother.
Revision Changes Path
1.2 +1 -1 ws-wsrp4j/portlets/wsrptest/build.properties.example
Index: build.properties.example
===================================================================
RCS file: /home/cvs/ws-wsrp4j/portlets/wsrptest/build.properties.example,v
retrieving revision 1.1
retrieving revision 1.2
diff -u -r1.1 -r1.2
--- build.properties.example 1 Jun 2004 18:04:26 -0000 1.1
+++ build.properties.example 15 Jun 2004 14:37:34 -0000 1.2
@@ -3,6 +3,6 @@
// the name of the target war file
warfile=wsrptest.war
// the tomcat dir we want this portlet to be deployed to
-TARGET_TOMCAT_HOME=D:/Apache/Tomcat4.1.24-wsrp4j
+TARGET_TOMCAT_HOME=C:/Tomcat4.1
// the webapp containing the portlet container we use for deployment
TARGET_WEBAPP_NAME=wsrp
1.2 +2 -2 ws-wsrp4j/portlets/proxyportlet/build.properties.example
Index: build.properties.example
===================================================================
RCS file: /home/cvs/ws-wsrp4j/portlets/proxyportlet/build.properties.example,v
retrieving revision 1.1
retrieving revision 1.2
diff -u -r1.1 -r1.2
--- build.properties.example 17 Dec 2003 13:50:04 -0000 1.1
+++ build.properties.example 15 Jun 2004 14:37:34 -0000 1.2
@@ -3,7 +3,7 @@
// the name of the target war file
warfile=proxyportlet.war
// the tomcat dir we want this portlet to be deployed to
-TARGET_TOMCAT_HOME=D:/Apache/Tomcat4.1.24-wsrp4j
+TARGET_TOMCAT_HOME=C:/Tomcat4.1
// the webapp containing the portlet container we use for deployment
// for proxyportlet it's the pluto installation
-TARGET_WEBAPP_NAME=pluto
\ No newline at end of file
+TARGET_WEBAPP_NAME=wsrp
\ No newline at end of file
Re: cvs commit: ws-wsrp4j/portlets/proxyportlet build.properties.example
Posted by Julie MacNaught <jm...@apache.org>.
Richard Jacob wrote:
> Julie MacNaught wrote:
>
>>
>> Richard Jacob wrote:
>>
>>> jmacna@apache.org wrote:
>>>
>>>> jmacna 2004/06/15 07:37:34
>>>>
>>>> Modified: portlets/wsrptest build.properties.example
>>>> portlets/proxyportlet build.properties.example
>>>> Log:
>>>> Fix default property values for each portlet to be consistent with
>>>> eachother.
>>>>
>>>>
>>>>
>>>> -TARGET_WEBAPP_NAME=pluto
>>>> \ No newline at end of file
>>>> +TARGET_WEBAPP_NAME=wsrp
>>>> \ No newline at end of file
>>>>
>>>>
>>> I think we must leave the value to be pluto since the proxyportlet
>>> is installed in the pluto environment.
>>> The build uses the pluto environment to deploy the portlet.
>>> We can't assume a wsrp environment is there. This could be only a
>>> consumer-only environment running just pluto.
>>>
>>> Richard
>>>
>> ok, but Matthew Carey reported this as a bug in the installation (see
>> WSRP4J-20).
>>
>> It's probably ok to leave the default for wsrp in our build tree,
>> since we can't presume an existing pluto installation. How about if
>> I add a comment to this file that explains this:
>>
>> // the TARGET_WEBAPP_NAME should be set to "wsrp" for standalone
>> WSRP installations,
>> // or should be set to "pluto" in pluto installations, depending
>> upon how pluto is configured.
>>
>> Would this be ok?
>>
> I think this would be misleading. Since the proxyportlet is intended
> to run on pluto, I would leave the webapp being pluto.
> There is no sence to run the proxy portlet in a non-portal environment.
> My suggestion would be to remove (better rename)
> portlets/build/proxyportlet.include this prevents the proxyportlet to
> be built and deployed by default.
> Then we should add an extra build target which actually builds and
> deploys only the proxyportlet in the pluto environment.
> Need to review/restructure the build.
> Currently we use deployPortlets for this which builds/deploys ALL the
> portlets which are explicitly included (by using the x.include file).
> However the portlets are "producer" portlets while the proxyportlet is
> a exception, i.e. it is for the consumer environment.
> Therefor change in the build would make much more sense.
>
> cheers
> Richard
>
ok, I see what you mean. I will change it back.
--
Julie MacNaught
IBM Research
jmacna@apache.org
jmacna@us.ibm.com
Re: cvs commit: ws-wsrp4j/portlets/proxyportlet build.properties.example
Posted by Richard Jacob <ja...@apache.org>.
Julie MacNaught wrote:
>
> Richard Jacob wrote:
>
>> jmacna@apache.org wrote:
>>
>>> jmacna 2004/06/15 07:37:34
>>>
>>> Modified: portlets/wsrptest build.properties.example
>>> portlets/proxyportlet build.properties.example
>>> Log:
>>> Fix default property values for each portlet to be consistent with
>>> eachother.
>>>
>>>
>>>
>>> -TARGET_WEBAPP_NAME=pluto
>>> \ No newline at end of file
>>> +TARGET_WEBAPP_NAME=wsrp
>>> \ No newline at end of file
>>>
>>>
>> I think we must leave the value to be pluto since the proxyportlet is
>> installed in the pluto environment.
>> The build uses the pluto environment to deploy the portlet.
>> We can't assume a wsrp environment is there. This could be only a
>> consumer-only environment running just pluto.
>>
>> Richard
>>
> ok, but Matthew Carey reported this as a bug in the installation (see
> WSRP4J-20).
>
> It's probably ok to leave the default for wsrp in our build tree,
> since we can't presume an existing pluto installation. How about if I
> add a comment to this file that explains this:
>
> // the TARGET_WEBAPP_NAME should be set to "wsrp" for standalone
> WSRP installations,
> // or should be set to "pluto" in pluto installations, depending upon
> how pluto is configured.
>
> Would this be ok?
>
I think this would be misleading. Since the proxyportlet is intended to
run on pluto, I would leave the webapp being pluto.
There is no sence to run the proxy portlet in a non-portal environment.
My suggestion would be to remove (better rename)
portlets/build/proxyportlet.include this prevents the proxyportlet to be
built and deployed by default.
Then we should add an extra build target which actually builds and
deploys only the proxyportlet in the pluto environment.
Need to review/restructure the build.
Currently we use deployPortlets for this which builds/deploys ALL the
portlets which are explicitly included (by using the x.include file).
However the portlets are "producer" portlets while the proxyportlet is a
exception, i.e. it is for the consumer environment.
Therefor change in the build would make much more sense.
cheers
Richard
Re: cvs commit: ws-wsrp4j/portlets/proxyportlet build.properties.example
Posted by Julie MacNaught <jm...@apache.org>.
Richard Jacob wrote:
> jmacna@apache.org wrote:
>
>> jmacna 2004/06/15 07:37:34
>>
>> Modified: portlets/wsrptest build.properties.example
>> portlets/proxyportlet build.properties.example
>> Log:
>> Fix default property values for each portlet to be consistent with
>> eachother.
>>
>>
>>
>> -TARGET_WEBAPP_NAME=pluto
>> \ No newline at end of file
>> +TARGET_WEBAPP_NAME=wsrp
>> \ No newline at end of file
>>
>>
> I think we must leave the value to be pluto since the proxyportlet is
> installed in the pluto environment.
> The build uses the pluto environment to deploy the portlet.
> We can't assume a wsrp environment is there. This could be only a
> consumer-only environment running just pluto.
>
> Richard
>
ok, but Matthew Carey reported this as a bug in the installation (see
WSRP4J-20).
It's probably ok to leave the default for wsrp in our build tree, since
we can't presume an existing pluto installation. How about if I add a
comment to this file that explains this:
// the TARGET_WEBAPP_NAME should be set to "wsrp" for standalone WSRP
installations,
// or should be set to "pluto" in pluto installations, depending upon
how pluto is configured.
Would this be ok?
Julie
--
Julie MacNaught
IBM Research
jmacna@apache.org
jmacna@us.ibm.com
Re: cvs commit: ws-wsrp4j/portlets/proxyportlet build.properties.example
Posted by Richard Jacob <ja...@apache.org>.
jmacna@apache.org wrote:
>jmacna 2004/06/15 07:37:34
>
> Modified: portlets/wsrptest build.properties.example
> portlets/proxyportlet build.properties.example
> Log:
> Fix default property values for each portlet to be consistent with eachother.
>
>
>
> -TARGET_WEBAPP_NAME=pluto
> \ No newline at end of file
> +TARGET_WEBAPP_NAME=wsrp
> \ No newline at end of file
>
>
I think we must leave the value to be pluto since the proxyportlet is
installed in the pluto environment.
The build uses the pluto environment to deploy the portlet.
We can't assume a wsrp environment is there. This could be only a
consumer-only environment running just pluto.
Richard