You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/10/09 09:02:52 UTC
[GitHub] [spark] beliefer opened a new pull request, #38178: [SPARK-40716][SQL] Relax the restrictions of broadcast join on bloom filter
beliefer opened a new pull request, #38178:
URL: https://github.com/apache/spark/pull/38178
### What changes were proposed in this pull request?
Currently, if the creation side of bloom filter could be broadcasted, Spark cannot inject a bloom filter or InSunquery filter into the application side.
In fact, although we use broadcast join and improves the performance, compared with the reduction of data volume, it is still worse if the application side have many rows.
We just need the creation side is small enough.
As we know, bloom filter ensures creation side is small enough with the code below.
```
// Skip if the filter creation side is too big
if (filterCreationSidePlan.stats.sizeInBytes > conf.runtimeFilterCreationSideThreshold) {
return filterApplicationSidePlan
}
```
InSunquery filter ensures creation side is small enough with the code below.
```
val aggregate = Aggregate(Seq(alias), Seq(alias), filterCreationSidePlan)
if (!canBroadcastBySize(aggregate, conf)) {
// Skip the InSubquery filter if the size of `aggregate` is beyond broadcast join threshold,
// i.e., the semi-join will be a shuffled join, which is not worthwhile.
return filterApplicationSidePlan
}
```
### Why are the changes needed?
Relax the restrictions of broadcast join on bloom filter, so as the runtime filter applicable to more scenarios.
### Does this PR introduce _any_ user-facing change?
'No'.
Just update the inner implementation.
### How was this patch tested?
New tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #38178: [SPARK-40716][SQL] Relax the restrictions of broadcast join on bloom filter
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on PR #38178:
URL: https://github.com/apache/spark/pull/38178#issuecomment-1277095695
what's the result of TPCDS?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #38178: [SPARK-40716][SQL] Relax the restrictions of broadcast join on bloom filter
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on PR #38178:
URL: https://github.com/apache/spark/pull/38178#issuecomment-1277095575
@maryannxue @sigmod
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on pull request #38178: [SPARK-40716][SQL] Relax the restrictions of broadcast join on bloom filter
Posted by GitBox <gi...@apache.org>.
beliefer commented on PR #38178:
URL: https://github.com/apache/spark/pull/38178#issuecomment-1272495163
ping @somani cc @cloud-fan
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on pull request #38178: [SPARK-40716][SQL] Relax the restrictions of broadcast join on bloom filter
Posted by GitBox <gi...@apache.org>.
beliefer commented on PR #38178:
URL: https://github.com/apache/spark/pull/38178#issuecomment-1277424743
> what's the result of TPCDS?
I'm collecting.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org