You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@struts.apache.org by lukaszlenart <gi...@git.apache.org> on 2014/06/27 13:10:12 UTC
[GitHub] struts pull request: Feature: list value localization
GitHub user lukaszlenart opened a pull request:
https://github.com/apache/struts/pull/18
Feature: list value localization
This is continuation of @abrin work started in #7
Closes [WW-4295](https://issues.apache.org/jira/browse/WW-4295)
Closes #7
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/struts feature/WW-4295-localization
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/struts/pull/18.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #18
----
commit 7f586d39b7f8411e22fd13de8025f1866477fc3c
Author: adam brin <ad...@asu.edu>
Date: 2014-03-18T14:36:28Z
[PATCH] First attempt at enabling value-labels to be pulled from
Locale Files. Adding listValueKey attribute to checkboxList, radioMap, and
select tags.
Issues:
This implementation uses the <@s.text> tag to handle the localization with an assignment. I presume this is less than idea, but I lack the knowledge of the Struts2 tag model that would suggest where to check for this on the valueStack or elsewhere.
Example:
public enum yesno {
YES, NO;
}
<@s.radio name="yes no" list="#{yesno.values()}" valueKey="name()" />
<!-- this will look for the name() in the locale file and emit the localized value for the label of the radio button.
commit 901893628b31ee3b38b2fc9196045a097a0f4217
Author: Lukasz Lenart <lu...@apache.org>
Date: 2014-03-20T07:08:03Z
Adds additional field to allow set label key used in I18N lookup
commit 69df87047ab2a72c339a0ee320459757ba439f40
Author: Lukasz Lenart <lu...@apache.org>
Date: 2014-03-20T07:08:27Z
Extends template to use the new field to localise value's label
commit 7e98fe7a731b44bb85375f9363465838803a0a16
Author: Lukasz Lenart <lu...@apache.org>
Date: 2014-03-20T07:08:50Z
Adds autogenerated files
commit b78349ad5dade8a47fb335f6ef18c13a36101842
Author: Lukasz Lenart <lu...@apache.org>
Date: 2014-03-20T07:12:13Z
Extends blank app to demonstrate the new possibilities
commit 6def514524e81c4af188b47b6694384eea3a46c6
Author: adam brin <ad...@asu.edu>
Date: 2014-03-24T14:31:54Z
updating ListUIBean
updating java-backed bean
commit 23498a332119486a043e852366dfb73495a510d9
Author: Lukasz Lenart <lu...@apache.org>
Date: 2014-06-27T06:40:49Z
Merge remote-tracking branch 'abrin/feature-WW-4295-localization' into feature/WW-4295-localization
commit ca230ab30fde249d8af17cc5f2ba83ebe142d364
Author: Lukasz Lenart <lu...@apache.org>
Date: 2014-06-27T10:54:26Z
Adds auto-generated tags' info
commit 13269fa15f02409732ca51545141a40ae2f4680c
Author: Lukasz Lenart <lu...@apache.org>
Date: 2014-06-27T10:54:44Z
Adds missing tag attribute field
commit a2791a8305666859d6484098fb597f93c94908bc
Author: Lukasz Lenart <lu...@apache.org>
Date: 2014-06-27T10:55:13Z
Removes optional valueKey to keep backward compatibility
commit ed8a0b87b29114ac5c99838e7d4cfc819ad71e43
Author: Lukasz Lenart <lu...@apache.org>
Date: 2014-06-27T10:55:43Z
Checks is ListValueKey was defined and returns value
commit d67fce1f2577229139938d4588bb970c3f869078
Author: Lukasz Lenart <lu...@apache.org>
Date: 2014-06-27T10:56:01Z
Extends test to use the new attribute
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
[GitHub] struts pull request: Feature: list value localization
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/struts/pull/18
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
[GitHub] struts pull request: Feature: list value localization
Posted by lukaszlenart <gi...@git.apache.org>.
Github user lukaszlenart commented on the pull request:
https://github.com/apache/struts/pull/18#issuecomment-47332904
@abrin can you review the changes or test them locally? I don't see value in the changes right now as I don't now how do you want to use them. Check the provided test case in d67fce1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org