You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@beehive.apache.org by "Nathan Jantz (JIRA)" <be...@incubator.apache.org> on 2005/02/01 01:10:17 UTC
[jira] Created: (BEEHIVE-217) Inherited page flows do not inherit the correct config path to a Tiles Definition file as defined by the parent Controller class.
Inherited page flows do not inherit the correct config path to a Tiles Definition file as defined by the parent Controller class.
---------------------------------------------------------------------------------------------------------------------------------
Key: BEEHIVE-217
URL: http://issues.apache.org/jira/browse/BEEHIVE-217
Project: Beehive
Type: Bug
Components: NetUI
Versions: V1Beta
Environment: Running the usual components required by Beehive V1Beta on a Win32 box. Local test environment.
Reporter: Nathan Jantz
Inherited page flows do not inherit the correct config path to a Tiles Definition file as defined by the parent Controller class.
Example use-case (inherited page flow):
------------------------------------------
ParentPageFlow.jpf:
@Jpf.Controller(
tilesDefinitionsConfigs = { "tiles-defs.xml" },
simpleActions={
@Jpf.SimpleAction(name="begin", tilesDefinition="default.page")
}
)
ChildPageFlow.jpf (extends ParentPageFlow):
ChildFlow1Controller.jpf:
@Jpf.Controller(
simpleActions={
@Jpf.SimpleAction(name="begin", tilesDefinition="default.page")
}
)
Generated struts-config output:
<plug-in className="org.apache.struts.tiles.TilesPlugin">
<set-property property="definitions-config" value="\childFlow1/tiles-defs.xml"/>
<set-property property="moduleAware" value="true"/>
</plug-in>
Reference to tiles-defs.xml is incorrect. tiles-defs.xml lives in the ParentPageFlow directory. ChildPageFlow should of inherited the correct path.
This currently limits how tiles can be set up within inherited page flows. In other words, the current PF implementation doesn't support sharing of one common tiles definition file (tiles-defs.xml) AND an associated common set of JSPs among inherited page flows. It requires multiple tiles definitions and JSP tiles to live in different places within the same webapp. This does not encourage code re-use.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
[jira] Assigned: (BEEHIVE-217) Inherited page flows do not inherit the correct config path to a Tiles Definition file as defined by the parent Controller class.
Posted by "carlin rogers (JIRA)" <be...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/BEEHIVE-217?page=history ]
carlin rogers reassigned BEEHIVE-217:
-------------------------------------
Assign To: carlin rogers
> Inherited page flows do not inherit the correct config path to a Tiles Definition file as defined by the parent Controller class.
> ---------------------------------------------------------------------------------------------------------------------------------
>
> Key: BEEHIVE-217
> URL: http://issues.apache.org/jira/browse/BEEHIVE-217
> Project: Beehive
> Type: Bug
> Components: NetUI
> Versions: V1Beta
> Environment: Running the usual components required by Beehive V1Beta on a Win32 box. Local test environment.
> Reporter: Nathan Jantz
> Assignee: carlin rogers
>
> Inherited page flows do not inherit the correct config path to a Tiles Definition file as defined by the parent Controller class.
> Example use-case (inherited page flow):
> ------------------------------------------
> ParentPageFlow.jpf:
> @Jpf.Controller(
> tilesDefinitionsConfigs = { "tiles-defs.xml" },
> simpleActions={
> @Jpf.SimpleAction(name="begin", tilesDefinition="default.page")
> }
> )
> ChildPageFlow.jpf (extends ParentPageFlow):
> ChildFlow1Controller.jpf:
> @Jpf.Controller(
> simpleActions={
> @Jpf.SimpleAction(name="begin", tilesDefinition="default.page")
> }
> )
> Generated struts-config output:
> <plug-in className="org.apache.struts.tiles.TilesPlugin">
> <set-property property="definitions-config" value="\childFlow1/tiles-defs.xml"/>
> <set-property property="moduleAware" value="true"/>
> </plug-in>
> Reference to tiles-defs.xml is incorrect. tiles-defs.xml lives in the ParentPageFlow directory. ChildPageFlow should of inherited the correct path.
> This currently limits how tiles can be set up within inherited page flows. In other words, the current PF implementation doesn't support sharing of one common tiles definition file (tiles-defs.xml) AND an associated common set of JSPs among inherited page flows. It requires multiple tiles definitions and JSP tiles to live in different places within the same webapp. This does not encourage code re-use.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
[jira] Closed: (BEEHIVE-217) Inherited page flows do not inherit the correct config path to a Tiles Definition file as defined by the parent Controller class.
Posted by "Nathan Jantz (JIRA)" <be...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/BEEHIVE-217?page=all ]
Nathan Jantz closed BEEHIVE-217:
--------------------------------
Updating qaWeb Tiles support test suite accordingly. Closing issue.
> Inherited page flows do not inherit the correct config path to a Tiles Definition file as defined by the parent Controller class.
> ---------------------------------------------------------------------------------------------------------------------------------
>
> Key: BEEHIVE-217
> URL: http://issues.apache.org/jira/browse/BEEHIVE-217
> Project: Beehive
> Type: Bug
> Components: NetUI
> Versions: V1Beta
> Environment: Running the usual components required by Beehive V1Beta on a Win32 box. Local test environment.
> Reporter: Nathan Jantz
> Assignee: Nathan Jantz
> Attachments: patch.tar.gz, tiles-patch.txt
>
> Inherited page flows do not inherit the correct config path to a Tiles Definition file as defined by the parent Controller class.
> Example use-case (inherited page flow):
> ------------------------------------------
> ParentPageFlow.jpf:
> @Jpf.Controller(
> tilesDefinitionsConfigs = { "tiles-defs.xml" },
> simpleActions={
> @Jpf.SimpleAction(name="begin", tilesDefinition="default.page")
> }
> )
> ChildPageFlow.jpf (extends ParentPageFlow):
> ChildFlow1Controller.jpf:
> @Jpf.Controller(
> simpleActions={
> @Jpf.SimpleAction(name="begin", tilesDefinition="default.page")
> }
> )
> Generated struts-config output:
> <plug-in className="org.apache.struts.tiles.TilesPlugin">
> <set-property property="definitions-config" value="\childFlow1/tiles-defs.xml"/>
> <set-property property="moduleAware" value="true"/>
> </plug-in>
> Reference to tiles-defs.xml is incorrect. tiles-defs.xml lives in the ParentPageFlow directory. ChildPageFlow should of inherited the correct path.
> This currently limits how tiles can be set up within inherited page flows. In other words, the current PF implementation doesn't support sharing of one common tiles definition file (tiles-defs.xml) AND an associated common set of JSPs among inherited page flows. It requires multiple tiles definitions and JSP tiles to live in different places within the same webapp. This does not encourage code re-use.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (BEEHIVE-217) Inherited page flows do not inherit the correct config path to a Tiles Definition file as defined by the parent Controller class.
Posted by "Carlin Rogers (JIRA)" <be...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/BEEHIVE-217?page=comments#action_60535 ]
Carlin Rogers commented on BEEHIVE-217:
---------------------------------------
As pointed out, this is only an issue with using a
relative path in the tilesDefinitionsConfigs
attribute of the Controller annotation. An absolute
path from the web app root will work, even with
inheritance.
This bug points to a larger problem in that at compile
time we cannot check or verify where the tiles definitions
config file will live at deployment time.
Since the tilesDefinitionsConfigs attribute is used
at compile time only to set up a path to be used at
runtime, it's probably best just to accept an absolute
path.
I will put a change into the copiler to check for
an absolute path and report an error if the path
does not start with the '/' character.
> Inherited page flows do not inherit the correct config path to a Tiles Definition file as defined by the parent Controller class.
> ---------------------------------------------------------------------------------------------------------------------------------
>
> Key: BEEHIVE-217
> URL: http://issues.apache.org/jira/browse/BEEHIVE-217
> Project: Beehive
> Type: Bug
> Components: NetUI
> Versions: V1Beta
> Environment: Running the usual components required by Beehive V1Beta on a Win32 box. Local test environment.
> Reporter: Nathan Jantz
> Assignee: Carlin Rogers
>
> Inherited page flows do not inherit the correct config path to a Tiles Definition file as defined by the parent Controller class.
> Example use-case (inherited page flow):
> ------------------------------------------
> ParentPageFlow.jpf:
> @Jpf.Controller(
> tilesDefinitionsConfigs = { "tiles-defs.xml" },
> simpleActions={
> @Jpf.SimpleAction(name="begin", tilesDefinition="default.page")
> }
> )
> ChildPageFlow.jpf (extends ParentPageFlow):
> ChildFlow1Controller.jpf:
> @Jpf.Controller(
> simpleActions={
> @Jpf.SimpleAction(name="begin", tilesDefinition="default.page")
> }
> )
> Generated struts-config output:
> <plug-in className="org.apache.struts.tiles.TilesPlugin">
> <set-property property="definitions-config" value="\childFlow1/tiles-defs.xml"/>
> <set-property property="moduleAware" value="true"/>
> </plug-in>
> Reference to tiles-defs.xml is incorrect. tiles-defs.xml lives in the ParentPageFlow directory. ChildPageFlow should of inherited the correct path.
> This currently limits how tiles can be set up within inherited page flows. In other words, the current PF implementation doesn't support sharing of one common tiles definition file (tiles-defs.xml) AND an associated common set of JSPs among inherited page flows. It requires multiple tiles definitions and JSP tiles to live in different places within the same webapp. This does not encourage code re-use.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
[jira] Commented: (BEEHIVE-217) Inherited page flows do not inherit the correct config path to a Tiles Definition file as defined by the parent Controller class.
Posted by "Rich Feit (JIRA)" <be...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/BEEHIVE-217?page=comments#action_60579 ]
Rich Feit commented on BEEHIVE-217:
-----------------------------------
I agree with this new restriction... it was a mistake to allow relative paths based on the compile-time artifact, when the actual file is read in at runtime through ServletContext. Will apply this tomorrow.
> Inherited page flows do not inherit the correct config path to a Tiles Definition file as defined by the parent Controller class.
> ---------------------------------------------------------------------------------------------------------------------------------
>
> Key: BEEHIVE-217
> URL: http://issues.apache.org/jira/browse/BEEHIVE-217
> Project: Beehive
> Type: Bug
> Components: NetUI
> Versions: V1Beta
> Environment: Running the usual components required by Beehive V1Beta on a Win32 box. Local test environment.
> Reporter: Nathan Jantz
> Assignee: Rich Feit
> Attachments: tiles-patch.txt
>
> Inherited page flows do not inherit the correct config path to a Tiles Definition file as defined by the parent Controller class.
> Example use-case (inherited page flow):
> ------------------------------------------
> ParentPageFlow.jpf:
> @Jpf.Controller(
> tilesDefinitionsConfigs = { "tiles-defs.xml" },
> simpleActions={
> @Jpf.SimpleAction(name="begin", tilesDefinition="default.page")
> }
> )
> ChildPageFlow.jpf (extends ParentPageFlow):
> ChildFlow1Controller.jpf:
> @Jpf.Controller(
> simpleActions={
> @Jpf.SimpleAction(name="begin", tilesDefinition="default.page")
> }
> )
> Generated struts-config output:
> <plug-in className="org.apache.struts.tiles.TilesPlugin">
> <set-property property="definitions-config" value="\childFlow1/tiles-defs.xml"/>
> <set-property property="moduleAware" value="true"/>
> </plug-in>
> Reference to tiles-defs.xml is incorrect. tiles-defs.xml lives in the ParentPageFlow directory. ChildPageFlow should of inherited the correct path.
> This currently limits how tiles can be set up within inherited page flows. In other words, the current PF implementation doesn't support sharing of one common tiles definition file (tiles-defs.xml) AND an associated common set of JSPs among inherited page flows. It requires multiple tiles definitions and JSP tiles to live in different places within the same webapp. This does not encourage code re-use.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
[jira] Assigned: (BEEHIVE-217) Inherited page flows do not inherit the correct config path to a Tiles Definition file as defined by the parent Controller class.
Posted by "Carlin Rogers (JIRA)" <be...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/BEEHIVE-217?page=history ]
Carlin Rogers reassigned BEEHIVE-217:
-------------------------------------
Assign To: Rich Feit (was: Carlin Rogers)
Rich, could you review and submit this patch. Thanks,
Carlin
> Inherited page flows do not inherit the correct config path to a Tiles Definition file as defined by the parent Controller class.
> ---------------------------------------------------------------------------------------------------------------------------------
>
> Key: BEEHIVE-217
> URL: http://issues.apache.org/jira/browse/BEEHIVE-217
> Project: Beehive
> Type: Bug
> Components: NetUI
> Versions: V1Beta
> Environment: Running the usual components required by Beehive V1Beta on a Win32 box. Local test environment.
> Reporter: Nathan Jantz
> Assignee: Rich Feit
> Attachments: tiles-patch.txt
>
> Inherited page flows do not inherit the correct config path to a Tiles Definition file as defined by the parent Controller class.
> Example use-case (inherited page flow):
> ------------------------------------------
> ParentPageFlow.jpf:
> @Jpf.Controller(
> tilesDefinitionsConfigs = { "tiles-defs.xml" },
> simpleActions={
> @Jpf.SimpleAction(name="begin", tilesDefinition="default.page")
> }
> )
> ChildPageFlow.jpf (extends ParentPageFlow):
> ChildFlow1Controller.jpf:
> @Jpf.Controller(
> simpleActions={
> @Jpf.SimpleAction(name="begin", tilesDefinition="default.page")
> }
> )
> Generated struts-config output:
> <plug-in className="org.apache.struts.tiles.TilesPlugin">
> <set-property property="definitions-config" value="\childFlow1/tiles-defs.xml"/>
> <set-property property="moduleAware" value="true"/>
> </plug-in>
> Reference to tiles-defs.xml is incorrect. tiles-defs.xml lives in the ParentPageFlow directory. ChildPageFlow should of inherited the correct path.
> This currently limits how tiles can be set up within inherited page flows. In other words, the current PF implementation doesn't support sharing of one common tiles definition file (tiles-defs.xml) AND an associated common set of JSPs among inherited page flows. It requires multiple tiles definitions and JSP tiles to live in different places within the same webapp. This does not encourage code re-use.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
[jira] Resolved: (BEEHIVE-217) Inherited page flows do not inherit the correct config path to a Tiles Definition file as defined by the parent Controller class.
Posted by "Rich Feit (JIRA)" <be...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/BEEHIVE-217?page=history ]
Rich Feit resolved BEEHIVE-217:
-------------------------------
Assign To: Nathan Jantz (was: Rich Feit)
Resolution: Fixed
Addressed with revision 157848.
> Inherited page flows do not inherit the correct config path to a Tiles Definition file as defined by the parent Controller class.
> ---------------------------------------------------------------------------------------------------------------------------------
>
> Key: BEEHIVE-217
> URL: http://issues.apache.org/jira/browse/BEEHIVE-217
> Project: Beehive
> Type: Bug
> Components: NetUI
> Versions: V1Beta
> Environment: Running the usual components required by Beehive V1Beta on a Win32 box. Local test environment.
> Reporter: Nathan Jantz
> Assignee: Nathan Jantz
> Attachments: patch.tar.gz, tiles-patch.txt
>
> Inherited page flows do not inherit the correct config path to a Tiles Definition file as defined by the parent Controller class.
> Example use-case (inherited page flow):
> ------------------------------------------
> ParentPageFlow.jpf:
> @Jpf.Controller(
> tilesDefinitionsConfigs = { "tiles-defs.xml" },
> simpleActions={
> @Jpf.SimpleAction(name="begin", tilesDefinition="default.page")
> }
> )
> ChildPageFlow.jpf (extends ParentPageFlow):
> ChildFlow1Controller.jpf:
> @Jpf.Controller(
> simpleActions={
> @Jpf.SimpleAction(name="begin", tilesDefinition="default.page")
> }
> )
> Generated struts-config output:
> <plug-in className="org.apache.struts.tiles.TilesPlugin">
> <set-property property="definitions-config" value="\childFlow1/tiles-defs.xml"/>
> <set-property property="moduleAware" value="true"/>
> </plug-in>
> Reference to tiles-defs.xml is incorrect. tiles-defs.xml lives in the ParentPageFlow directory. ChildPageFlow should of inherited the correct path.
> This currently limits how tiles can be set up within inherited page flows. In other words, the current PF implementation doesn't support sharing of one common tiles definition file (tiles-defs.xml) AND an associated common set of JSPs among inherited page flows. It requires multiple tiles definitions and JSP tiles to live in different places within the same webapp. This does not encourage code re-use.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
[jira] Updated: (BEEHIVE-217) Inherited page flows do not inherit the correct config path to a Tiles Definition file as defined by the parent Controller class.
Posted by "Carlin Rogers (JIRA)" <be...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/BEEHIVE-217?page=history ]
Carlin Rogers updated BEEHIVE-217:
----------------------------------
Attachment: tiles-patch.txt
This patch modifies the TilesDefinitionsConfigsType class to make
sure that the paths for the tiles def files are absolute from the
webapp root.
The patch also contains tests for inheritance and nested page flows
that use tiles.
> Inherited page flows do not inherit the correct config path to a Tiles Definition file as defined by the parent Controller class.
> ---------------------------------------------------------------------------------------------------------------------------------
>
> Key: BEEHIVE-217
> URL: http://issues.apache.org/jira/browse/BEEHIVE-217
> Project: Beehive
> Type: Bug
> Components: NetUI
> Versions: V1Beta
> Environment: Running the usual components required by Beehive V1Beta on a Win32 box. Local test environment.
> Reporter: Nathan Jantz
> Assignee: Carlin Rogers
> Attachments: tiles-patch.txt
>
> Inherited page flows do not inherit the correct config path to a Tiles Definition file as defined by the parent Controller class.
> Example use-case (inherited page flow):
> ------------------------------------------
> ParentPageFlow.jpf:
> @Jpf.Controller(
> tilesDefinitionsConfigs = { "tiles-defs.xml" },
> simpleActions={
> @Jpf.SimpleAction(name="begin", tilesDefinition="default.page")
> }
> )
> ChildPageFlow.jpf (extends ParentPageFlow):
> ChildFlow1Controller.jpf:
> @Jpf.Controller(
> simpleActions={
> @Jpf.SimpleAction(name="begin", tilesDefinition="default.page")
> }
> )
> Generated struts-config output:
> <plug-in className="org.apache.struts.tiles.TilesPlugin">
> <set-property property="definitions-config" value="\childFlow1/tiles-defs.xml"/>
> <set-property property="moduleAware" value="true"/>
> </plug-in>
> Reference to tiles-defs.xml is incorrect. tiles-defs.xml lives in the ParentPageFlow directory. ChildPageFlow should of inherited the correct path.
> This currently limits how tiles can be set up within inherited page flows. In other words, the current PF implementation doesn't support sharing of one common tiles definition file (tiles-defs.xml) AND an associated common set of JSPs among inherited page flows. It requires multiple tiles definitions and JSP tiles to live in different places within the same webapp. This does not encourage code re-use.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
[jira] Updated: (BEEHIVE-217) Inherited page flows do not inherit the correct config path to a Tiles Definition file as defined by the parent Controller class.
Posted by "Carlin Rogers (JIRA)" <be...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/BEEHIVE-217?page=history ]
Carlin Rogers updated BEEHIVE-217:
----------------------------------
Attachment: patch.tar.gz
Rich,
Here's a new patch to replace the earlier patch I attached. This
patch is up to date with the latest compiler changes and directory
structure changes. It includes...
- a fix to require the paths to the tiles definitions configuration
files be absolute from the webapp root.
- a test for tiles and page flow inheritance (Jira Beehive-217)
- a test for tiles and nested page flow (Jira Beehive-199)
- an update to the TilesDefinition test and the supporting files in
coreWeb/miniTests/tiles to exercise the case outlined in Jira
Beehive-158.
- general tiles test clean up.
> Inherited page flows do not inherit the correct config path to a Tiles Definition file as defined by the parent Controller class.
> ---------------------------------------------------------------------------------------------------------------------------------
>
> Key: BEEHIVE-217
> URL: http://issues.apache.org/jira/browse/BEEHIVE-217
> Project: Beehive
> Type: Bug
> Components: NetUI
> Versions: V1Beta
> Environment: Running the usual components required by Beehive V1Beta on a Win32 box. Local test environment.
> Reporter: Nathan Jantz
> Assignee: Rich Feit
> Attachments: patch.tar.gz, tiles-patch.txt
>
> Inherited page flows do not inherit the correct config path to a Tiles Definition file as defined by the parent Controller class.
> Example use-case (inherited page flow):
> ------------------------------------------
> ParentPageFlow.jpf:
> @Jpf.Controller(
> tilesDefinitionsConfigs = { "tiles-defs.xml" },
> simpleActions={
> @Jpf.SimpleAction(name="begin", tilesDefinition="default.page")
> }
> )
> ChildPageFlow.jpf (extends ParentPageFlow):
> ChildFlow1Controller.jpf:
> @Jpf.Controller(
> simpleActions={
> @Jpf.SimpleAction(name="begin", tilesDefinition="default.page")
> }
> )
> Generated struts-config output:
> <plug-in className="org.apache.struts.tiles.TilesPlugin">
> <set-property property="definitions-config" value="\childFlow1/tiles-defs.xml"/>
> <set-property property="moduleAware" value="true"/>
> </plug-in>
> Reference to tiles-defs.xml is incorrect. tiles-defs.xml lives in the ParentPageFlow directory. ChildPageFlow should of inherited the correct path.
> This currently limits how tiles can be set up within inherited page flows. In other words, the current PF implementation doesn't support sharing of one common tiles definition file (tiles-defs.xml) AND an associated common set of JSPs among inherited page flows. It requires multiple tiles definitions and JSP tiles to live in different places within the same webapp. This does not encourage code re-use.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira