You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/08/13 13:19:59 UTC
[GitHub] [flink] liupc opened a new pull request #13141: [FLINK-18852] Fix StreamScan don't inherit parallelism from input in legacy planner
liupc opened a new pull request #13141:
URL: https://github.com/apache/flink/pull/13141
…legacy planner
## What is the purpose of the change
Currently in legacy planner, StreamScan don't inherit parallelism from input, which is unexpected.
This PR will fix it.
## Brief change log
Fix StreamScan parallelism
## Verifying this change
This change is verified through UT (TableSourceITCase#testStreamScanParallelism)
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: ( no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong merged pull request #13141: [FLINK-18852] Fix StreamScan doesn't inherit parallelism from input in legacy planner
Posted by GitBox <gi...@apache.org>.
wuchong merged pull request #13141:
URL: https://github.com/apache/flink/pull/13141
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13141: [FLINK-18852] Fix StreamScan doesn't inherit parallelism from input in legacy planner
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13141:
URL: https://github.com/apache/flink/pull/13141#issuecomment-673492124
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ed47271c426abff4426ccf2d0fd5858e6f3d8390",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5508",
"triggerID" : "ed47271c426abff4426ccf2d0fd5858e6f3d8390",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ed47271c426abff4426ccf2d0fd5858e6f3d8390 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5508)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13141: [FLINK-18852] Fix StreamScan doesn't inherit parallelism from input in legacy planner
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13141:
URL: https://github.com/apache/flink/pull/13141#issuecomment-673492124
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ed47271c426abff4426ccf2d0fd5858e6f3d8390",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5508",
"triggerID" : "ed47271c426abff4426ccf2d0fd5858e6f3d8390",
"triggerType" : "PUSH"
}, {
"hash" : "09f938c175da27a7e2a50418259cf006f4794db6",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5534",
"triggerID" : "09f938c175da27a7e2a50418259cf006f4794db6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 09f938c175da27a7e2a50418259cf006f4794db6 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5534)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13141: [FLINK-18852] Fix StreamScan doesn't inherit parallelism from input in legacy planner
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13141:
URL: https://github.com/apache/flink/pull/13141#issuecomment-673492124
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ed47271c426abff4426ccf2d0fd5858e6f3d8390",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5508",
"triggerID" : "ed47271c426abff4426ccf2d0fd5858e6f3d8390",
"triggerType" : "PUSH"
}, {
"hash" : "09f938c175da27a7e2a50418259cf006f4794db6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5534",
"triggerID" : "09f938c175da27a7e2a50418259cf006f4794db6",
"triggerType" : "PUSH"
}, {
"hash" : "0e9c4198095239ebee07a466a5e23de1a60809ac",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5581",
"triggerID" : "0e9c4198095239ebee07a466a5e23de1a60809ac",
"triggerType" : "PUSH"
}, {
"hash" : "0e9c4198095239ebee07a466a5e23de1a60809ac",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5768",
"triggerID" : "678122726",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 0e9c4198095239ebee07a466a5e23de1a60809ac Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5581) Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5768)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13141: [FLINK-18852] Fix StreamScan doesn't inherit parallelism from input in legacy planner
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13141:
URL: https://github.com/apache/flink/pull/13141#issuecomment-673492124
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ed47271c426abff4426ccf2d0fd5858e6f3d8390",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5508",
"triggerID" : "ed47271c426abff4426ccf2d0fd5858e6f3d8390",
"triggerType" : "PUSH"
}, {
"hash" : "09f938c175da27a7e2a50418259cf006f4794db6",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5534",
"triggerID" : "09f938c175da27a7e2a50418259cf006f4794db6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ed47271c426abff4426ccf2d0fd5858e6f3d8390 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5508)
* 09f938c175da27a7e2a50418259cf006f4794db6 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5534)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13141: [FLINK-18852] Fix StreamScan doesn't inherit parallelism from input in legacy planner
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13141:
URL: https://github.com/apache/flink/pull/13141#issuecomment-673492124
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ed47271c426abff4426ccf2d0fd5858e6f3d8390",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5508",
"triggerID" : "ed47271c426abff4426ccf2d0fd5858e6f3d8390",
"triggerType" : "PUSH"
}, {
"hash" : "09f938c175da27a7e2a50418259cf006f4794db6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5534",
"triggerID" : "09f938c175da27a7e2a50418259cf006f4794db6",
"triggerType" : "PUSH"
}, {
"hash" : "0e9c4198095239ebee07a466a5e23de1a60809ac",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5581",
"triggerID" : "0e9c4198095239ebee07a466a5e23de1a60809ac",
"triggerType" : "PUSH"
}, {
"hash" : "0e9c4198095239ebee07a466a5e23de1a60809ac",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5768",
"triggerID" : "678122726",
"triggerType" : "MANUAL"
}, {
"hash" : "0e9c4198095239ebee07a466a5e23de1a60809ac",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5581",
"triggerID" : "678122726",
"triggerType" : "MANUAL"
}, {
"hash" : "2ae1223cf2a3be7c8fea0666821a217e8fa2c841",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "2ae1223cf2a3be7c8fea0666821a217e8fa2c841",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0e9c4198095239ebee07a466a5e23de1a60809ac Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5768) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5581)
* 2ae1223cf2a3be7c8fea0666821a217e8fa2c841 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13141: [FLINK-18852] Fix StreamScan doesn't inherit parallelism from input in legacy planner
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13141:
URL: https://github.com/apache/flink/pull/13141#issuecomment-673492124
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ed47271c426abff4426ccf2d0fd5858e6f3d8390",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5508",
"triggerID" : "ed47271c426abff4426ccf2d0fd5858e6f3d8390",
"triggerType" : "PUSH"
}, {
"hash" : "09f938c175da27a7e2a50418259cf006f4794db6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5534",
"triggerID" : "09f938c175da27a7e2a50418259cf006f4794db6",
"triggerType" : "PUSH"
}, {
"hash" : "0e9c4198095239ebee07a466a5e23de1a60809ac",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5581",
"triggerID" : "0e9c4198095239ebee07a466a5e23de1a60809ac",
"triggerType" : "PUSH"
}, {
"hash" : "0e9c4198095239ebee07a466a5e23de1a60809ac",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5768",
"triggerID" : "678122726",
"triggerType" : "MANUAL"
}, {
"hash" : "0e9c4198095239ebee07a466a5e23de1a60809ac",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5581",
"triggerID" : "678122726",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 0e9c4198095239ebee07a466a5e23de1a60809ac Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5768) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5581)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #13141: [FLINK-18852] Fix StreamScan doesn't inherit parallelism from input in legacy planner
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13141:
URL: https://github.com/apache/flink/pull/13141#issuecomment-673478896
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 1e0d7729ac211cbc589de64bc745f3ea5da0063b (Thu Aug 13 13:29:20 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13141: [FLINK-18852] Fix StreamScan doesn't inherit parallelism from input in legacy planner
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13141:
URL: https://github.com/apache/flink/pull/13141#issuecomment-673492124
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ed47271c426abff4426ccf2d0fd5858e6f3d8390",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5508",
"triggerID" : "ed47271c426abff4426ccf2d0fd5858e6f3d8390",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ed47271c426abff4426ccf2d0fd5858e6f3d8390 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5508)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13141: [FLINK-18852] Fix StreamScan doesn't inherit parallelism from input in legacy planner
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13141:
URL: https://github.com/apache/flink/pull/13141#issuecomment-673492124
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ed47271c426abff4426ccf2d0fd5858e6f3d8390",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5508",
"triggerID" : "ed47271c426abff4426ccf2d0fd5858e6f3d8390",
"triggerType" : "PUSH"
}, {
"hash" : "09f938c175da27a7e2a50418259cf006f4794db6",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5534",
"triggerID" : "09f938c175da27a7e2a50418259cf006f4794db6",
"triggerType" : "PUSH"
}, {
"hash" : "0e9c4198095239ebee07a466a5e23de1a60809ac",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "0e9c4198095239ebee07a466a5e23de1a60809ac",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 09f938c175da27a7e2a50418259cf006f4794db6 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5534)
* 0e9c4198095239ebee07a466a5e23de1a60809ac UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13141: [FLINK-18852] Fix StreamScan doesn't inherit parallelism from input in legacy planner
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13141:
URL: https://github.com/apache/flink/pull/13141#issuecomment-673492124
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ed47271c426abff4426ccf2d0fd5858e6f3d8390",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5508",
"triggerID" : "ed47271c426abff4426ccf2d0fd5858e6f3d8390",
"triggerType" : "PUSH"
}, {
"hash" : "09f938c175da27a7e2a50418259cf006f4794db6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5534",
"triggerID" : "09f938c175da27a7e2a50418259cf006f4794db6",
"triggerType" : "PUSH"
}, {
"hash" : "0e9c4198095239ebee07a466a5e23de1a60809ac",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5581",
"triggerID" : "0e9c4198095239ebee07a466a5e23de1a60809ac",
"triggerType" : "PUSH"
}, {
"hash" : "0e9c4198095239ebee07a466a5e23de1a60809ac",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5768",
"triggerID" : "678122726",
"triggerType" : "MANUAL"
}, {
"hash" : "0e9c4198095239ebee07a466a5e23de1a60809ac",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5581",
"triggerID" : "678122726",
"triggerType" : "MANUAL"
}, {
"hash" : "2ae1223cf2a3be7c8fea0666821a217e8fa2c841",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6053",
"triggerID" : "2ae1223cf2a3be7c8fea0666821a217e8fa2c841",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0e9c4198095239ebee07a466a5e23de1a60809ac Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5768) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5581)
* 2ae1223cf2a3be7c8fea0666821a217e8fa2c841 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6053)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13141: [FLINK-18852] Fix StreamScan doesn't inherit parallelism from input in legacy planner
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13141:
URL: https://github.com/apache/flink/pull/13141#issuecomment-673492124
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ed47271c426abff4426ccf2d0fd5858e6f3d8390",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5508",
"triggerID" : "ed47271c426abff4426ccf2d0fd5858e6f3d8390",
"triggerType" : "PUSH"
}, {
"hash" : "09f938c175da27a7e2a50418259cf006f4794db6",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5534",
"triggerID" : "09f938c175da27a7e2a50418259cf006f4794db6",
"triggerType" : "PUSH"
}, {
"hash" : "0e9c4198095239ebee07a466a5e23de1a60809ac",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5581",
"triggerID" : "0e9c4198095239ebee07a466a5e23de1a60809ac",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 09f938c175da27a7e2a50418259cf006f4794db6 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5534)
* 0e9c4198095239ebee07a466a5e23de1a60809ac Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5581)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] liupc commented on pull request #13141: [FLINK-18852] Fix StreamScan doesn't inherit parallelism from input in legacy planner
Posted by GitBox <gi...@apache.org>.
liupc commented on pull request #13141:
URL: https://github.com/apache/flink/pull/13141#issuecomment-678122726
@flinkbot run azure
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong commented on a change in pull request #13141: [FLINK-18852] Fix StreamScan doesn't inherit parallelism from input in legacy planner
Posted by GitBox <gi...@apache.org>.
wuchong commented on a change in pull request #13141:
URL: https://github.com/apache/flink/pull/13141#discussion_r470424738
##########
File path: flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/runtime/stream/table/TableSourceITCase.scala
##########
@@ -81,6 +81,51 @@ class TableSourceITCase extends AbstractTestBase {
// info.
}
+ @Test
+ def testStreamScanParallelism(): Unit = {
+ val env = StreamExecutionEnvironment.getExecutionEnvironment
+ val settings = EnvironmentSettings.newInstance().useOldPlanner().build()
+ val tEnv = StreamTableEnvironment.create(env, settings)
+
+ // set environment parallelism to 4
+ env.setParallelism(4)
+
+ // test DataStreamScan
+ val table = env.fromElements[String]()
+ .setParallelism(1)
+ .toTable(tEnv, 'a)
+
+ tEnv.registerTable("MyTable1", table)
+ val parallelism = tEnv.scan("MyTable1")
+ .toAppendStream[String]
+ .getParallelism
+
+ assertEquals(1, parallelism)
+
+ // test StreamTableSourceScan
+ val tableSource = new StreamTableSource[String]() {
+
+ override def getDataStream(execEnv: JExecEnv): DataStream[String] = {
+ execEnv.fromElements[String]("blabla")
+ }
+
+ override def getTableSchema: TableSchema = {
+ new TableSchema(Array("a"), Array(Types.STRING()))
+ }
+
+ override def getReturnType: TypeInformation[String] = {
+ Types.STRING()
+ }
+ }
+
+ tEnv.asInstanceOf[TableEnvironmentInternal].registerTableSourceInternal("MyTable2", tableSource)
+ val parallelism2 = tEnv.scan("MyTable2")
+ .toAppendStream[String]
+ .getParallelism
+
+ assertEquals(1, parallelism2)
Review comment:
1. use new methods instead of depreacted methods
2. use DDL to register a table (StreamTableSourceScan path). `registerTableSourceInternal` is a hack way.
3. We may need to support `parallelism` property for the COLLECTION source (`TestCollectionTableFactory`).
```suggestion
tEnv.createTemporaryView("MyTable1", table)
val parallelism = tEnv.from("MyTable1")
.toAppendStream[String]
.parallelism
assertEquals(1, parallelism)
// test StreamTableSourceScan
val createTableStmt =
"""
|CREATE TEMPORARY TABLE MyTable2 (
| str varchar
|) with (
| 'connector' = 'COLLECTION',
| 'is-bounded' = 'false',
| 'parallelism' = '1'
|)
""".stripMargin
tEnv.executeSql(createTableStmt)
val parallelism2 = tEnv.from("MyTable2")
.toAppendStream[String]
.parallelism
assertEquals(1, parallelism2)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong commented on pull request #13141: [FLINK-18852] Fix StreamScan doesn't inherit parallelism from input in legacy planner
Posted by GitBox <gi...@apache.org>.
wuchong commented on pull request #13141:
URL: https://github.com/apache/flink/pull/13141#issuecomment-685287870
Merging...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] liupc commented on pull request #13141: [FLINK-18852] Fix StreamScan doesn't inherit parallelism from input in legacy planner
Posted by GitBox <gi...@apache.org>.
liupc commented on pull request #13141:
URL: https://github.com/apache/flink/pull/13141#issuecomment-674630972
> There are some tests failed. Please have a look.
hi, @wuchong , I think the test failure has nothing to do with this PR.
It reports the test failures in ExplainTest.
https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=5534&view=logs&j=b2f046ab-ae17-5406-acdc-240be7e870e4&t=93e5ae06-d194-513d-ba8d-150ef6da1d7c&l=7515
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13141: [FLINK-18852] Fix StreamScan doesn't inherit parallelism from input in legacy planner
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13141:
URL: https://github.com/apache/flink/pull/13141#issuecomment-673492124
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ed47271c426abff4426ccf2d0fd5858e6f3d8390",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5508",
"triggerID" : "ed47271c426abff4426ccf2d0fd5858e6f3d8390",
"triggerType" : "PUSH"
}, {
"hash" : "09f938c175da27a7e2a50418259cf006f4794db6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5534",
"triggerID" : "09f938c175da27a7e2a50418259cf006f4794db6",
"triggerType" : "PUSH"
}, {
"hash" : "0e9c4198095239ebee07a466a5e23de1a60809ac",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5581",
"triggerID" : "0e9c4198095239ebee07a466a5e23de1a60809ac",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0e9c4198095239ebee07a466a5e23de1a60809ac Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5581)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] liupc commented on pull request #13141: [FLINK-18852] Fix StreamScan doesn't inherit parallelism from input in legacy planner
Posted by GitBox <gi...@apache.org>.
liupc commented on pull request #13141:
URL: https://github.com/apache/flink/pull/13141#issuecomment-679635208
gentle ping~ @wuchong
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #13141: [FLINK-18852] Fix StreamScan doesn't inherit parallelism from input in legacy planner
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13141:
URL: https://github.com/apache/flink/pull/13141#issuecomment-673492124
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ed47271c426abff4426ccf2d0fd5858e6f3d8390",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "ed47271c426abff4426ccf2d0fd5858e6f3d8390",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ed47271c426abff4426ccf2d0fd5858e6f3d8390 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] liupc commented on pull request #13141: [FLINK-18852] Fix StreamScan doesn't inherit parallelism from input in legacy planner
Posted by GitBox <gi...@apache.org>.
liupc commented on pull request #13141:
URL: https://github.com/apache/flink/pull/13141#issuecomment-673843587
cc @wuchong
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] liupc commented on pull request #13141: [FLINK-18852] Fix StreamScan doesn't inherit parallelism from input in legacy planner
Posted by GitBox <gi...@apache.org>.
liupc commented on pull request #13141:
URL: https://github.com/apache/flink/pull/13141#issuecomment-674631652
@wuchong Sorry, I check it again, it seems to be related with this parallelism changes, I will fix it!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13141: [FLINK-18852] Fix StreamScan doesn't inherit parallelism from input in legacy planner
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13141:
URL: https://github.com/apache/flink/pull/13141#issuecomment-673492124
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ed47271c426abff4426ccf2d0fd5858e6f3d8390",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5508",
"triggerID" : "ed47271c426abff4426ccf2d0fd5858e6f3d8390",
"triggerType" : "PUSH"
}, {
"hash" : "09f938c175da27a7e2a50418259cf006f4794db6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5534",
"triggerID" : "09f938c175da27a7e2a50418259cf006f4794db6",
"triggerType" : "PUSH"
}, {
"hash" : "0e9c4198095239ebee07a466a5e23de1a60809ac",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5581",
"triggerID" : "0e9c4198095239ebee07a466a5e23de1a60809ac",
"triggerType" : "PUSH"
}, {
"hash" : "0e9c4198095239ebee07a466a5e23de1a60809ac",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5768",
"triggerID" : "678122726",
"triggerType" : "MANUAL"
}, {
"hash" : "0e9c4198095239ebee07a466a5e23de1a60809ac",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5581",
"triggerID" : "678122726",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 0e9c4198095239ebee07a466a5e23de1a60809ac Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5768) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5581)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13141: [FLINK-18852] Fix StreamScan doesn't inherit parallelism from input in legacy planner
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13141:
URL: https://github.com/apache/flink/pull/13141#issuecomment-673492124
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ed47271c426abff4426ccf2d0fd5858e6f3d8390",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5508",
"triggerID" : "ed47271c426abff4426ccf2d0fd5858e6f3d8390",
"triggerType" : "PUSH"
}, {
"hash" : "09f938c175da27a7e2a50418259cf006f4794db6",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "09f938c175da27a7e2a50418259cf006f4794db6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ed47271c426abff4426ccf2d0fd5858e6f3d8390 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5508)
* 09f938c175da27a7e2a50418259cf006f4794db6 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong commented on pull request #13141: [FLINK-18852] Fix StreamScan doesn't inherit parallelism from input in legacy planner
Posted by GitBox <gi...@apache.org>.
wuchong commented on pull request #13141:
URL: https://github.com/apache/flink/pull/13141#issuecomment-674120246
There are some tests failed. Please have a look.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13141: [FLINK-18852] Fix StreamScan doesn't inherit parallelism from input in legacy planner
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13141:
URL: https://github.com/apache/flink/pull/13141#issuecomment-673492124
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ed47271c426abff4426ccf2d0fd5858e6f3d8390",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5508",
"triggerID" : "ed47271c426abff4426ccf2d0fd5858e6f3d8390",
"triggerType" : "PUSH"
}, {
"hash" : "09f938c175da27a7e2a50418259cf006f4794db6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5534",
"triggerID" : "09f938c175da27a7e2a50418259cf006f4794db6",
"triggerType" : "PUSH"
}, {
"hash" : "0e9c4198095239ebee07a466a5e23de1a60809ac",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5581",
"triggerID" : "0e9c4198095239ebee07a466a5e23de1a60809ac",
"triggerType" : "PUSH"
}, {
"hash" : "0e9c4198095239ebee07a466a5e23de1a60809ac",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5768",
"triggerID" : "678122726",
"triggerType" : "MANUAL"
}, {
"hash" : "0e9c4198095239ebee07a466a5e23de1a60809ac",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5581",
"triggerID" : "678122726",
"triggerType" : "MANUAL"
}, {
"hash" : "2ae1223cf2a3be7c8fea0666821a217e8fa2c841",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6053",
"triggerID" : "2ae1223cf2a3be7c8fea0666821a217e8fa2c841",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 2ae1223cf2a3be7c8fea0666821a217e8fa2c841 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6053)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org