You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@sling.apache.org by "Yegor Kozlov (Jira)" <ji...@apache.org> on 2020/03/24 07:53:00 UTC

[jira] [Created] (SLING-9247) Improve Performance Of Testing Ignored GET Parameters

Yegor Kozlov created SLING-9247:
-----------------------------------

             Summary: Improve Performance Of Testing Ignored GET Parameters
                 Key: SLING-9247
                 URL: https://issues.apache.org/jira/browse/SLING-9247
             Project: Sling
          Issue Type: Improvement
          Components: Extensions
    Affects Versions: Dynamic Include 3.1.6
            Reporter: Yegor Kozlov
             Fix For: Dynamic Include 3.2.0


This is a follow-up on SLING-9045

_org.apache.sling.dynamicinclude.Configuration_ loads the list of ignored GET parameters into a _java.util.List_ which is further checked from _IncludeTagFilter_ via _List#contains_

Calling _List#contains_ in a loop is kind of a smell. I believe _java.util.Set_ will be a more appropriate container with fixed O(1) cost of _contains()_.

 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)