You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by "jinhongyii (via GitHub)" <gi...@apache.org> on 2023/10/31 23:54:53 UTC

Re: [PR] [Unity] Extend RemoveAllUnused to support relax::Expr [tvm]

jinhongyii commented on PR #15807:
URL: https://github.com/apache/tvm/pull/15807#issuecomment-1788190352

   This PR has a bug when handling a use-def chain which ends at an impure call.
   Suppose the code is like 
   ```
   b = 2*a
   c = impure_call(b)
   return None
   ```
   Then b is an unused var (by your definition), but not an impure call, so it will be removed, which breaks the program.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org