[GitHub] [cloudstack] DaanHoogland commented on a diff in pull request #6245: Fix VM stats inconsistencies

[GitBox <gi...@apache.org>]

DaanHoogland commented on code in PR #6245:
URL: https://github.com/apache/cloudstack/pull/6245#discussion_r848224671


##########
ui/public/locales/pl.json:
##########
@@ -623,8 +623,8 @@
 "label.diskiopswriterate": "Disk Write Rate (IOPS)",
 "label.diskioread": "Disk Read (IO)",
 "label.diskiowrite": "Disk Write (IO)",
-"label.diskkbsread": "Disk Read (Bytes)",
-"label.diskkbswrite": "Disk Write (Bytes)",
+"label.diskkbsread": "Disk Read",
+"label.diskkbswrite": "Disk Write",

Review Comment:
   should these contain a `(KiB)` as well?



##########
plugins/metrics/src/main/java/org/apache/cloudstack/response/VmMetricsResponse.java:
##########
@@ -36,7 +36,7 @@ public class VmMetricsResponse extends UserVmResponse {
     private String cpuTotal;
 
     @SerializedName("memorytotal")
-    @Param(description = "the total memory capacity in GiB")
+    @Param(description = "the total memory capacity in GB")

Review Comment:
   is this `1000^3` and not `1024^3`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org