[GitHub] [arrow] assignUser commented on a diff in pull request #12940: ARROW-15015: [R] Test / CI flag for ensuring all tests are run?

[GitBox <gi...@apache.org>]

assignUser commented on code in PR #12940:
URL: https://github.com/apache/arrow/pull/12940#discussion_r855406310


##########
r/tests/testthat/helper-skip.R:
##########
@@ -69,12 +76,14 @@ skip_on_linux_devel <- function() {
 }
 
 skip_if_r_version <- function(r_version) {
+  if (force_tests) return()
   if (getRversion() <= r_version) {
     skip(paste("R version:", getRversion()))
   }
 }
 
 process_is_running <- function(x) {
+  if (force_tests) return(TRUE)

Review Comment:
   Yeah makes sense, as it caught me too :D



##########
r/tests/testthat/helper-skip.R:
##########
@@ -69,12 +76,14 @@ skip_on_linux_devel <- function() {
 }
 
 skip_if_r_version <- function(r_version) {
+  if (force_tests) return()
   if (getRversion() <= r_version) {
     skip(paste("R version:", getRversion()))
   }
 }
 
 process_is_running <- function(x) {
+  if (force_tests) return(TRUE)

Review Comment:
   Yeah makes sense, as it caught me too :D (the inverted behavior)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org