You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@uniffle.apache.org by "smallzhongfeng (via GitHub)" <gi...@apache.org> on 2023/03/29 08:02:46 UTC
[GitHub] [incubator-uniffle] smallzhongfeng opened a new issue, #778: [FEATURE] Separate ShuffleServers' metrics through tags
smallzhongfeng opened a new issue, #778:
URL: https://github.com/apache/incubator-uniffle/issues/778
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
### Search before asking
- [X] I have searched in the [issues](https://github.com/apache/incubator-uniffle/issues?q=is%3Aissue) and found no similar issues.
### Describe the feature
In the production environment, we have introduced tag, with the metrics of accessing Grafana. In order to better distinguish the metrics of shuffle-server with different tags, we need to separate them.
### Motivation
_No response_
### Describe the solution
_No response_
### Additional context
_No response_
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@uniffle.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-uniffle] zuston commented on issue #778: [FEATURE] Separate `ShuffleServer` metrics through tags
Posted by "zuston (via GitHub)" <gi...@apache.org>.
zuston commented on issue #778:
URL: https://github.com/apache/incubator-uniffle/issues/778#issuecomment-1501339698
Put `tag` into `labelNames` of metrics ? @smallzhongfeng
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-uniffle] smallzhongfeng commented on issue #778: [FEATURE] Separate `ShuffleServer` metrics through tags
Posted by "smallzhongfeng (via GitHub)" <gi...@apache.org>.
smallzhongfeng commented on issue #778:
URL: https://github.com/apache/incubator-uniffle/issues/778#issuecomment-1488123807
PTAL. @jerqi @zuston If necessary, I will raise a pr.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-uniffle] smallzhongfeng closed issue #778: [FEATURE] Separate `ShuffleServer` metrics through tags
Posted by "smallzhongfeng (via GitHub)" <gi...@apache.org>.
smallzhongfeng closed issue #778: [FEATURE] Separate `ShuffleServer` metrics through tags
URL: https://github.com/apache/incubator-uniffle/issues/778
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-uniffle] jerqi commented on issue #778: [FEATURE] Separate `ShuffleServer` metrics through tags
Posted by "jerqi (via GitHub)" <gi...@apache.org>.
jerqi commented on issue #778:
URL: https://github.com/apache/incubator-uniffle/issues/778#issuecomment-1502811128
> Just like this. Does this meet your expectations ? @zuston @jerqi
Ok for me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-uniffle] smallzhongfeng commented on issue #778: [FEATURE] Separate `ShuffleServer` metrics through tags
Posted by "smallzhongfeng (via GitHub)" <gi...@apache.org>.
smallzhongfeng commented on issue #778:
URL: https://github.com/apache/incubator-uniffle/issues/778#issuecomment-1502803443
Yes, currently our environment does this. @zuston
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-uniffle] smallzhongfeng commented on issue #778: [FEATURE] Separate `ShuffleServer` metrics through tags
Posted by "smallzhongfeng (via GitHub)" <gi...@apache.org>.
smallzhongfeng commented on issue #778:
URL: https://github.com/apache/incubator-uniffle/issues/778#issuecomment-1502806757
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-uniffle] smallzhongfeng commented on issue #778: [FEATURE] Separate `ShuffleServer` metrics through tags
Posted by "smallzhongfeng (via GitHub)" <gi...@apache.org>.
smallzhongfeng commented on issue #778:
URL: https://github.com/apache/incubator-uniffle/issues/778#issuecomment-1502809359
Just like this. Does this meet your expectations ? @zuston @jerqi
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-uniffle] jerqi commented on issue #778: [FEATURE] Separate `ShuffleServer` metrics through tags
Posted by "jerqi (via GitHub)" <gi...@apache.org>.
jerqi commented on issue #778:
URL: https://github.com/apache/incubator-uniffle/issues/778#issuecomment-1500375364
> PTAL. @jerqi @zuston If necessary, I will raise a pr.
OK for me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org