You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "yyqdbngt (via GitHub)" <gi...@apache.org> on 2026/08/30 01:29:27 UTC

[PR] fix(metrics): isolate unscoped snapshot history [rocketmq-dashboard]

yyqdbngt opened a new pull request, #2823:
URL: https://github.com/apache/rocketmq-dashboard/pull/2823

   ## Summary
   - constrain null-cluster metric history queries to rows whose cluster ID is also null
   - keep cluster-scoped snapshots out of unscoped alert aggregation
   - add query-wrapper regression coverage
   
   ## Why
   Omitting the cluster predicate for a null scope matched every cluster sharing the same instance, metric, domain, and labels, contaminating unscoped alert windows.
   
   ## Testing
   - `JAVA_HOME=/opt/homebrew/opt/openjdk@21 PATH=/opt/homebrew/opt/openjdk@21/bin:$PATH mvn -f server/pom.xml -Dtest=MybatisPlusMetricSnapshotRepositoryTest test`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] fix(metrics): isolate unscoped snapshot history [rocketmq-dashboard]

Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins closed pull request #2823: fix(metrics): isolate unscoped snapshot history
URL: https://github.com/apache/rocketmq-dashboard/pull/2823


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] fix(metrics): isolate unscoped snapshot history [rocketmq-dashboard]

Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins commented on PR #2823:
URL: https://github.com/apache/rocketmq-dashboard/pull/2823#issuecomment-5477581699

   Merged into the #2807 consolidation batch (same author, related cluster hardening fixes).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org