You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@flink.apache.org by GitBox <gi...@apache.org> on 2022/03/30 13:30:38 UTC

[GitHub] [flink-kubernetes-operator] SteNicholas opened a new pull request #139: [FLINK-26893] Validate checkpoint config with last-state upgrade mode

SteNicholas opened a new pull request #139:
URL: https://github.com/apache/flink-kubernetes-operator/pull/139


   When last-state upgrade mode is selected, the validation whether checkpointing is turned on (in addition to the HA settings) should be considered.
   
   **The brief change log**
   - `DefaultDeploymentValidator` adds the validation whether checkpointing is turned on when upgrade mode is `LAST_STATE`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink-kubernetes-operator] SteNicholas edited a comment on pull request #139: [FLINK-26893] Validate checkpoint config with last-state upgrade mode

Posted by GitBox <gi...@apache.org>.
SteNicholas edited a comment on pull request #139:
URL: https://github.com/apache/flink-kubernetes-operator/pull/139#issuecomment-1085628099


   > What I am thinking is to add a default value for `execution.checkpointing.interval` when HA enabled. It could be overridden by user specified CR or StreamExecutionEnvironment.enableCheckpointing(). Then we do not force users should set it explicitly in the CR.
   
   @wangyang0918, if this adds a default value for `execution.checkpointing.interval` when HA enabled, what's the default value for `execution.checkpointing.interval`?
   @gyfora, WDYT?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink-kubernetes-operator] wangyang0918 edited a comment on pull request #139: [FLINK-26893] Validate checkpoint config with last-state upgrade mode

Posted by GitBox <gi...@apache.org>.
wangyang0918 edited a comment on pull request #139:
URL: https://github.com/apache/flink-kubernetes-operator/pull/139#issuecomment-1085605936


   > for the jobs that enable the checkpoint via StreamExecutionEnvironment.enableCheckpointing(), we could guide the user to use the configuration method to open checkpoint.
   
   This will not work for session clusters since each job has different checkpoint interval.
   
   
   >  in Flink, when calling the StreamExecutionEnvironment.enableCheckpointing(), the execution.checkpointing.interval should be set with value of the interval for enableCheckpointing().
   
   This is impossible to set the value to flink config in the CR.
   
   
   What I am thinking is to add a default value for `execution.checkpointing.interval` when last-state upgrade mode is used. It could be overridden by user specified CR or `StreamExecutionEnvironment.enableCheckpointing()`. Then we do not force users should set it explicitly in the CR.
   
   @SteNicholas @gyfora WDYT?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink-kubernetes-operator] gyfora commented on a change in pull request #139: [FLINK-26893] Validate checkpoint config with last-state upgrade mode

Posted by GitBox <gi...@apache.org>.
gyfora commented on a change in pull request #139:
URL: https://github.com/apache/flink-kubernetes-operator/pull/139#discussion_r841161449



##########
File path: flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/utils/FlinkConfigBuilder.java
##########
@@ -94,6 +97,17 @@ public FlinkConfigBuilder applyFlinkConfiguration() {
                     REST_SERVICE_EXPOSED_TYPE,
                     KubernetesConfigOptions.ServiceExposedType.ClusterIP);
         }
+
+        // With last-state upgrade mode, set the default value of 'execution.checkpointing.interval'
+        // to 5 minutes when HA is enabled.
+        if (spec.getJob() != null
+                && spec.getJob().getUpgradeMode() == UpgradeMode.LAST_STATE
+                && FlinkUtils.isKubernetesHAActivated(effectiveConfig)

Review comment:
       The HA config is already validated for last-state mode by the DeploymentValidator, no need to check again here




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink-kubernetes-operator] SteNicholas commented on pull request #139: [FLINK-26893] Validate checkpoint config with last-state upgrade mode

Posted by GitBox <gi...@apache.org>.
SteNicholas commented on pull request #139:
URL: https://github.com/apache/flink-kubernetes-operator/pull/139#issuecomment-1085547523


   > that's true unfortunately
   
   IMO, for the jobs that enable the checkpoint via `StreamExecutionEnvironment.enableCheckpointing()`, we could guide the user to use the configuration method to open checkpoint. Or in Flink, when calling the `StreamExecutionEnvironment.enableCheckpointing()`, the `execution.checkpointing.interval` should be set with value of the interval for `enableCheckpointing()`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink-kubernetes-operator] wangyang0918 commented on pull request #139: [FLINK-26893] Validate checkpoint config with last-state upgrade mode

Posted by GitBox <gi...@apache.org>.
wangyang0918 commented on pull request #139:
URL: https://github.com/apache/flink-kubernetes-operator/pull/139#issuecomment-1085372261


   I believe many jobs are enabling the checkpoint via `StreamExecutionEnvironment.enableCheckpointing()`. This strict check will not work for them.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink-kubernetes-operator] gyfora commented on pull request #139: [FLINK-26893] Validate checkpoint config with last-state upgrade mode

Posted by GitBox <gi...@apache.org>.
gyfora commented on pull request #139:
URL: https://github.com/apache/flink-kubernetes-operator/pull/139#issuecomment-1086605175


   @wangyang0918 I would probably go for a more conservative 5 or 10 minute interval maybe 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink-kubernetes-operator] wangyang0918 commented on pull request #139: [FLINK-26893] Validate checkpoint config with last-state upgrade mode

Posted by GitBox <gi...@apache.org>.
wangyang0918 commented on pull request #139:
URL: https://github.com/apache/flink-kubernetes-operator/pull/139#issuecomment-1085605936


   > for the jobs that enable the checkpoint via StreamExecutionEnvironment.enableCheckpointing(), we could guide the user to use the configuration method to open checkpoint.
   
   This will not work for session clusters since each job has different checkpoint interval.
   
   
   >  in Flink, when calling the StreamExecutionEnvironment.enableCheckpointing(), the execution.checkpointing.interval should be set with value of the interval for enableCheckpointing().
   
   This is impossible to set the value to flink config in the CR.
   
   
   What I am thinking is to add a default value for `execution.checkpointing.interval` when HA enabled. It could be overridden by user specified CR or `StreamExecutionEnvironment.enableCheckpointing()`. Then we do not force users should set it explicitly in the CR.
   
   @SteNicholas @gyfora WDYT?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink-kubernetes-operator] SteNicholas edited a comment on pull request #139: [FLINK-26893] Validate checkpoint config with last-state upgrade mode

Posted by GitBox <gi...@apache.org>.
SteNicholas edited a comment on pull request #139:
URL: https://github.com/apache/flink-kubernetes-operator/pull/139#issuecomment-1085628099


   > What I am thinking is to add a default value for `execution.checkpointing.interval` when HA enabled. It could be overridden by user specified CR or StreamExecutionEnvironment.enableCheckpointing(). Then we do not force users should set it explicitly in the CR.
   
   @wangyang0918, if this adds a default value for `execution.checkpointing.interval` when HA enabled, what's the default value for `execution.checkpointing.interval`? The value isn' easily determined here.
   @gyfora, WDYT?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink-kubernetes-operator] wangyang0918 commented on pull request #139: [FLINK-26893] Validate checkpoint config with last-state upgrade mode

Posted by GitBox <gi...@apache.org>.
wangyang0918 commented on pull request #139:
URL: https://github.com/apache/flink-kubernetes-operator/pull/139#issuecomment-1086600640


   @gyfora Does it make sense to you that adding a default value(maybe 120s) for `execution.checkpointing.interval` when last-state upgrade mode is used. It could be overridden by users via explicit config options or programmatically.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink-kubernetes-operator] SteNicholas commented on pull request #139: [FLINK-26893] Validate checkpoint config with last-state upgrade mode

Posted by GitBox <gi...@apache.org>.
SteNicholas commented on pull request #139:
URL: https://github.com/apache/flink-kubernetes-operator/pull/139#issuecomment-1086608996


   > > I would probably go for a more conservative 5 or 10 minute interval maybe
   > 
   > Make sense. @SteNicholas Would you like to update this PR accordingly?
   
   @wangyang0918, I'm updating this PR according to above suggestion.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink-kubernetes-operator] gyfora commented on a change in pull request #139: [FLINK-26893] Validate checkpoint config with last-state upgrade mode

Posted by GitBox <gi...@apache.org>.
gyfora commented on a change in pull request #139:
URL: https://github.com/apache/flink-kubernetes-operator/pull/139#discussion_r841082985



##########
File path: flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/controller/FlinkDeploymentController.java
##########
@@ -114,6 +115,10 @@ public DeleteControl cleanup(FlinkDeployment flinkApp, Context context) {
                 ReconciliationUtils.updateForReconciliationError(flinkApp, validationError.get());
                 return ReconciliationUtils.toUpdateControl(
                         operatorConfiguration, originalCopy, flinkApp, false);
+            } else if (flinkApp.getSpec()
+                    .getFlinkConfiguration()
+                    .containsKey(ExecutionCheckpointingOptions.CHECKPOINTING_INTERVAL.key())) {
+                FlinkUtils.setCheckpointingInterval(originalCopy.getSpec().getFlinkConfiguration());

Review comment:
       We should simply add this logic to the FlinkConfigBuilder instead of modifying the spec 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink-kubernetes-operator] gyfora merged pull request #139: [FLINK-26893] Validate checkpoint config with last-state upgrade mode

Posted by GitBox <gi...@apache.org>.
gyfora merged pull request #139:
URL: https://github.com/apache/flink-kubernetes-operator/pull/139


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink-kubernetes-operator] SteNicholas commented on pull request #139: [FLINK-26893] Validate checkpoint config with last-state upgrade mode

Posted by GitBox <gi...@apache.org>.
SteNicholas commented on pull request #139:
URL: https://github.com/apache/flink-kubernetes-operator/pull/139#issuecomment-1085628099


   > What I am thinking is to add a default value for `execution.checkpointing.interval` when HA enabled. It could be overridden by user specified CR or StreamExecutionEnvironment.enableCheckpointing(). Then we do not force users should set it explicitly in the CR.
   
   @wangyang0918, this makes sense to me. I will update the implementation to add a default value for `execution.checkpointing.interval` when HA enabled. But what's the recommend default value for `execution.checkpointing.interval`?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink-kubernetes-operator] gyfora commented on pull request #139: [FLINK-26893] Validate checkpoint config with last-state upgrade mode

Posted by GitBox <gi...@apache.org>.
gyfora commented on pull request #139:
URL: https://github.com/apache/flink-kubernetes-operator/pull/139#issuecomment-1085424318


   @wangyang0918 that's true unfortunately


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink-kubernetes-operator] gyfora commented on a change in pull request #139: [FLINK-26893] Validate checkpoint config with last-state upgrade mode

Posted by GitBox <gi...@apache.org>.
gyfora commented on a change in pull request #139:
URL: https://github.com/apache/flink-kubernetes-operator/pull/139#discussion_r841166010



##########
File path: flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/utils/FlinkConfigBuilder.java
##########
@@ -94,6 +97,16 @@ public FlinkConfigBuilder applyFlinkConfiguration() {
                     REST_SERVICE_EXPOSED_TYPE,
                     KubernetesConfigOptions.ServiceExposedType.ClusterIP);
         }
+
+        // With last-state upgrade mode, set the default value of 'execution.checkpointing.interval'
+        // to 5 minutes when HA is enabled.
+        if (spec.getJob() != null
+                && spec.getJob().getUpgradeMode() == UpgradeMode.LAST_STATE
+                && !effectiveConfig.contains(
+                        ExecutionCheckpointingOptions.CHECKPOINTING_INTERVAL)) {
+            effectiveConfig.set(
+                    ExecutionCheckpointingOptions.CHECKPOINTING_INTERVAL, Duration.ofMinutes(5));

Review comment:
       Let's move the 5 minutes into a constant in FlinkConfigBuilder and I think we are good to go :) 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink-kubernetes-operator] SteNicholas commented on a change in pull request #139: [FLINK-26893] Validate checkpoint config with last-state upgrade mode

Posted by GitBox <gi...@apache.org>.
SteNicholas commented on a change in pull request #139:
URL: https://github.com/apache/flink-kubernetes-operator/pull/139#discussion_r840323877



##########
File path: flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/validation/DefaultDeploymentValidator.java
##########
@@ -145,10 +146,29 @@
         }
 
         Configuration configuration = Configuration.fromMap(confMap);
-        if (job.getUpgradeMode() == UpgradeMode.LAST_STATE
-                && !FlinkUtils.isKubernetesHAActivated(configuration)) {
-            return Optional.of(
-                    "Job could not be upgraded with last-state while Kubernetes HA disabled");
+        if (job.getUpgradeMode() == UpgradeMode.LAST_STATE) {
+            if (!FlinkUtils.isKubernetesHAActivated(configuration)) {
+                return Optional.of(
+                        "Job could not be upgraded with last-state while Kubernetes HA disabled");
+            } else if (!configuration.containsKey(
+                            ExecutionCheckpointingOptions.CHECKPOINTING_INTERVAL.key())
+                    || configuration
+                                    .get(ExecutionCheckpointingOptions.CHECKPOINTING_INTERVAL)
+                                    .compareTo(
+                                            configuration.get(
+                                                    ExecutionCheckpointingOptions
+                                                            .MIN_PAUSE_BETWEEN_CHECKPOINTS))

Review comment:
       @gyfora, this check refers to the logic in `CheckpointConfig#setCheckpointInterval` which compares to the `MINIMAL_CHECKPOINT_TIME`, therefore this check is necessary.
   @wangyang0918 WDYT?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink-kubernetes-operator] SteNicholas edited a comment on pull request #139: [FLINK-26893] Validate checkpoint config with last-state upgrade mode

Posted by GitBox <gi...@apache.org>.
SteNicholas edited a comment on pull request #139:
URL: https://github.com/apache/flink-kubernetes-operator/pull/139#issuecomment-1085547523


   @wangyang0918 @gyfora , for the jobs that enable the checkpoint via `StreamExecutionEnvironment.enableCheckpointing()`, we could guide the user to use the configuration method to open checkpoint. Or in Flink, when calling the `StreamExecutionEnvironment.enableCheckpointing()`, the `execution.checkpointing.interval` should be set with value of the interval for `enableCheckpointing()`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink-kubernetes-operator] gyfora commented on a change in pull request #139: [FLINK-26893] Validate checkpoint config with last-state upgrade mode

Posted by GitBox <gi...@apache.org>.
gyfora commented on a change in pull request #139:
URL: https://github.com/apache/flink-kubernetes-operator/pull/139#discussion_r839952791



##########
File path: flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/validation/DefaultDeploymentValidator.java
##########
@@ -145,10 +146,29 @@
         }
 
         Configuration configuration = Configuration.fromMap(confMap);
-        if (job.getUpgradeMode() == UpgradeMode.LAST_STATE
-                && !FlinkUtils.isKubernetesHAActivated(configuration)) {
-            return Optional.of(
-                    "Job could not be upgraded with last-state while Kubernetes HA disabled");
+        if (job.getUpgradeMode() == UpgradeMode.LAST_STATE) {
+            if (!FlinkUtils.isKubernetesHAActivated(configuration)) {
+                return Optional.of(
+                        "Job could not be upgraded with last-state while Kubernetes HA disabled");
+            } else if (!configuration.containsKey(
+                            ExecutionCheckpointingOptions.CHECKPOINTING_INTERVAL.key())
+                    || configuration
+                                    .get(ExecutionCheckpointingOptions.CHECKPOINTING_INTERVAL)
+                                    .compareTo(
+                                            configuration.get(
+                                                    ExecutionCheckpointingOptions
+                                                            .MIN_PAUSE_BETWEEN_CHECKPOINTS))

Review comment:
       I dont really understant the point of this check. Is this necessary?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink-kubernetes-operator] SteNicholas commented on pull request #139: [FLINK-26893] Validate checkpoint config with last-state upgrade mode

Posted by GitBox <gi...@apache.org>.
SteNicholas commented on pull request #139:
URL: https://github.com/apache/flink-kubernetes-operator/pull/139#issuecomment-1086776176


   @gyfora, thanks for your review. I have addressed your comments for `FlinkConfigBuilder`. Please help to take a look.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink-kubernetes-operator] SteNicholas commented on a change in pull request #139: [FLINK-26893] Validate checkpoint config with last-state upgrade mode

Posted by GitBox <gi...@apache.org>.
SteNicholas commented on a change in pull request #139:
URL: https://github.com/apache/flink-kubernetes-operator/pull/139#discussion_r840323877



##########
File path: flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/validation/DefaultDeploymentValidator.java
##########
@@ -145,10 +146,29 @@
         }
 
         Configuration configuration = Configuration.fromMap(confMap);
-        if (job.getUpgradeMode() == UpgradeMode.LAST_STATE
-                && !FlinkUtils.isKubernetesHAActivated(configuration)) {
-            return Optional.of(
-                    "Job could not be upgraded with last-state while Kubernetes HA disabled");
+        if (job.getUpgradeMode() == UpgradeMode.LAST_STATE) {
+            if (!FlinkUtils.isKubernetesHAActivated(configuration)) {
+                return Optional.of(
+                        "Job could not be upgraded with last-state while Kubernetes HA disabled");
+            } else if (!configuration.containsKey(
+                            ExecutionCheckpointingOptions.CHECKPOINTING_INTERVAL.key())
+                    || configuration
+                                    .get(ExecutionCheckpointingOptions.CHECKPOINTING_INTERVAL)
+                                    .compareTo(
+                                            configuration.get(
+                                                    ExecutionCheckpointingOptions
+                                                            .MIN_PAUSE_BETWEEN_CHECKPOINTS))

Review comment:
       @gyfora, this check refers to `CheckpointConfig#setCheckpointInterval` and is necessary. @wangyang0918 WDYT?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink-kubernetes-operator] wangyang0918 commented on pull request #139: [FLINK-26893] Validate checkpoint config with last-state upgrade mode

Posted by GitBox <gi...@apache.org>.
wangyang0918 commented on pull request #139:
URL: https://github.com/apache/flink-kubernetes-operator/pull/139#issuecomment-1086608902


   > I would probably go for a more conservative 5 or 10 minute interval maybe
   
   Make sense. @SteNicholas Would you like to update this PR accordingly?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink-kubernetes-operator] SteNicholas commented on pull request #139: [FLINK-26893] Validate checkpoint config with last-state upgrade mode

Posted by GitBox <gi...@apache.org>.
SteNicholas commented on pull request #139:
URL: https://github.com/apache/flink-kubernetes-operator/pull/139#issuecomment-1084016537


   @wangyang0918 @gyfora, could you help to review?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org