You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@libcloud.apache.org by fjros <gi...@git.apache.org> on 2017/04/24 17:26:56 UTC

[GitHub] libcloud pull request #1044: Additional fields in extra dict of Vultr sizes

GitHub user fjros opened a pull request:

    https://github.com/apache/libcloud/pull/1044

    Additional fields in extra dict of Vultr sizes

    ## Extend extra dict of Vultr sizes to include additional fields
    
    ### Description
    
    The Vultr API returns useful information such as the type of a given node size (e.g. 'SSD', 'SATA' and 'DEDICATED') and the list of locations where it is available. This PR exposes the `plan_type` and `available_locations` fields by means of the `extra` dict of the `NodeSize` class.
    
    ### Status
    
    - done, ready for review
    
    ### Checklist (tick everything that applies)
    
    - [ ] [Code linting](http://libcloud.readthedocs.org/en/latest/development.html#code-style-guide) (required, can be done after the PR checks)
    - [ ] Documentation
    - [ ] [Tests](http://libcloud.readthedocs.org/en/latest/testing.html)
    - [ ] [ICLA](http://libcloud.readthedocs.org/en/latest/development.html#contributing-bigger-changes) (required for bigger changes)

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/fjros/libcloud extra-vultr-size-params

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/libcloud/pull/1044.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1044
    
----
commit 7adbdd8fdfb0347d30075c35c4bcc0d6475649e2
Author: Francisco Ros <fj...@doalitic.com>
Date:   2017-04-24T17:11:07Z

    Additional fields in extra dict of Vultr sizes

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] libcloud pull request #1044: Additional fields in extra dict of Vultr sizes

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/libcloud/pull/1044


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---