You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2021/12/09 16:56:14 UTC

[GitHub] [geode] jdeppe-pivotal opened a new pull request #7180: GEODE-9877: Use ServerSocket to create interfering port

jdeppe-pivotal opened a new pull request #7180:
URL: https://github.com/apache/geode/pull/7180


   - For some unknown reason `startupFailsGivenPortAlreadyInUse` started to
     fail after a seemingly innocuous Ubuntu base image bump. The problem
     may also have been triggered by arbitrary test ordering changes since
     the test did not fail on its own, but only in conjunction with running
     other tests beforehand.
     Specifically, the test was failing when binding the interfering port
     (bind exception). The port used was always in the TIME_WAIT state left
     from previous tests.
     Using a `ServerSocket`, instead of a regular socket, fixes the problem
     since it actually 'uses' the port and implicitly allows for port
     reuse.
   
   <!-- Thank you for submitting a contribution to Apache Geode. -->
   
   <!-- In order to streamline the review of the contribution we ask you
   to ensure the following steps have been taken: 
   -->
   
   ### For all changes:
   - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
   
   - [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
   
   - [ ] Is your initial contribution a single, squashed commit?
   
   - [ ] Does `gradlew build` run cleanly?
   
   - [ ] Have you written or updated unit tests to verify your changes?
   
   - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
   
   <!-- Note:
   Please ensure that once the PR is submitted, check Concourse for build issues and
   submit an update to your PR as soon as possible. If you need help, please send an
   email to dev@geode.apache.org.
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [geode] jdeppe-pivotal merged pull request #7180: GEODE-9877: Use ServerSocket to create interfering port

Posted by GitBox <gi...@apache.org>.
jdeppe-pivotal merged pull request #7180:
URL: https://github.com/apache/geode/pull/7180


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org