You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/02/07 08:28:22 UTC
[GitHub] [spark] LuciferYang opened a new pull request #35418: [SPARK-38127][SQL][TESTS] Fix bug of `EnumTypeSetBenchmark` and update benchmark result
LuciferYang opened a new pull request #35418:
URL: https://github.com/apache/spark/pull/35418
### What changes were proposed in this pull request?
The iteration times of the comparison case in the `EnumTypeSetBenchmark` is not sameļ¼this pr fix this bug and update benchmark result.
### Why are the changes needed?
Bug fix.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Pass GA
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #35418: [SPARK-38127][SQL][TESTS] Fix bug of `EnumTypeSetBenchmark` and update benchmark result
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on pull request #35418:
URL: https://github.com/apache/spark/pull/35418#issuecomment-1032159064
> Is the idea simply that the benchmark was run on substantially different hardware before?
No, this pr focuses on bug fix, for example `testContainsOperation`:
https://github.com/apache/spark/blob/9d0563733bacc39ffbb7a07e5d3fc6de71d0cfb3/sql/catalyst/src/test/scala/org/apache/spark/sql/connector/catalog/EnumTypeSetBenchmark.scala#L102-L110
`Use HashSet` circulates 100000 times(`valuesPerIteration `is 100000) and `Use EnumSet` circulates only once.
It's my bad, I made a mistake in writing this case before.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #35418: [SPARK-38127][SQL][TESTS] Fix bug of `EnumTypeSetBenchmark` and update benchmark result
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on pull request #35418:
URL: https://github.com/apache/spark/pull/35418#issuecomment-1032223761
Thanks all
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on pull request #35418: [SPARK-38127][SQL][TESTS] Fix bug of `EnumTypeSetBenchmark` and update benchmark result
Posted by GitBox <gi...@apache.org>.
srowen commented on pull request #35418:
URL: https://github.com/apache/spark/pull/35418#issuecomment-1031479860
Is the idea simply that the benchmark was run on substantially different hardware before?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #35418: [SPARK-38127][SQL][TESTS] Fix bug of `EnumTypeSetBenchmark` and update benchmark result
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on pull request #35418:
URL: https://github.com/apache/spark/pull/35418#issuecomment-1031201788
cc @srowen
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun closed pull request #35418: [SPARK-38127][SQL][TESTS] Fix bug of `EnumTypeSetBenchmark` and update benchmark result
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun closed pull request #35418:
URL: https://github.com/apache/spark/pull/35418
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org