[GitHub] [ignite] Vladsz83 commented on issue #7446: IGNITE-12464 : Service metrics

[GitBox <gi...@apache.org>]

Vladsz83 commented on issue #7446: IGNITE-12464 : Service metrics
URL: https://github.com/apache/ignite/pull/7446#issuecomment-607779282
 
 
   > Also, I suppose, that we should leave to user the final conclusion to instrument methods of
   > his or her service or not. I would suggest to add a bit of API for users, 
   
   Ok, many people propose to give user the decision to enable/disable service metrics. Makes sense. My + is for Andrey Gura’s suggestion ( http://apache-ignite-developers.2346864.n4.nabble.com/Reference-of-local-service-tp46071p46307.html ) :
   “we should provide a way for configuring service metrics (in
   sense of enabled/disabled) during service deploy. It's easy for cases
   where deploy() methods have ServiceConfiguration as parameter.”
   
   The reasons:
   -	It is quite obvious. Good place without any other condition.
   -	CacheConfiguration has same property. Analogous approach simplifies product for user.
   -	Might work with some global “metrics_enable
   
   So, I’ve introduced ServiceConfiguration.isStatisticsEnabled and the supporting methods.
   
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services