[GitHub] [pinot] Jackie-Jiang commented on pull request #10862: bugfix: fix #10861: Handle RETAINING state of PartitionConsumer to fix SIGSEGV

["Jackie-Jiang (via GitHub)" <gi...@apache.org>]

Jackie-Jiang commented on PR #10862:
URL: https://github.com/apache/pinot/pull/10862#issuecomment-1581327184

   Good findings!
   IMO we should find the reason why `stop()` doesn't stop the consumption properly, and throw exception when the thread cannot be stopped. Essentially `stop()` should guarantee the consumption is stopped before returning


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org