You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2022/07/15 09:30:58 UTC
[GitHub] [nifi] mathemare opened a new pull request, #6211: NIFI-10236: ByteArrayContentRepository in core framework
mathemare opened a new pull request, #6211:
URL: https://github.com/apache/nifi/pull/6211
New ByteArrayContentRepository for the nifi-framework-core
- added implementation of the ByteArray ContentClaim / ResourceClaim
- added an (useful ?) interface for the StandardContentClaimWriteCache not to only take into account StandardContentClaim but CachableContentClaim that is implemented by the ByteArrayContentClaim
- added tests from the VolatileContentRepository
Signed-off-by: mathemare <ma...@hotmail.fr>
<!-- Licensed to the Apache Software Foundation (ASF) under one or more -->
<!-- contributor license agreements. See the NOTICE file distributed with -->
<!-- this work for additional information regarding copyright ownership. -->
<!-- The ASF licenses this file to You under the Apache License, Version 2.0 -->
<!-- (the "License"); you may not use this file except in compliance with -->
<!-- the License. You may obtain a copy of the License at -->
<!-- http://www.apache.org/licenses/LICENSE-2.0 -->
<!-- Unless required by applicable law or agreed to in writing, software -->
<!-- distributed under the License is distributed on an "AS IS" BASIS, -->
<!-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. -->
<!-- See the License for the specific language governing permissions and -->
<!-- limitations under the License. -->
# Summary
[NIFI-00000](https://issues.apache.org/jira/browse/NIFI-00000)
# Tracking
Please complete the following tracking steps prior to pull request creation.
### Issue Tracking
- [ ] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created
### Pull Request Tracking
- [ ] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-00000`
- [ ] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-00000`
### Pull Request Formatting
- [ ] Pull Request based on current revision of the `main` branch
- [ ] Pull Request refers to a feature branch with one commit containing changes
# Verification
Please indicate the verification steps performed prior to pull request creation.
### Build
- [ ] Build completed using `mvn clean install -P contrib-check`
- [ ] JDK 8
- [ ] JDK 11
- [ ] JDK 17
### Licensing
- [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html)
- [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files
### Documentation
- [ ] Documentation formatting appears as expected in rendered files
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] mathemare commented on pull request #6211: NIFI-10236: ByteArrayContentRepository in core framework
Posted by GitBox <gi...@apache.org>.
mathemare commented on PR #6211:
URL: https://github.com/apache/nifi/pull/6211#issuecomment-1187439117
Indeed, thank you @exceptionfactory ! I'm working on it, I will propose a new pull request after that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] exceptionfactory commented on pull request #6211: NIFI-10236: ByteArrayContentRepository in core framework
Posted by GitBox <gi...@apache.org>.
exceptionfactory commented on PR #6211:
URL: https://github.com/apache/nifi/pull/6211#issuecomment-1187412030
@mathemare, based on the discussion in associated Jira issue, the approach needs to be re-evaluated to avoid duplication and ensure a consistent approach. With that background, it would probably be better to start with a new pull request.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] mathemare commented on pull request #6211: NIFI-10236: ByteArrayContentRepository in core framework
Posted by GitBox <gi...@apache.org>.
mathemare commented on PR #6211:
URL: https://github.com/apache/nifi/pull/6211#issuecomment-1185570613
Hello, I found a bug when restarting NiFi, flowfile counts in queues are not cleared while flowfiles are removed from ContentRepo, I'll investigate where the removal is not done
Any example of how to build unit tests around this is really welcome!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] mathemare closed pull request #6211: NIFI-10236: ByteArrayContentRepository in core framework
Posted by GitBox <gi...@apache.org>.
mathemare closed pull request #6211: NIFI-10236: ByteArrayContentRepository in core framework
URL: https://github.com/apache/nifi/pull/6211
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org