[GitHub] [beam] Abacn commented on a diff in pull request #25246: Added Role-based access control integration tests for Spanner Change …

["Abacn (via GitHub)" <gi...@apache.org>]

Abacn commented on code in PR #25246:
URL: https://github.com/apache/beam/pull/25246#discussion_r1095874874


##########
sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/spanner/changestreams/it/SpannerChangeStreamIT.java:
##########
@@ -93,6 +101,22 @@ public void before() {
 
   @Test
   public void testReadSpannerChangeStream() {
+    testReadSpannerChangeStreamImpl(pipeline, null);
+  }
+
+  @Test
+  public void testReadSpannerChangeStreamWithAuthorizedRole() {
+    testReadSpannerChangeStreamImpl(pipeline, ENV.getDatabaseRole());
+  }
+
+  @Test
+  public void testReadSpannerChangeStreamWithUnauthorizedRole() {
+    exception.expect(SpannerException.class);

Review Comment:
   the added tests will be executed on both direct runner precommit and dataflow postcommit:
   
   https://ci-beam.apache.org/view/PostCommit/job/beam_PreCommit_Java_GCP_IO_Direct_Cron
   
   https://ci-beam.apache.org/view/PostCommit/job/beam_PostCommit_Java_DataflowV2
   
   For the latter the exception would not thrown. If remote pipeline fails the PipelineResult is set to FAIL.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org