[GitHub] [kafka] YiDing-Duke commented on a diff in pull request #13391: KAFKA-14561: Improve transactions experience for older clients by ensuring ongoing transaction

["YiDing-Duke (via GitHub)" <gi...@apache.org>]

YiDing-Duke commented on code in PR #13391:
URL: https://github.com/apache/kafka/pull/13391#discussion_r1146789680


##########
core/src/main/scala/kafka/server/AddPartitionsToTxnManager.scala:
##########
@@ -0,0 +1,173 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *    http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package kafka.server
+
+import kafka.common.{InterBrokerSendThread, RequestAndCompletionHandler}
+import org.apache.kafka.clients.{ClientResponse, NetworkClient, RequestCompletionHandler}
+import org.apache.kafka.common.{InvalidRecordException, Node, TopicPartition}
+import org.apache.kafka.common.message.AddPartitionsToTxnRequestData.{AddPartitionsToTxnTransaction, AddPartitionsToTxnTransactionCollection}
+import org.apache.kafka.common.protocol.Errors
+import org.apache.kafka.common.requests.{AddPartitionsToTxnRequest, AddPartitionsToTxnResponse}
+import org.apache.kafka.common.utils.Time
+
+import java.util.Collections
+import scala.collection.mutable
+
+object AddPartitionsToTxnManager {
+  type AppendCallback = Map[TopicPartition, Errors] => Unit
+}
+
+
+class TransactionDataAndCallbacks(val transactionData: AddPartitionsToTxnTransactionCollection,
+                                  val callbacks: mutable.Map[String, AddPartitionsToTxnManager.AppendCallback])
+
+
+class AddPartitionsToTxnManager(config: KafkaConfig, client: NetworkClient, time: Time) 
+  extends InterBrokerSendThread("AddPartitionsToTxnSenderThread-" + config.brokerId, client, config.requestTimeoutMs, time) {
+  
+  private val inflightNodes = mutable.HashSet[Node]()
+  private val nodesToTransactions = mutable.Map[Node, TransactionDataAndCallbacks]()
+  
+  def addTxnData(node: Node, transactionData: AddPartitionsToTxnTransaction, callback: AddPartitionsToTxnManager.AppendCallback): Unit = {
+    // Check if we have already (either node or individual transaction). 
+    val currentNodeAndTransactionDataOpt = nodesToTransactions.get(node)
+    currentNodeAndTransactionDataOpt match {
+      case None =>
+        nodesToTransactions.put(node,
+          new TransactionDataAndCallbacks(new AddPartitionsToTxnTransactionCollection(Collections.singletonList(transactionData).iterator()),
+            mutable.Map(transactionData.transactionalId() -> callback)))
+      case Some(currentNodeAndTransactionData) =>
+        // Check if we already have txn ID -- this should only happen in epoch bump case. If so, we should return error for old entry and remove from queue.
+        val currentTransactionData = currentNodeAndTransactionData.transactionData.find(transactionData.transactionalId)
+        if (currentTransactionData != null) {
+          if (currentTransactionData.producerEpoch() < transactionData.producerEpoch()) {
+            val topicPartitionsToError = mutable.Map[TopicPartition, Errors]()
+            currentTransactionData.topics().forEach { topic => 
+              topic.partitions().forEach { partition =>
+                topicPartitionsToError.put(new TopicPartition(topic.name(), partition), Errors.INVALID_PRODUCER_EPOCH)
+              }
+            }
+            val oldCallback = currentNodeAndTransactionData.callbacks(transactionData.transactionalId())
+            currentNodeAndTransactionData.transactionData.remove(transactionData)
+            oldCallback(topicPartitionsToError.toMap)
+          } else {
+            // We should never see a request on the same epoch since we haven't finished handling the one in queue

Review Comment:
   if 1st request timeout, the second one cannot hit this stage unless 1st one is done due to connection muted?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org