[jira] [Commented] (KAFKA-1035) Add message-send-max-retries and retry-backoff-ms options to console producer

["Guozhang Wang (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KAFKA-1035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13754254#comment-13754254 ] 

Guozhang Wang commented on KAFKA-1035:
--------------------------------------

Thanks for the patch. One minor comment:

Could you modify the description of message-send-max-retries:

"The leader may be unavailable transiently, which can fail the sending of a message. This property specifies the number of retries when such failures occur"?

1. Brokers can fail receiving the message for multiple reasons, and being unavailable transiently is just one of them.
2. This properties specifies the number of retires before the producer give up and drop this message.
                
> Add message-send-max-retries and retry-backoff-ms options to console producer
> -----------------------------------------------------------------------------
>
>                 Key: KAFKA-1035
>                 URL: https://issues.apache.org/jira/browse/KAFKA-1035
>             Project: Kafka
>          Issue Type: Bug
>          Components: producer 
>    Affects Versions: 0.7, 0.8
>            Reporter: Rajasekar Elango
>            Assignee: Jun Rao
>              Labels: patch
>             Fix For: 0.8
>
>         Attachments: console_producer_add_options.patch
>
>
> It's possible for console producer to give up too soon if it can't find a leader of a topic. Increasing message-send-max-retries would resolve this but.  Console producer doesn't provide options to set message-send-max-retries and retry-backoff-ms. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira