You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bookkeeper.apache.org by "Ivan Kelly (JIRA)" <ji...@apache.org> on 2012/11/27 12:05:59 UTC
[jira] [Created] (BOOKKEEPER-480) Fix javac warnings
Ivan Kelly created BOOKKEEPER-480:
-------------------------------------
Summary: Fix javac warnings
Key: BOOKKEEPER-480
URL: https://issues.apache.org/jira/browse/BOOKKEEPER-480
Project: Bookkeeper
Issue Type: Bug
Reporter: Ivan Kelly
Assignee: Ivan Kelly
Fix For: 4.2.0
Precommit is reporting javac warnings.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-480) Fix javac warnings
Posted by "Sijie Guo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13507074#comment-13507074 ]
Sijie Guo commented on BOOKKEEPER-480:
--------------------------------------
the patch looks good to me. +1
> Fix javac warnings
> ------------------
>
> Key: BOOKKEEPER-480
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-480
> Project: Bookkeeper
> Issue Type: Bug
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Fix For: 4.2.0
>
> Attachments: 0003-BOOKKEEPER-480-Find-pom.xml-warnings.patch
>
>
> Precommit is reporting javac warnings.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (BOOKKEEPER-480) Fix javac warnings
Posted by "Ivan Kelly (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-480?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ivan Kelly updated BOOKKEEPER-480:
----------------------------------
Attachment: 0003-BOOKKEEPER-480-Find-pom.xml-warnings.patch
Problem was actually in pom.xml and not in the java code at all. The precommit looks for [WARNING] in the mvn output.
> Fix javac warnings
> ------------------
>
> Key: BOOKKEEPER-480
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-480
> Project: Bookkeeper
> Issue Type: Bug
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Fix For: 4.2.0
>
> Attachments: 0003-BOOKKEEPER-480-Find-pom.xml-warnings.patch
>
>
> Precommit is reporting javac warnings.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-480) Fix javac warnings
Posted by "Sijie Guo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13507076#comment-13507076 ]
Sijie Guo commented on BOOKKEEPER-480:
--------------------------------------
committed as r1415492. thanks Ivan.
> Fix javac warnings
> ------------------
>
> Key: BOOKKEEPER-480
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-480
> Project: Bookkeeper
> Issue Type: Bug
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Fix For: 4.2.0
>
> Attachments: 0003-BOOKKEEPER-480-Find-pom.xml-warnings.patch
>
>
> Precommit is reporting javac warnings.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-480) Fix javac warnings
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13504649#comment-13504649 ]
Hadoop QA commented on BOOKKEEPER-480:
--------------------------------------
Testing JIRA BOOKKEEPER-480
WARNING: Running test-patch on a dirty local svn workspace
Patch <a href="/jira/secure/attachment/12554995/0003-BOOKKEEPER-480-Find-pom.xml-warnings.patch">/jira/secure/attachment/12554995/0003-BOOKKEEPER-480-Find-pom.xml-warnings.patch</a> downloaded at Tue Nov 27 14:25:25 UTC 2012
----------------------------
{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:red}-1 RAW_PATCH_ANALYSIS{color}
. {color:green}+1{color} the patch does not introduce any @author tags
. {color:green}+1{color} the patch does not introduce any tabs
. {color:green}+1{color} the patch does not introduce any trailing spaces
. {color:green}+1{color} the patch does not introduce any line longer than 120
. {color:red}-1{color} the patch does not add/modify any testcase
{color:green}+1 RAT{color}
. {color:green}+1{color} the patch does not seem to introduce new RAT warnings
{color:green}+1 JAVADOC{color}
. {color:green}+1{color} the patch does not seem to introduce new Javadoc warnings
. {color:red}WARNING{color}: the current HEAD has 8 Javadoc warning(s)
{color:green}+1 COMPILE{color}
. {color:green}+1{color} HEAD compiles
. {color:green}+1{color} patch compiles
. {color:green}+1{color} the patch does not seem to introduce new javac warnings
. {color:red}WARNING{color}: the current HEAD has 9 javac warning(s)
{color:green}+1 FINDBUGS{color}
. {color:green}+1{color} the patch does not seem to introduce new Findbugs warnings
. {color:red}WARNING: the current HEAD has Findbugs warning(s), they should be addressed ASAP{color}
{color:green}+1 TESTS{color}
. Tests run: 389
{color:green}+1 DISTRO{color}
. {color:green}+1{color} distro tarball builds with the patch
----------------------------
{color:red}*-1 Overall result, please check the reported -1(s)*{color}
{color:red}. There is at least one warning, please check{color}
The full output of the test-patch run is available at
. https://builds.apache.org/job/bookkeeper-trunk-precommit-build/40/
> Fix javac warnings
> ------------------
>
> Key: BOOKKEEPER-480
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-480
> Project: Bookkeeper
> Issue Type: Bug
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Fix For: 4.2.0
>
> Attachments: 0003-BOOKKEEPER-480-Find-pom.xml-warnings.patch
>
>
> Precommit is reporting javac warnings.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-480) Fix javac warnings
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13507085#comment-13507085 ]
Hudson commented on BOOKKEEPER-480:
-----------------------------------
Integrated in bookkeeper-trunk #829 (See [https://builds.apache.org/job/bookkeeper-trunk/829/])
BOOKKEEPER-480: Fix javac warnings (ivank via sijie) (Revision 1415492)
Result = FAILURE
sijie :
Files :
* /zookeeper/bookkeeper/trunk/bookkeeper-server/pom.xml
* /zookeeper/bookkeeper/trunk/hedwig-server/pom.xml
> Fix javac warnings
> ------------------
>
> Key: BOOKKEEPER-480
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-480
> Project: Bookkeeper
> Issue Type: Bug
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Fix For: 4.2.0
>
> Attachments: 0003-BOOKKEEPER-480-Find-pom.xml-warnings.patch
>
>
> Precommit is reporting javac warnings.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira