You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2020/01/21 04:07:28 UTC

[GitHub] [calcite] zhenyu-hou commented on a change in pull request #1772: [CALCITE-3744] Duplicate rule matches when RelSet gets merged

zhenyu-hou commented on a change in pull request #1772: [CALCITE-3744] Duplicate rule matches when RelSet gets merged
URL: https://github.com/apache/calcite/pull/1772#discussion_r368803682
 
 

 ##########
 File path: core/src/main/java/org/apache/calcite/plan/volcano/VolcanoRuleMatch.java
 ##########
 @@ -145,16 +144,16 @@ private String computeDigest() {
       if (i > 0) {
         buf.append(", ");
 
 Review comment:
   as we are changing how the digest is computed anyway, we can simplify this as buf.append(',');

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services