You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@geaflow.apache.org by "yaozhongq (via GitHub)" <gi...@apache.org> on 2025/07/29 08:54:06 UTC

[PR] refactor: Update filter instantiation method and optimize edge query … [geaflow]

yaozhongq opened a new pull request, #564:
URL: https://github.com/apache/geaflow/pull/564

   #563 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@geaflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@geaflow.apache.org
For additional commands, e-mail: commits-help@geaflow.apache.org


Re: [PR] refactor: Update filter instantiation method and optimize edge query … [geaflow]

Posted by "yaozhongq (via GitHub)" <gi...@apache.org>.
yaozhongq commented on code in PR #564:
URL: https://github.com/apache/geaflow/pull/564#discussion_r2247308589


##########
geaflow/geaflow-core/geaflow-api/src/main/java/org/apache/geaflow/api/graph/function/vc/base/VertexCentricFunction.java:
##########
@@ -94,34 +94,19 @@ interface EdgeQuery<K, EV> {
          */
         List<IEdge<K, EV>> getEdges();
 
-        /**
-         * Returns the both edges iterator.
-         */
-        CloseableIterator<IEdge<K, EV>> getEdgesIterator();
-
         /**
          * Returns the out edges.
          */
         List<IEdge<K, EV>> getOutEdges();

Review Comment:
   @qingwen220 This interface is a very commonly used interface. For compatibility, no adjustments are made.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@geaflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@geaflow.apache.org
For additional commands, e-mail: issues-help@geaflow.apache.org


Re: [PR] refactor: Update filter instantiation method and optimize edge query … [geaflow]

Posted by "qingwen220 (via GitHub)" <gi...@apache.org>.
qingwen220 commented on PR #564:
URL: https://github.com/apache/geaflow/pull/564#issuecomment-3136339235

   One comment:
   1. the pr title is supposed to be a more normal way, such as [ISSUE-xxx]: ABC 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@geaflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@geaflow.apache.org
For additional commands, e-mail: commits-help@geaflow.apache.org


Re: [PR] refactor: Update filter instantiation method and optimize edge query … [geaflow]

Posted by "qingwen220 (via GitHub)" <gi...@apache.org>.
qingwen220 commented on code in PR #564:
URL: https://github.com/apache/geaflow/pull/564#discussion_r2244219738


##########
geaflow/geaflow-core/geaflow-api/src/main/java/org/apache/geaflow/api/graph/function/vc/base/VertexCentricFunction.java:
##########
@@ -94,34 +94,19 @@ interface EdgeQuery<K, EV> {
          */
         List<IEdge<K, EV>> getEdges();
 
-        /**
-         * Returns the both edges iterator.
-         */
-        CloseableIterator<IEdge<K, EV>> getEdgesIterator();
-
         /**
          * Returns the out edges.
          */
         List<IEdge<K, EV>> getOutEdges();

Review Comment:
   I suppose this method requires a filter condition as well.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@geaflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@geaflow.apache.org
For additional commands, e-mail: commits-help@geaflow.apache.org


Re: [PR] refactor: Update filter instantiation method and optimize edge query … [geaflow]

Posted by "yaozhongq (via GitHub)" <gi...@apache.org>.
yaozhongq commented on PR #564:
URL: https://github.com/apache/geaflow/pull/564#issuecomment-3143749228

   > One comment:
   > 
   > 1. the pr title is supposed to be a more normal way, such as [ISSUE-xxx]: ABC
   
   @qingwen220 updated


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@geaflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@geaflow.apache.org
For additional commands, e-mail: issues-help@geaflow.apache.org


Re: [PR] [ISSUE-563] refactor: Update filter instantiation method and optimize edge query … [geaflow]

Posted by "qingwen220 (via GitHub)" <gi...@apache.org>.
qingwen220 commented on PR #564:
URL: https://github.com/apache/geaflow/pull/564#issuecomment-3143753705

   +1


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@geaflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@geaflow.apache.org
For additional commands, e-mail: issues-help@geaflow.apache.org


Re: [PR] [ISSUE-563] refactor: Update filter instantiation method and optimize edge query … [geaflow]

Posted by "yaozhongq (via GitHub)" <gi...@apache.org>.
yaozhongq merged PR #564:
URL: https://github.com/apache/geaflow/pull/564


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@geaflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@geaflow.apache.org
For additional commands, e-mail: issues-help@geaflow.apache.org