You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2019/06/27 02:07:02 UTC

[GitHub] [hbase] jatsakthi commented on a change in pull request #335: HBASE-22624 Should sanity check table configuration when clone snapsh…

jatsakthi commented on a change in pull request #335: HBASE-22624 Should sanity check table configuration when clone snapsh…
URL: https://github.com/apache/hbase/pull/335#discussion_r297950198
 
 

 ##########
 File path: hbase-it/src/test/java/org/apache/hadoop/hbase/IntegrationTestRegionReplicaReplication.java
 ##########
 @@ -94,7 +95,7 @@ public void setConf(Configuration conf) {
       String.format("%s.%s", TEST_NAME, LoadTestTool.OPT_COLUMN_FAMILIES),
       StringUtils.join(",", DEFAULT_COLUMN_FAMILIES));
 
-    conf.setBoolean("hbase.table.sanity.checks", true);
+    conf.setBoolean(TableDescriptorChecker.TABLE_SANITY_CHECKS, true);
 
 Review comment:
   Is this different from other `conf.setBoolean("hbase.table.sanity.checks", true)` which is removed from other tests like TestAvoidCellReferencesIntoShippedBlocks based on the default value of TableDescriptorChecker.TABLE_SANITY_CHECKS?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services