[GitHub] [incubator-iceberg] rdblue commented on issue #830: Support name mapping resolution for parquet

[GitBox <gi...@apache.org>]

rdblue commented on issue #830: Support name mapping resolution for parquet
URL: https://github.com/apache/incubator-iceberg/pull/830#issuecomment-610101141
 
 
   Thanks for working on this, @chenjunjiedada!
   
   A few high-level things that I think need to be fixed:
   * This should not replace the existing fallback that assigns IDs based on position. If the name mapping is configured, that should be used instead. Both are options. Feel free to do this by adding a name mapping to the existing `ParquetSchemaUtil` methods. We can do the fallback choice there.
   * This also needs to update `ParquetSchemaUtil.hasIds` so that any ID causes it to return true, instead of any missing ID. This should be okay since files either have IDs or do not, so it is not a behavior change.
   * As few classes should change as possible. Fallback ID assignment already works with the row group filters, so I don't think that we need to alter them. (Unless I'm missing some test case where it's failing!)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org