You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2021/12/02 19:04:02 UTC

[GitHub] [geode] boglesby opened a new pull request #7159: GEODE-9865: Decrement the count if the connection is unsuccessful

boglesby opened a new pull request #7159:
URL: https://github.com/apache/geode/pull/7159


   <!-- Thank you for submitting a contribution to Apache Geode. -->
   
   <!-- In order to streamline the review of the contribution we ask you
   to ensure the following steps have been taken: 
   -->
   
   ### For all changes:
   - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
   
   - [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
   
   - [ ] Is your initial contribution a single, squashed commit?
   
   - [ ] Does `gradlew build` run cleanly?
   
   - [ ] Have you written or updated unit tests to verify your changes?
   
   - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
   
   <!-- Note:
   Please ensure that once the PR is submitted, check Concourse for build issues and
   submit an update to your PR as soon as possible. If you need help, please send an
   email to dev@geode.apache.org.
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [geode] boglesby commented on a change in pull request #7159: GEODE-9865: Decrement the count if the connection is unsuccessful

Posted by GitBox <gi...@apache.org>.
boglesby commented on a change in pull request #7159:
URL: https://github.com/apache/geode/pull/7159#discussion_r761405567



##########
File path: geode-core/src/main/java/org/apache/geode/cache/client/internal/pooling/ConnectionManagerImpl.java
##########
@@ -211,11 +211,17 @@ private PooledConnection createPooledConnection(ServerLocation serverLocation)
    */
   private PooledConnection forceCreateConnection(ServerLocation serverLocation)
       throws ServerRefusedConnectionException, ServerOperationException {
+    PooledConnection connection = null;
     connectionAccounting.create();
     try {
-      return createPooledConnection(serverLocation);
+      connection = createPooledConnection(serverLocation);
+      return connection;

Review comment:
       My original fix had the create in a finally if the connection was successfully created. During our meeting regarding this issue yesterday, it came up that this changed the behavior of the original code which was:
   
    1. increment the count before the connection is created
    2. create the connection
   
   So, I changed the fix to do exactly what it used to do with the addition of the finally block to undo the increment if the connection failed.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [geode] boglesby merged pull request #7159: GEODE-9865: Decrement the count if the connection is unsuccessful

Posted by GitBox <gi...@apache.org>.
boglesby merged pull request #7159:
URL: https://github.com/apache/geode/pull/7159


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [geode] jinmeiliao commented on a change in pull request #7159: GEODE-9865: Decrement the count if the connection is unsuccessful

Posted by GitBox <gi...@apache.org>.
jinmeiliao commented on a change in pull request #7159:
URL: https://github.com/apache/geode/pull/7159#discussion_r761401680



##########
File path: geode-core/src/main/java/org/apache/geode/cache/client/internal/pooling/ConnectionManagerImpl.java
##########
@@ -211,11 +211,17 @@ private PooledConnection createPooledConnection(ServerLocation serverLocation)
    */
   private PooledConnection forceCreateConnection(ServerLocation serverLocation)
       throws ServerRefusedConnectionException, ServerOperationException {
+    PooledConnection connection = null;
     connectionAccounting.create();
     try {
-      return createPooledConnection(serverLocation);
+      connection = createPooledConnection(serverLocation);
+      return connection;

Review comment:
       instead of the finally block, maybe add the `connectionAccounting.create()` line before the return?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org