[GitHub] [incubator-hudi] pratyakshsharma commented on a change in pull request #1031: [HUDI-350]: updated default value of config.getCleanerCommitsRetained() in javadocs

[GitBox <gi...@apache.org>]

pratyakshsharma commented on a change in pull request #1031: [HUDI-350]: updated default value of config.getCleanerCommitsRetained() in javadocs
URL: https://github.com/apache/incubator-hudi/pull/1031#discussion_r348503606
 
 

 ##########
 File path: hudi-client/src/main/java/org/apache/hudi/io/HoodieCleanHelper.java
 ##########
 @@ -176,10 +176,10 @@ public HoodieCleanHelper(HoodieTable<T> hoodieTable, HoodieWriteConfig config) {
    * - Leaves the latest version of the file untouched - For older versions, - It leaves all the commits untouched which
    * has occured in last <code>config.getCleanerCommitsRetained()</code> commits - It leaves ONE commit before this
    * window. We assume that the max(query execution time) == commit_batch_time * config.getCleanerCommitsRetained().
-   * This is 12 hours by default. This is essential to leave the file used by the query thats running for the max time.
+   * This is 5 hours by default. This is essential to leave the file used by the query thats running for the max time.
 
 Review comment:
   added

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services