You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/07/22 01:06:48 UTC

[GitHub] [arrow-rs] HaoYang670 opened a new issue, #2125: Lazily materialize the null buffer builder for all array builders.

HaoYang670 opened a new issue, #2125:
URL: https://github.com/apache/arrow-rs/issues/2125

   **Is your feature request related to a problem or challenge? Please describe what you are trying to do.**
   We have seen obvious performance improvement by lazily materializing the null buffer builder (please see the primitive builder or the boolean array builder). We want to use the optimization across all array builders.
   
   **Describe the solution you'd like**
   Instead of modifying each array builder one by one, I want to declare a new type: `NullBufferBuilder`
   ```rust
   struct NullBufferBuilder {
       bitmap_builder: Option<BooleanBufferBuilder>,
       length: usize,
   }
   
   impl NullBufferBuilder {
       fn append {...}
       fn finish {...}
       ...
   }
   ```
   
   Then, let each array builder to use it.
   
   **Describe alternatives you've considered**
   We could not do this.
   
   **Additional context**
   Add any other context or screenshots about the feature request here.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] tustvold closed issue #2125: Lazily materialize the null buffer builder for all array builders.

Posted by GitBox <gi...@apache.org>.
tustvold closed issue #2125: Lazily materialize the null buffer builder for all array builders.
URL: https://github.com/apache/arrow-rs/issues/2125


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] HaoYang670 commented on issue #2125: Lazily materialize the null buffer builder for all array builders.

Posted by GitBox <gi...@apache.org>.
HaoYang670 commented on issue #2125:
URL: https://github.com/apache/arrow-rs/issues/2125#issuecomment-1192077572

   I will work on this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org