You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by wei xiao <xw...@outlook.com> on 2018/06/15 19:07:37 UTC

Review Request 67616: Added the limitation of the nested container id length.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67616/
-----------------------------------------------------------

Review request for mesos, Gilbert Song and Jie Yu.


Bugs: MESOS-7168
    https://issues.apache.org/jira/browse/MESOS-7168


Repository: mesos


Description
-------

Added the limitation of the nested container id length.


Diffs
-----

  src/slave/constants.hpp b97daf3d2eb04b796de5283d9adb0f515ca69f8c 
  src/slave/validation.cpp 09f1fc702a1b4550c04bc9c99d5ebd17974ebbb1 
  src/tests/slave_validation_tests.cpp d8bc142dd707f0888c29bf070135d5d0083ef421 


Diff: https://reviews.apache.org/r/67616/diff/1/


Testing
-------


Thanks,

wei xiao

Re: Review Request 67616: Added the limitation of the container id length.

Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67616/#review204971
-----------------------------------------------------------



PASS: Mesos patch 67616 was successfully built and tested.

Reviews applied: `['67616']`

All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67616

- Mesos Reviewbot Windows


On June 18, 2018, 10:56 p.m., wei xiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67616/
> -----------------------------------------------------------
> 
> (Updated June 18, 2018, 10:56 p.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Bugs: MESOS-7168
>     https://issues.apache.org/jira/browse/MESOS-7168
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added the limitation of the container id length.
> 
> 
> Diffs
> -----
> 
>   src/slave/constants.hpp b97daf3d2eb04b796de5283d9adb0f515ca69f8c 
>   src/slave/validation.cpp 09f1fc702a1b4550c04bc9c99d5ebd17974ebbb1 
>   src/tests/slave_validation_tests.cpp d8bc142dd707f0888c29bf070135d5d0083ef421 
> 
> 
> Diff: https://reviews.apache.org/r/67616/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> wei xiao
> 
>

Re: Review Request 67616: Added the limitation of the container id length.

Posted by Gastón Kleiman <ga...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67616/#review204969
-----------------------------------------------------------



Thank you for your contribution! The patch looks pretty good, I just opened a few minor issues.

I noticed that I was looking at an old revision, so I closed some of the ones that were already addresed.

Small suggestion for the patch summary: `Added a length validation for container IDs.`

- Gastón Kleiman


On June 18, 2018, 3:56 p.m., wei xiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67616/
> -----------------------------------------------------------
> 
> (Updated June 18, 2018, 3:56 p.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Bugs: MESOS-7168
>     https://issues.apache.org/jira/browse/MESOS-7168
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added the limitation of the container id length.
> 
> 
> Diffs
> -----
> 
>   src/slave/constants.hpp b97daf3d2eb04b796de5283d9adb0f515ca69f8c 
>   src/slave/validation.cpp 09f1fc702a1b4550c04bc9c99d5ebd17974ebbb1 
>   src/tests/slave_validation_tests.cpp d8bc142dd707f0888c29bf070135d5d0083ef421 
> 
> 
> Diff: https://reviews.apache.org/r/67616/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> wei xiao
> 
>

Re: Review Request 67616: Added the limitation of the container id length.

Posted by Gastón Kleiman <ga...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67616/#review204968
-----------------------------------------------------------




src/slave/validation.cpp
Lines 58-59 (patched)
<https://reviews.apache.org/r/67616/#comment287817>

    We use stout's `stringify()` instead of `std::to_string()` in our codebase.
    
    We also try to avoid having trailing spaces in a string literal, preferring having them at the beginning of a line.
    
    I think we should also write "maximum" instead of "max".
    
    So I'd change these lines to:
    
    ```
        return Error("'ContainerID.value' '" + id + "' exceeds the maximum"
                     " length (" + stringify(MAX_CONTAINER_ID_LENGTH) + ")");
    ```


- Gastón Kleiman


On June 18, 2018, 3:56 p.m., wei xiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67616/
> -----------------------------------------------------------
> 
> (Updated June 18, 2018, 3:56 p.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Bugs: MESOS-7168
>     https://issues.apache.org/jira/browse/MESOS-7168
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added the limitation of the container id length.
> 
> 
> Diffs
> -----
> 
>   src/slave/constants.hpp b97daf3d2eb04b796de5283d9adb0f515ca69f8c 
>   src/slave/validation.cpp 09f1fc702a1b4550c04bc9c99d5ebd17974ebbb1 
>   src/tests/slave_validation_tests.cpp d8bc142dd707f0888c29bf070135d5d0083ef421 
> 
> 
> Diff: https://reviews.apache.org/r/67616/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> wei xiao
> 
>

Re: Review Request 67616: Added the limitation of the container id length.

Posted by wei xiao <xw...@outlook.com>.

> On 六月 18, 2018, 11:37 p.m., Gastón Kleiman wrote:
> > src/slave/constants.hpp
> > Lines 89 (patched)
> > <https://reviews.apache.org/r/67616/diff/1/?file=2041052#file2041052line89>
> >
> >     We should add a comment saying how we got to this magic number.
> >     
> >     Something like: `This value is set to AUFS' per-path-component limit`.
> >     
> >     We should check whether AUFS' limit is inclusive or exclusive, i.e., whether it the check should be: `containerId.length() < MAX_NESTED_CONTAINER_ID_LENGTH` or ``containerId.length() <= MAX_NESTED_CONTAINER_ID_LENGTH`

Thank you. I tested the aufs filename limitation in my laptop, 242 is ok, 243 failed.


- wei


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67616/#review204953
-----------------------------------------------------------


On 六月 18, 2018, 10:56 p.m., wei xiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67616/
> -----------------------------------------------------------
> 
> (Updated 六月 18, 2018, 10:56 p.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Bugs: MESOS-7168
>     https://issues.apache.org/jira/browse/MESOS-7168
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added the limitation of the container id length.
> 
> 
> Diffs
> -----
> 
>   src/slave/constants.hpp b97daf3d2eb04b796de5283d9adb0f515ca69f8c 
>   src/slave/validation.cpp 09f1fc702a1b4550c04bc9c99d5ebd17974ebbb1 
>   src/tests/slave_validation_tests.cpp d8bc142dd707f0888c29bf070135d5d0083ef421 
> 
> 
> Diff: https://reviews.apache.org/r/67616/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> wei xiao
> 
>

Re: Review Request 67616: Added the limitation of the container id length.

Posted by Gastón Kleiman <ga...@mesosphere.io>.

> On June 18, 2018, 4:37 p.m., Gastón Kleiman wrote:
> > src/slave/validation.cpp
> > Lines 75-77 (patched)
> > <https://reviews.apache.org/r/67616/diff/1/?file=2041053#file2041053line75>
> >
> >     Is there any reason why we shouldn't perform this validation for containers without a parent container? 
> >     
> >     I think we should move this block outside the `containerId.has_parent()` check.

A similar issue was opened by Joseph and has been addressed, dropping this one.


> On June 18, 2018, 4:37 p.m., Gastón Kleiman wrote:
> > src/slave/validation.cpp
> > Lines 76 (patched)
> > <https://reviews.apache.org/r/67616/diff/1/?file=2041053#file2041053line76>
> >
> >     I believe that this is a user-facing error (it shows up in logs and might even be sent in an HTTP response), so it needs to be a bit friendlier.
> >     
> >     I suggest something like:
> >     
> >     ```
> >     "'ContainerID.value' exceeds " + stringify(MAX_NESTED_CONTAINER_ID_LENGTH) +" characters".
> >     ```

Dropping this one as it was already addresed.


- Gastón


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67616/#review204953
-----------------------------------------------------------


On June 18, 2018, 3:56 p.m., wei xiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67616/
> -----------------------------------------------------------
> 
> (Updated June 18, 2018, 3:56 p.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Bugs: MESOS-7168
>     https://issues.apache.org/jira/browse/MESOS-7168
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added the limitation of the container id length.
> 
> 
> Diffs
> -----
> 
>   src/slave/constants.hpp b97daf3d2eb04b796de5283d9adb0f515ca69f8c 
>   src/slave/validation.cpp 09f1fc702a1b4550c04bc9c99d5ebd17974ebbb1 
>   src/tests/slave_validation_tests.cpp d8bc142dd707f0888c29bf070135d5d0083ef421 
> 
> 
> Diff: https://reviews.apache.org/r/67616/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> wei xiao
> 
>

Re: Review Request 67616: Added the limitation of the container id length.

Posted by Gastón Kleiman <ga...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67616/#review204953
-----------------------------------------------------------




src/slave/constants.hpp
Lines 89 (patched)
<https://reviews.apache.org/r/67616/#comment287790>

    We should add a comment saying how we got to this magic number.
    
    Something like: `This value is set to AUFS' per-path-component limit`.
    
    We should check whether AUFS' limit is inclusive or exclusive, i.e., whether it the check should be: `containerId.length() < MAX_NESTED_CONTAINER_ID_LENGTH` or ``containerId.length() <= MAX_NESTED_CONTAINER_ID_LENGTH`



src/slave/validation.cpp
Lines 18 (patched)
<https://reviews.apache.org/r/67616/#comment287791>

    We sort includes from the same component lexicographically, so this include should go before line #17.



src/slave/validation.cpp
Lines 75-77 (patched)
<https://reviews.apache.org/r/67616/#comment287814>

    Is there any reason why we shouldn't perform this validation for containers without a parent container? 
    
    I think we should move this block outside the `containerId.has_parent()` check.



src/slave/validation.cpp
Lines 76 (patched)
<https://reviews.apache.org/r/67616/#comment287812>

    I believe that this is a user-facing error (it shows up in logs and might even be sent in an HTTP response), so it needs to be a bit friendlier.
    
    I suggest something like:
    
    ```
    "'ContainerID.value' exceeds " + stringify(MAX_NESTED_CONTAINER_ID_LENGTH) +" characters".
    ```



src/tests/slave_validation_tests.cpp
Lines 96 (patched)
<https://reviews.apache.org/r/67616/#comment287813>

    s/id/ID/


- Gastón Kleiman


On June 18, 2018, 3:56 p.m., wei xiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67616/
> -----------------------------------------------------------
> 
> (Updated June 18, 2018, 3:56 p.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Bugs: MESOS-7168
>     https://issues.apache.org/jira/browse/MESOS-7168
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added the limitation of the container id length.
> 
> 
> Diffs
> -----
> 
>   src/slave/constants.hpp b97daf3d2eb04b796de5283d9adb0f515ca69f8c 
>   src/slave/validation.cpp 09f1fc702a1b4550c04bc9c99d5ebd17974ebbb1 
>   src/tests/slave_validation_tests.cpp d8bc142dd707f0888c29bf070135d5d0083ef421 
> 
> 
> Diff: https://reviews.apache.org/r/67616/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> wei xiao
> 
>

Re: Review Request 67616: Added the limitation of the container id length.

Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67616/#review204972
-----------------------------------------------------------



Patch looks great!

Reviews applied: [67616]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On June 18, 2018, 3:56 p.m., wei xiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67616/
> -----------------------------------------------------------
> 
> (Updated June 18, 2018, 3:56 p.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Bugs: MESOS-7168
>     https://issues.apache.org/jira/browse/MESOS-7168
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added the limitation of the container id length.
> 
> 
> Diffs
> -----
> 
>   src/slave/constants.hpp b97daf3d2eb04b796de5283d9adb0f515ca69f8c 
>   src/slave/validation.cpp 09f1fc702a1b4550c04bc9c99d5ebd17974ebbb1 
>   src/tests/slave_validation_tests.cpp d8bc142dd707f0888c29bf070135d5d0083ef421 
> 
> 
> Diff: https://reviews.apache.org/r/67616/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> wei xiao
> 
>

Re: Review Request 67616: Added a length validation for container IDs.

Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67616/#review205198
-----------------------------------------------------------


Ship it!




Ship It!

- Gilbert Song


On June 18, 2018, 10:45 p.m., wei xiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67616/
> -----------------------------------------------------------
> 
> (Updated June 18, 2018, 10:45 p.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Bugs: MESOS-7168
>     https://issues.apache.org/jira/browse/MESOS-7168
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added a length validation for container IDs.
> 
> 
> Diffs
> -----
> 
>   src/slave/constants.hpp b97daf3d2eb04b796de5283d9adb0f515ca69f8c 
>   src/slave/validation.cpp 09f1fc702a1b4550c04bc9c99d5ebd17974ebbb1 
>   src/tests/slave_validation_tests.cpp d8bc142dd707f0888c29bf070135d5d0083ef421 
> 
> 
> Diff: https://reviews.apache.org/r/67616/diff/3/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> wei xiao
> 
>

Re: Review Request 67616: Added a length validation for container IDs.

Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67616/#review204988
-----------------------------------------------------------



Patch looks great!

Reviews applied: [67616]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On June 19, 2018, 5:45 a.m., wei xiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67616/
> -----------------------------------------------------------
> 
> (Updated June 19, 2018, 5:45 a.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Bugs: MESOS-7168
>     https://issues.apache.org/jira/browse/MESOS-7168
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added a length validation for container IDs.
> 
> 
> Diffs
> -----
> 
>   src/slave/constants.hpp b97daf3d2eb04b796de5283d9adb0f515ca69f8c 
>   src/slave/validation.cpp 09f1fc702a1b4550c04bc9c99d5ebd17974ebbb1 
>   src/tests/slave_validation_tests.cpp d8bc142dd707f0888c29bf070135d5d0083ef421 
> 
> 
> Diff: https://reviews.apache.org/r/67616/diff/3/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> wei xiao
> 
>

Re: Review Request 67616: Added a length validation for container IDs.

Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67616/#review204987
-----------------------------------------------------------



PASS: Mesos patch 67616 was successfully built and tested.

Reviews applied: `['67616']`

All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67616

- Mesos Reviewbot Windows


On June 19, 2018, 5:45 a.m., wei xiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67616/
> -----------------------------------------------------------
> 
> (Updated June 19, 2018, 5:45 a.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Bugs: MESOS-7168
>     https://issues.apache.org/jira/browse/MESOS-7168
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added a length validation for container IDs.
> 
> 
> Diffs
> -----
> 
>   src/slave/constants.hpp b97daf3d2eb04b796de5283d9adb0f515ca69f8c 
>   src/slave/validation.cpp 09f1fc702a1b4550c04bc9c99d5ebd17974ebbb1 
>   src/tests/slave_validation_tests.cpp d8bc142dd707f0888c29bf070135d5d0083ef421 
> 
> 
> Diff: https://reviews.apache.org/r/67616/diff/3/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> wei xiao
> 
>

Re: Review Request 67616: Added a length validation for container IDs.

Posted by wei xiao <xw...@outlook.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67616/
-----------------------------------------------------------

(Updated 六月 19, 2018, 5:45 a.m.)


Review request for mesos, Gilbert Song and Jie Yu.


Summary (updated)
-----------------

Added a length validation for container IDs.


Bugs: MESOS-7168
    https://issues.apache.org/jira/browse/MESOS-7168


Repository: mesos


Description (updated)
-------

Added a length validation for container IDs.


Diffs (updated)
-----

  src/slave/constants.hpp b97daf3d2eb04b796de5283d9adb0f515ca69f8c 
  src/slave/validation.cpp 09f1fc702a1b4550c04bc9c99d5ebd17974ebbb1 
  src/tests/slave_validation_tests.cpp d8bc142dd707f0888c29bf070135d5d0083ef421 


Diff: https://reviews.apache.org/r/67616/diff/3/

Changes: https://reviews.apache.org/r/67616/diff/2-3/


Testing
-------


Thanks,

wei xiao

Re: Review Request 67616: Added the limitation of the container id length.

Posted by wei xiao <xw...@outlook.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67616/
-----------------------------------------------------------

(Updated 六月 18, 2018, 10:56 p.m.)


Review request for mesos, Gilbert Song and Jie Yu.


Summary (updated)
-----------------

Added the limitation of the container id length.


Bugs: MESOS-7168
    https://issues.apache.org/jira/browse/MESOS-7168


Repository: mesos


Description (updated)
-------

Added the limitation of the container id length.


Diffs (updated)
-----

  src/slave/constants.hpp b97daf3d2eb04b796de5283d9adb0f515ca69f8c 
  src/slave/validation.cpp 09f1fc702a1b4550c04bc9c99d5ebd17974ebbb1 
  src/tests/slave_validation_tests.cpp d8bc142dd707f0888c29bf070135d5d0083ef421 


Diff: https://reviews.apache.org/r/67616/diff/2/

Changes: https://reviews.apache.org/r/67616/diff/1-2/


Testing
-------


Thanks,

wei xiao

Re: Review Request 67616: Added the limitation of the nested container id length.

Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67616/#review204952
-----------------------------------------------------------




src/slave/constants.hpp
Lines 88-89 (patched)
<https://reviews.apache.org/r/67616/#comment287789>

    Can you add a sentence on why `242` was chosen?  (i.e. max entry length for directory names on AUFS)
    
    Also, comments should end with a period.  The style checker should catch things like this if you set up the commit hooks properly.



src/slave/validation.cpp
Lines 75-77 (patched)
<https://reviews.apache.org/r/67616/#comment287788>

    Let's move this check out of the nested case.  We should check it in all cases instead.
    
    For normal container launches, the ContainerID is agent-generated, so we should never fail validation there.  But standalone containers are user-specified top-level containers.  So we need to enforce the length limit there too.



src/slave/validation.cpp
Lines 76 (patched)
<https://reviews.apache.org/r/67616/#comment287787>

    Looks like this error message is missing a part after the "exceeds" (i.e. "exceeds the max length (242)").


- Joseph Wu


On June 15, 2018, 12:07 p.m., wei xiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67616/
> -----------------------------------------------------------
> 
> (Updated June 15, 2018, 12:07 p.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Bugs: MESOS-7168
>     https://issues.apache.org/jira/browse/MESOS-7168
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added the limitation of the nested container id length.
> 
> 
> Diffs
> -----
> 
>   src/slave/constants.hpp b97daf3d2eb04b796de5283d9adb0f515ca69f8c 
>   src/slave/validation.cpp 09f1fc702a1b4550c04bc9c99d5ebd17974ebbb1 
>   src/tests/slave_validation_tests.cpp d8bc142dd707f0888c29bf070135d5d0083ef421 
> 
> 
> Diff: https://reviews.apache.org/r/67616/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> wei xiao
> 
>

Re: Review Request 67616: Added the limitation of the nested container id length.

Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67616/#review204895
-----------------------------------------------------------



Patch looks great!

Reviews applied: [67616]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On June 15, 2018, 12:07 p.m., wei xiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67616/
> -----------------------------------------------------------
> 
> (Updated June 15, 2018, 12:07 p.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Bugs: MESOS-7168
>     https://issues.apache.org/jira/browse/MESOS-7168
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added the limitation of the nested container id length.
> 
> 
> Diffs
> -----
> 
>   src/slave/constants.hpp b97daf3d2eb04b796de5283d9adb0f515ca69f8c 
>   src/slave/validation.cpp 09f1fc702a1b4550c04bc9c99d5ebd17974ebbb1 
>   src/tests/slave_validation_tests.cpp d8bc142dd707f0888c29bf070135d5d0083ef421 
> 
> 
> Diff: https://reviews.apache.org/r/67616/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> wei xiao
> 
>

Re: Review Request 67616: Added the limitation of the nested container id length.

Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67616/#review204869
-----------------------------------------------------------



PASS: Mesos patch 67616 was successfully built and tested.

Reviews applied: `['67616']`

All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67616

- Mesos Reviewbot Windows


On June 15, 2018, 7:07 p.m., wei xiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67616/
> -----------------------------------------------------------
> 
> (Updated June 15, 2018, 7:07 p.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Bugs: MESOS-7168
>     https://issues.apache.org/jira/browse/MESOS-7168
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added the limitation of the nested container id length.
> 
> 
> Diffs
> -----
> 
>   src/slave/constants.hpp b97daf3d2eb04b796de5283d9adb0f515ca69f8c 
>   src/slave/validation.cpp 09f1fc702a1b4550c04bc9c99d5ebd17974ebbb1 
>   src/tests/slave_validation_tests.cpp d8bc142dd707f0888c29bf070135d5d0083ef421 
> 
> 
> Diff: https://reviews.apache.org/r/67616/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> wei xiao
> 
>