You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2020/09/15 12:39:55 UTC
[GitHub] [lucene-solr] tommedge opened a new pull request #1875: SOLR-14802: Allow LLPSF fields as geodist argument
tommedge opened a new pull request #1875:
URL: https://github.com/apache/lucene-solr/pull/1875
# Description
Allows LLPSF fields to be used as arguments to geodist function
# Solution
Moves resolving of field arguments from FunctionQParser to GeoDistValueSourceParser where the required strategy can be used, same as for existing sfield support
# Tests
Tests multiple usages of geodist in same query, with arguments of type LatLonPointSpatialField and without
# Checklist
Please review the following and check all that apply:
- [X] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability.
- [X] I have created a Jira issue and added the issue ID to my pull request title.
- [X] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended)
- [ ] I have developed this patch against the `master` branch.
- [ ] I have run `./gradlew check`.
- [X] I have added tests for my changes.
- [ ] I have added documentation for the [Ref Guide](https://github.com/apache/lucene-solr/tree/master/solr/solr-ref-guide) (for Solr changes only).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] dsmiley closed pull request #1875: SOLR-14802: Allow LLPSF fields as geodist argument
Posted by GitBox <gi...@apache.org>.
dsmiley closed pull request #1875:
URL: https://github.com/apache/lucene-solr/pull/1875
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] dsmiley closed pull request #1875: SOLR-14802: Allow LLPSF fields as geodist argument
Posted by GitBox <gi...@apache.org>.
dsmiley closed pull request #1875:
URL: https://github.com/apache/lucene-solr/pull/1875
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] dsmiley commented on pull request #1875: SOLR-14802: Allow LLPSF fields as geodist argument
Posted by GitBox <gi...@apache.org>.
dsmiley commented on pull request #1875:
URL: https://github.com/apache/lucene-solr/pull/1875#issuecomment-695886358
I made some tweaks and committed to master & branch_8x
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] dsmiley commented on pull request #1875: SOLR-14802: Allow LLPSF fields as geodist argument
Posted by GitBox <gi...@apache.org>.
dsmiley commented on pull request #1875:
URL: https://github.com/apache/lucene-solr/pull/1875#issuecomment-695886358
I made some tweaks and committed to master & branch_8x
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org