You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "James E. King III (JIRA)" <ji...@apache.org> on 2019/01/03 13:07:00 UTC

[jira] [Updated] (THRIFT-1324) TFramedTransport should enforce frame size limits on writes

     [ https://issues.apache.org/jira/browse/THRIFT-1324?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

James E. King III updated THRIFT-1324:
--------------------------------------
    Labels: easyfix  (was: )

> TFramedTransport should enforce frame size limits on writes
> -----------------------------------------------------------
>
>                 Key: THRIFT-1324
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1324
>             Project: Thrift
>          Issue Type: Bug
>          Components: Java - Library
>            Reporter: Jim Ancona
>            Priority: Major
>              Labels: easyfix
>             Fix For: 1.0
>
>
> Currently TFramedTransport only enforces the maximum frame size when it receives a frame larger than its configured maxLength_ value. so there is no way to enforce a maximum frame size on the client. Because servers typically deal with oversized frames by silently dropping them (see THRIFT-1323), problems caused by oversized frames can be very hard to diagnose. Enforcing the maximum frame size on writes would enable clients to detect the frame size mismatch, assuming the client and server are configured with the same value.
> Note that the exception thrown in this case should not be a generic TTransportException--it should be either a subclass or a new TTransportException.type_ value so that clients can distinguish the frame too large error. This is important because most other TTransportException causes reflect transient conditions where retry may be appropriate, but a too-large frame will never succeed if retried.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)