You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by David Nalley <da...@gnsa.us> on 2012/05/26 21:10:42 UTC

Fwd: [CloudStack] Remove unnecessary option (#16)

---------- Forwarded message ----------
From: butanet <re...@reply.github.com>
Date: Sat, May 26, 2012 at 1:31 PM
Subject: [CloudStack] Remove unnecessary option (#16)
To: hudsoncloudies <ke...@cloudstack.org>


"-s" option is not used to mean disk image size as it was originally
intended in createtmplt.sh. Instead, it is used to mean "snapshot" in
createtmplt.sh and causes an error.

You can merge this Pull Request by running:

 git pull https://github.com/butanet/CloudStack patch-3

Or you can view, comment on it, or merge it online at:

 https://github.com/CloudStack/CloudStack/pull/16

-- Commit Summary --

* Remove unnecessary option

-- File Changes --

M scripts/storage/qcow2/importmpl.sh (4)

-- Patch Links --

 https://github.com/CloudStack/CloudStack/pull/16.patch
 https://github.com/CloudStack/CloudStack/pull/16.diff

---
Reply to this email directly or view it on GitHub:
https://github.com/CloudStack/CloudStack/pull/16

RE: [CloudStack] Remove unnecessary option (#16)

Posted by Edison Su <Ed...@citrix.com>.
NAK. As you said, "-s 1" means creating template from snapshot, while "-s 2"(which is used in importmpl.sh) means creating template from another template, which is correct.
butanet , what's the exact issue do you find? Any log?

> -----Original Message-----
> From: David Nalley [mailto:david@gnsa.us]
> Sent: Saturday, May 26, 2012 12:11 PM
> To: cloudstack-dev@incubator.apache.org
> Subject: Fwd: [CloudStack] Remove unnecessary option (#16)
> 
> ---------- Forwarded message ----------
> From: butanet <reply+i-4767140-
> c5db0c206b1fd907c415e0328507a0b3d8427476-1129409@reply.github.com>
> Date: Sat, May 26, 2012 at 1:31 PM
> Subject: [CloudStack] Remove unnecessary option (#16)
> To: hudsoncloudies <ke...@cloudstack.org>
> 
> 
> "-s" option is not used to mean disk image size as it was originally
> intended in createtmplt.sh. Instead, it is used to mean "snapshot" in
> createtmplt.sh and causes an error.
> 
> You can merge this Pull Request by running:
> 
>  git pull https://github.com/butanet/CloudStack patch-3
> 
> Or you can view, comment on it, or merge it online at:
> 
>  https://github.com/CloudStack/CloudStack/pull/16
> 
> -- Commit Summary --
> 
> * Remove unnecessary option
> 
> -- File Changes --
> 
> M scripts/storage/qcow2/importmpl.sh (4)
> 
> -- Patch Links --
> 
>  https://github.com/CloudStack/CloudStack/pull/16.patch
>  https://github.com/CloudStack/CloudStack/pull/16.diff
> 
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/CloudStack/CloudStack/pull/16