[jira] [Commented] (FLINK-5256) Extend DataSetSingleRowJoin to support Left and Right joins

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-5256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15996611#comment-15996611 ] 

ASF GitHub Bot commented on FLINK-5256:
---------------------------------------

Github user DmytroShkvyra commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3673#discussion_r114755267
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/dataset/DataSetSingleRowJoin.scala ---
    @@ -44,9 +45,11 @@ class DataSetSingleRowJoin(
         leftNode: RelNode,
         rightNode: RelNode,
         leftIsSingle: Boolean,
    +    rightIsSingle: Boolean,
         rowRelDataType: RelDataType,
         joinCondition: RexNode,
         joinRowType: RelDataType,
    +    joinType: JoinRelType,
    --- End diff --
    
    @fhueske we already have `.item("joinType", joinTypeToString)` in `explainTerms`. Did you mean change `joinTypeToString` ("NestedLoopJoin") to `joinType.toString`? 


> Extend DataSetSingleRowJoin to support Left and Right joins
> -----------------------------------------------------------
>
>                 Key: FLINK-5256
>                 URL: https://issues.apache.org/jira/browse/FLINK-5256
>             Project: Flink
>          Issue Type: Improvement
>          Components: Table API & SQL
>    Affects Versions: 1.2.0
>            Reporter: Fabian Hueske
>            Assignee: Dmytro Shkvyra
>
> The {{DataSetSingleRowJoin}} is a broadcast-map join that supports arbitrary inner joins where one input is a single row.
> I found that Calcite translates certain subqueries into non-equi left and right joins with single input. These cases can be handled if the  {{DataSetSingleRowJoin}} is extended to support outer joins on the non-single-row input, i.e., left joins if the right side is single input and vice versa.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)