You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/06/30 20:32:18 UTC

[GitHub] [kafka] jsancio commented on a change in pull request #10946: KAFKA-12997: Expose the append time for batches from the raft

jsancio commented on a change in pull request #10946:
URL: https://github.com/apache/kafka/pull/10946#discussion_r661791189



##########
File path: raft/src/main/java/org/apache/kafka/raft/internals/BatchAccumulator.java
##########
@@ -495,6 +506,10 @@ public int sizeInBytes() {
         public void release() {
             pool.release(initialBuffer);
         }
+
+        public long appendTimestamp() {
+            return data.firstBatch().maxTimestamp();

Review comment:
       Yes. I added this check and message to the PR: https://github.com/apache/kafka/pull/10946/files/1964e026b783235e2d9af9c0b116f15ed31e0a5b#diff-b7a2129b03764fbafab69c81e985d8ac6006d55f95307f0e21c70fb4750f61b5R475




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org