You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@groovy.apache.org by "Eric Milles (Jira)" <ji...@apache.org> on 2020/08/18 15:42:00 UTC

[jira] [Commented] (GROOVY-9683) Changed behavior of delegates in 2.5.13

    [ https://issues.apache.org/jira/browse/GROOVY-9683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17179709#comment-17179709 ] 

Eric Milles commented on GROOVY-9683:
-------------------------------------

Yes, this is discussed in another issue.  This was an intentional change to fix issues encountered in closure resolve strategy implementation.

Map-based types have a "special" nature in that the handle all property requests.  So when you use one as a delegate it never produces a missing property condition and so no other objects in the closure resolve chain are checked.

There are workarounds mentioned where you can use the {{withDefault}} extension method to throw MissinPropertyException and allow the Groovy MOP to continue searching.

> Changed behavior of delegates in 2.5.13
> ---------------------------------------
>
>                 Key: GROOVY-9683
>                 URL: https://issues.apache.org/jira/browse/GROOVY-9683
>             Project: Groovy
>          Issue Type: Bug
>    Affects Versions: 2.5.13
>            Reporter: Grzegorz Kaczmarczyk
>            Priority: Major
>
> I've noticed difference in how maps behave when used as delegates between 2.5.12 (and earlier versions) and 2.5.13. Consider this code snippet:
> {code:java}
> class MapAsDelegateProblem {
>     static void main(String[] args) {
>         new MapAsDelegateProblem().problematicCode()
>     }
>     def problematicCode() {
>         def map = [:]
>         callForAProblem(map) {
>             assert "abc" == BAR
>         }
>     }
>     def <U> void callForAProblem(U target, Closure<?> closure) {
>         closure.setDelegate(target)
>         closure.setResolveStrategy(Closure.DELEGATE_FIRST)
>         closure.call(target)
>     }
>     private static final BAR = "abc"
> } {code}
> In 2.5.x (up to 2.5.12) this code works just fine. Static field {{BAR}} is accessed from closure in line 10. But this breaks in 2.5.13. This affects also tests written in Spock. Utility method {{spock.lang.Specification::with}} works in the same way as {{callForAProblem}}.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)