You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@qpid.apache.org by ro...@apache.org on 2014/02/16 00:05:34 UTC

svn commit: r1568702 - in /qpid/jms/trunk/src: main/java/org/apache/qpid/jms/impl/ test/java/org/apache/qpid/jms/impl/

Author: robbie
Date: Sat Feb 15 23:05:33 2014
New Revision: 1568702

URL: http://svn.apache.org/r1568702
Log:
QPIDJMS-9: move responsibility for implementing clearBody() to the concrete message classes

Modified:
    qpid/jms/trunk/src/main/java/org/apache/qpid/jms/impl/BytesMessageImpl.java
    qpid/jms/trunk/src/main/java/org/apache/qpid/jms/impl/GenericAmqpMessageImpl.java
    qpid/jms/trunk/src/main/java/org/apache/qpid/jms/impl/MapMessageImpl.java
    qpid/jms/trunk/src/main/java/org/apache/qpid/jms/impl/MessageImpl.java
    qpid/jms/trunk/src/main/java/org/apache/qpid/jms/impl/ObjectMessageImpl.java
    qpid/jms/trunk/src/main/java/org/apache/qpid/jms/impl/StreamMessageImpl.java
    qpid/jms/trunk/src/main/java/org/apache/qpid/jms/impl/TextMessageImpl.java
    qpid/jms/trunk/src/test/java/org/apache/qpid/jms/impl/TestMessageImpl.java

Modified: qpid/jms/trunk/src/main/java/org/apache/qpid/jms/impl/BytesMessageImpl.java
URL: http://svn.apache.org/viewvc/qpid/jms/trunk/src/main/java/org/apache/qpid/jms/impl/BytesMessageImpl.java?rev=1568702&r1=1568701&r2=1568702&view=diff
==============================================================================
--- qpid/jms/trunk/src/main/java/org/apache/qpid/jms/impl/BytesMessageImpl.java (original)
+++ qpid/jms/trunk/src/main/java/org/apache/qpid/jms/impl/BytesMessageImpl.java Sat Feb 15 23:05:33 2014
@@ -305,4 +305,11 @@ public class BytesMessageImpl extends Me
         //TODO
         throw new UnsupportedOperationException("Not Implemented");
     }
+
+    @Override
+    public void clearBody() throws JMSException
+    {
+        // TODO Auto-generated method stub
+        throw new UnsupportedOperationException("Not Implemented");
+    }
 }

Modified: qpid/jms/trunk/src/main/java/org/apache/qpid/jms/impl/GenericAmqpMessageImpl.java
URL: http://svn.apache.org/viewvc/qpid/jms/trunk/src/main/java/org/apache/qpid/jms/impl/GenericAmqpMessageImpl.java?rev=1568702&r1=1568701&r2=1568702&view=diff
==============================================================================
--- qpid/jms/trunk/src/main/java/org/apache/qpid/jms/impl/GenericAmqpMessageImpl.java (original)
+++ qpid/jms/trunk/src/main/java/org/apache/qpid/jms/impl/GenericAmqpMessageImpl.java Sat Feb 15 23:05:33 2014
@@ -45,4 +45,10 @@ public class GenericAmqpMessageImpl exte
         throw new UnsupportedOperationException("Not Implemented");
     }
 
+    @Override
+    public void clearBody() throws JMSException
+    {
+        // TODO Auto-generated method stub
+        throw new UnsupportedOperationException("Not Implemented");
+    }
 }

Modified: qpid/jms/trunk/src/main/java/org/apache/qpid/jms/impl/MapMessageImpl.java
URL: http://svn.apache.org/viewvc/qpid/jms/trunk/src/main/java/org/apache/qpid/jms/impl/MapMessageImpl.java?rev=1568702&r1=1568701&r2=1568702&view=diff
==============================================================================
--- qpid/jms/trunk/src/main/java/org/apache/qpid/jms/impl/MapMessageImpl.java (original)
+++ qpid/jms/trunk/src/main/java/org/apache/qpid/jms/impl/MapMessageImpl.java Sat Feb 15 23:05:33 2014
@@ -225,4 +225,11 @@ public class MapMessageImpl extends Mess
         //TODO
         throw new UnsupportedOperationException("Not Implemented");
     }
+
+    @Override
+    public void clearBody() throws JMSException
+    {
+        // TODO Auto-generated method stub
+        throw new UnsupportedOperationException("Not Implemented");
+    }
 }

Modified: qpid/jms/trunk/src/main/java/org/apache/qpid/jms/impl/MessageImpl.java
URL: http://svn.apache.org/viewvc/qpid/jms/trunk/src/main/java/org/apache/qpid/jms/impl/MessageImpl.java?rev=1568702&r1=1568701&r2=1568702&view=diff
==============================================================================
--- qpid/jms/trunk/src/main/java/org/apache/qpid/jms/impl/MessageImpl.java (original)
+++ qpid/jms/trunk/src/main/java/org/apache/qpid/jms/impl/MessageImpl.java Sat Feb 15 23:05:33 2014
@@ -954,9 +954,5 @@ public abstract class MessageImpl<T exte
     }
 
     @Override
-    public void clearBody() throws JMSException
-    {
-        // TODO Auto-generated method stub
-        throw new UnsupportedOperationException("Not Implemented");
-    }
+    public abstract void clearBody() throws JMSException;
 }

Modified: qpid/jms/trunk/src/main/java/org/apache/qpid/jms/impl/ObjectMessageImpl.java
URL: http://svn.apache.org/viewvc/qpid/jms/trunk/src/main/java/org/apache/qpid/jms/impl/ObjectMessageImpl.java?rev=1568702&r1=1568701&r2=1568702&view=diff
==============================================================================
--- qpid/jms/trunk/src/main/java/org/apache/qpid/jms/impl/ObjectMessageImpl.java (original)
+++ qpid/jms/trunk/src/main/java/org/apache/qpid/jms/impl/ObjectMessageImpl.java Sat Feb 15 23:05:33 2014
@@ -62,4 +62,11 @@ public class ObjectMessageImpl extends M
         //TODO
         throw new UnsupportedOperationException("Not Implemented");
     }
+
+    @Override
+    public void clearBody() throws JMSException
+    {
+        // TODO Auto-generated method stub
+        throw new UnsupportedOperationException("Not Implemented");
+    }
 }

Modified: qpid/jms/trunk/src/main/java/org/apache/qpid/jms/impl/StreamMessageImpl.java
URL: http://svn.apache.org/viewvc/qpid/jms/trunk/src/main/java/org/apache/qpid/jms/impl/StreamMessageImpl.java?rev=1568702&r1=1568701&r2=1568702&view=diff
==============================================================================
--- qpid/jms/trunk/src/main/java/org/apache/qpid/jms/impl/StreamMessageImpl.java (original)
+++ qpid/jms/trunk/src/main/java/org/apache/qpid/jms/impl/StreamMessageImpl.java Sat Feb 15 23:05:33 2014
@@ -215,4 +215,11 @@ public class StreamMessageImpl extends M
         //TODO
         throw new UnsupportedOperationException("Not Implemented");
     }
+
+    @Override
+    public void clearBody() throws JMSException
+    {
+        // TODO Auto-generated method stub
+        throw new UnsupportedOperationException("Not Implemented");
+    }
 }

Modified: qpid/jms/trunk/src/main/java/org/apache/qpid/jms/impl/TextMessageImpl.java
URL: http://svn.apache.org/viewvc/qpid/jms/trunk/src/main/java/org/apache/qpid/jms/impl/TextMessageImpl.java?rev=1568702&r1=1568701&r2=1568702&view=diff
==============================================================================
--- qpid/jms/trunk/src/main/java/org/apache/qpid/jms/impl/TextMessageImpl.java (original)
+++ qpid/jms/trunk/src/main/java/org/apache/qpid/jms/impl/TextMessageImpl.java Sat Feb 15 23:05:33 2014
@@ -62,4 +62,11 @@ public class TextMessageImpl extends Mes
         //TODO: checkWritable();
         getUnderlyingAmqpMessage(false).setText(text);
     }
+
+    @Override
+    public void clearBody() throws JMSException
+    {
+        // TODO Auto-generated method stub
+        throw new UnsupportedOperationException("Not Implemented");
+    }
 }

Modified: qpid/jms/trunk/src/test/java/org/apache/qpid/jms/impl/TestMessageImpl.java
URL: http://svn.apache.org/viewvc/qpid/jms/trunk/src/test/java/org/apache/qpid/jms/impl/TestMessageImpl.java?rev=1568702&r1=1568701&r2=1568702&view=diff
==============================================================================
--- qpid/jms/trunk/src/test/java/org/apache/qpid/jms/impl/TestMessageImpl.java (original)
+++ qpid/jms/trunk/src/test/java/org/apache/qpid/jms/impl/TestMessageImpl.java Sat Feb 15 23:05:33 2014
@@ -21,6 +21,7 @@
 package org.apache.qpid.jms.impl;
 
 import javax.jms.Destination;
+import javax.jms.JMSException;
 
 import org.apache.qpid.jms.engine.AmqpMessage;
 import org.apache.qpid.jms.engine.TestAmqpMessage;
@@ -73,4 +74,10 @@ public class TestMessageImpl extends Mes
 
         return new TestMessageImpl((TestAmqpMessage) amqpMessage, sessionImpl, connectionImpl, consumerDestination);
     }
+
+    @Override
+    public void clearBody() throws JMSException
+    {
+        throw new UnsupportedOperationException("Not Supported on " + TestMessageImpl.class.getName());
+    }
 }
\ No newline at end of file



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@qpid.apache.org
For additional commands, e-mail: commits-help@qpid.apache.org