You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/02/09 05:46:47 UTC

[GitHub] [spark] yeshengm opened a new pull request #35456: [SPARK-38156][SQL] Support CREATE EXTERNAL TABLE LIKE syntax

yeshengm opened a new pull request #35456:
URL: https://github.com/apache/spark/pull/35456


   <!--
   Thanks for sending a pull request!  Here are some tips for you:
     1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
     2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
     3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
     4. Be sure to keep the PR description updated to reflect all changes.
     5. Please write your PR title to summarize what this PR proposes.
     6. If possible, provide a concise example to reproduce the issue for a faster review.
     7. If you want to add a new configuration, please read the guideline first for naming configurations in
        'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
     8. If you want to add or modify an error type or message, please read the guideline first in
        'core/src/main/resources/error/README.md'.
   -->
   
   ### What changes were proposed in this pull request?
   Support `CREATE EXTERNAL TABLE LIKE` syntax.
   
   
   ### Why are the changes needed?
   For making the SQL API more consistent and ergonomic for users.
   
   
   ### Does this PR introduce _any_ user-facing change?
   Before: only `CREATE TABLE a LIKE b LOCATION path` is supported.
   After: Both `CREATE TABLE a LIKE b LOCATION path` and `CREATE EXTERNAL TABLE a LIKE b LOCATION path`
   
   
   ### How was this patch tested?
   New UTs.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HyukjinKwon commented on pull request #35456: [SPARK-38156][SQL] Support CREATE EXTERNAL TABLE LIKE syntax

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #35456:
URL: https://github.com/apache/spark/pull/35456#issuecomment-1034362766


   I remember this is matched to Hive's syntax. Does Hive allow this?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] yeshengm commented on pull request #35456: [SPARK-38156][SQL] Support CREATE EXTERNAL TABLE LIKE syntax

Posted by GitBox <gi...@apache.org>.
yeshengm commented on pull request #35456:
URL: https://github.com/apache/spark/pull/35456#issuecomment-1033375339


   cc @cloud-fan 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] cloud-fan commented on pull request #35456: [SPARK-38156][SQL] Support CREATE EXTERNAL TABLE LIKE syntax

Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #35456:
URL: https://github.com/apache/spark/pull/35456#issuecomment-1034476640


   Hive doesn't support this: https://cwiki.apache.org/confluence/display/Hive/LanguageManual+DDL#LanguageManualDDL-CreateTableLike
   
   I'm fine with this. People can already create an external table by specifying the `LOCATION`, and it's OK to allow `EXTERNAL` if `LOCATION` is present, to make the SQL syntax more consistent with normal CREATE TABLE.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org