You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by Chun-Hung Hsiao <ch...@apache.org> on 2018/06/01 00:45:56 UTC

Re: Review Request 65666: Added a unit test for SLRP operation state metrics.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65666/
-----------------------------------------------------------

(Updated June 1, 2018, 12:45 a.m.)


Review request for mesos, Benjamin Bannier, Greg Mann, Jie Yu, and Jan Schlicht.


Changes
-------

Fixed a flakiness due to a race between offers and test teardown.


Bugs: MESOS-8383
    https://issues.apache.org/jira/browse/MESOS-8383


Repository: mesos


Description
-------

This patch adds the `ROOT_OperationStateMetrics` test that issues a
`CREATE_VOLUME` followed by two `DESTROY_VOLUME`s. The first one will
fail due to an out-of-band deletion of the actual volume, and the second
one will fail due to modifying the resource version.


Diffs (updated)
-----

  src/tests/storage_local_resource_provider_tests.cpp 04a75fc4d53d1b7211e64755097b06b1e68cc3b3 


Diff: https://reviews.apache.org/r/65666/diff/8/

Changes: https://reviews.apache.org/r/65666/diff/7-8/


Testing
-------

sudo make check


Thanks,

Chun-Hung Hsiao