You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/07/25 07:46:00 UTC
[GitHub] [apisix-dashboard] wmdmomo opened a new pull request #2000: feat(plugin): fix UI proxy-mirror
wmdmomo opened a new pull request #2000:
URL: https://github.com/apache/apisix-dashboard/pull/2000
Please answer these questions before submitting a pull request, **or your PR will get closed**.
**Why submit this pull request?**
- [ ] Bugfix
- [ ] New feature provided
- [x] Improve performance
- [ ] Backport patches
**What changes will this PR take into?**
The PR will change the plugin under plugin/UI (proxy-mirror), allowing proxy-mirror to dynamically adapt to the back-end json rules.
**Related issues**
fix/resolve #1588
**Checklist:**
- [x] Did you explain what problem does this PR solve? Or what new features have been added?
- [x] Have you added corresponding test cases?
- [x] Have you modified the corresponding document?
- [x] Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] liuxiran merged pull request #2000: feat(plugin): allowing proxy-mirror to dynamically adapt to the BE rules
Posted by GitBox <gi...@apache.org>.
liuxiran merged pull request #2000:
URL: https://github.com/apache/apisix-dashboard/pull/2000
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] liuxiran commented on pull request #2000: feat(plugin): allowing proxy-mirror to dynamically adapt to the BE rules
Posted by GitBox <gi...@apache.org>.
liuxiran commented on pull request #2000:
URL: https://github.com/apache/apisix-dashboard/pull/2000#issuecomment-902543982
I noticed that in the schema of `proxy-mirror`, there is a required item in it
we can also add a required rule for it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #2000: feat(plugin): fix UI proxy-mirror
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #2000:
URL: https://github.com/apache/apisix-dashboard/pull/2000#issuecomment-886161612
βοΈ Deploy Preview for *apisix-dashboard* ready!
π¨ Explore the source changes: ca49b23187f0d86c8d64c2e6e50183054f244987
π Inspect the deploy log: [https://app.netlify.com/sites/apisix-dashboard/deploys/60fd16ae85fc2f0007bacaf2](https://app.netlify.com/sites/apisix-dashboard/deploys/60fd16ae85fc2f0007bacaf2?utm_source=github&utm_campaign=bot_dl)
π Browse the preview: [https://deploy-preview-2000--apisix-dashboard.netlify.app/](https://deploy-preview-2000--apisix-dashboard.netlify.app/?utm_source=github&utm_campaign=bot_dp)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] liuxiran commented on pull request #2000: feat(plugin): allowing proxy-mirror to dynamically adapt to the BE rules
Posted by GitBox <gi...@apache.org>.
liuxiran commented on pull request #2000:
URL: https://github.com/apache/apisix-dashboard/pull/2000#issuecomment-902535549
merged, thanks for your contribution @wmdmomo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2000: feat(plugin): allowing proxy-mirror to dynamically adapt to the BE rules
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #2000:
URL: https://github.com/apache/apisix-dashboard/pull/2000#issuecomment-886348733
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2000?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#2000](https://codecov.io/gh/apache/apisix-dashboard/pull/2000?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (be0cfe0) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/1cb7cb015f68531f62fe0105efe28ac559e0f9a2?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1cb7cb0) will **increase** coverage by `0.07%`.
> The diff coverage is `100.00%`.
> :exclamation: Current head be0cfe0 differs from pull request most recent head f8ea499. Consider uploading reports for the commit f8ea499 to get more accurate results
[](https://codecov.io/gh/apache/apisix-dashboard/pull/2000?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #2000 +/- ##
==========================================
+ Coverage 65.86% 65.94% +0.07%
==========================================
Files 121 121
Lines 3211 3212 +1
Branches 779 779
==========================================
+ Hits 2115 2118 +3
+ Misses 1096 1094 -2
```
| Flag | Coverage Ξ | |
|---|---|---|
| frontend-e2e-test | `65.94% <100.00%> (+0.07%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/2000?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Ξ | |
|---|---|---|
| [web/src/components/Plugin/UI/plugin.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2000/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9VSS9wbHVnaW4udHN4) | `83.33% <100.00%> (ΓΈ)` | |
| [web/src/components/Plugin/UI/proxy-mirror.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2000/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9VSS9wcm94eS1taXJyb3IudHN4) | `100.00% <100.00%> (ΓΈ)` | |
| [web/src/helpers.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2000/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9oZWxwZXJzLnRzeA==) | `73.77% <0.00%> (+3.27%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2000?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Ξ = absolute <relative> (impact)`, `ΓΈ = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2000?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [1cb7cb0...f8ea499](https://codecov.io/gh/apache/apisix-dashboard/pull/2000?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #2000: feat(plugin): allowing proxy-mirror to dynamically adapt to the BE rules
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #2000:
URL: https://github.com/apache/apisix-dashboard/pull/2000#issuecomment-886161612
π· Deploy Preview for *apisix-dashboard* processing.
π¨ Explore the source changes: f8ea4990344dd634b45f6e6097397033d6d13195
π Inspect the deploy log: [https://app.netlify.com/sites/apisix-dashboard/deploys/61110835758db300073521b6](https://app.netlify.com/sites/apisix-dashboard/deploys/61110835758db300073521b6?utm_source=github&utm_campaign=bot_dl)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] commented on pull request #2000: feat(plugin): fix UI proxy-mirror
Posted by GitBox <gi...@apache.org>.
netlify[bot] commented on pull request #2000:
URL: https://github.com/apache/apisix-dashboard/pull/2000#issuecomment-886161612
π· Deploy Preview for *apisix-dashboard* processing.
π¨ Explore the source changes: ca49b23187f0d86c8d64c2e6e50183054f244987
π Inspect the deploy log: [https://app.netlify.com/sites/apisix-dashboard/deploys/60fd16ae85fc2f0007bacaf2](https://app.netlify.com/sites/apisix-dashboard/deploys/60fd16ae85fc2f0007bacaf2?utm_source=github&utm_campaign=bot_dl)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-commenter commented on pull request #2000: feat(plugin): fix UI proxy-mirror
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #2000:
URL: https://github.com/apache/apisix-dashboard/pull/2000#issuecomment-886348733
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2000?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#2000](https://codecov.io/gh/apache/apisix-dashboard/pull/2000?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ca49b23) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/0b5196f0b444dac8acb5cf60635806f024de6a0a?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0b5196f) will **decrease** coverage by `0.04%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/2000?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #2000 +/- ##
==========================================
- Coverage 64.01% 63.97% -0.05%
==========================================
Files 122 122
Lines 3154 3156 +2
Branches 753 753
==========================================
Hits 2019 2019
- Misses 1135 1137 +2
```
| Flag | Coverage Ξ | |
|---|---|---|
| frontend-e2e-test | `63.97% <100.00%> (-0.05%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/2000?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Ξ | |
|---|---|---|
| [web/src/components/Plugin/PluginDetail.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2000/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9QbHVnaW5EZXRhaWwudHN4) | `65.82% <100.00%> (+0.21%)` | :arrow_up: |
| [web/src/components/Plugin/UI/plugin.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2000/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9VSS9wbHVnaW4udHN4) | `82.60% <100.00%> (ΓΈ)` | |
| [web/src/components/Plugin/UI/proxy-mirror.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2000/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9VSS9wcm94eS1taXJyb3IudHN4) | `100.00% <100.00%> (ΓΈ)` | |
| [web/src/helpers.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2000/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9oZWxwZXJzLnRzeA==) | `68.85% <0.00%> (-3.28%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2000?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Ξ = absolute <relative> (impact)`, `ΓΈ = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2000?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [0b5196f...ca49b23](https://codecov.io/gh/apache/apisix-dashboard/pull/2000?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #2000: feat(plugin): allowing proxy-mirror to dynamically adapt to the BE rules
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #2000:
URL: https://github.com/apache/apisix-dashboard/pull/2000#issuecomment-886161612
βοΈ Deploy Preview for *apisix-dashboard* ready!
π¨ Explore the source changes: f8ea4990344dd634b45f6e6097397033d6d13195
π Inspect the deploy log: [https://app.netlify.com/sites/apisix-dashboard/deploys/61110835758db300073521b6](https://app.netlify.com/sites/apisix-dashboard/deploys/61110835758db300073521b6?utm_source=github&utm_campaign=bot_dl)
π Browse the preview: [https://deploy-preview-2000--apisix-dashboard.netlify.app/](https://deploy-preview-2000--apisix-dashboard.netlify.app/?utm_source=github&utm_campaign=bot_dp)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org