[jira] [Commented] (HBASE-16021) graceful_stop.sh: Wrap variables in double quote to avoid "[: too many arguments" error

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-16021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15329525#comment-15329525 ] 

Hadoop QA commented on HBASE-16021:
-----------------------------------

| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s {color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} shellcheck {color} | {color:green} 0m 2s {color} | {color:green} The applied patch generated 0 new + 415 unchanged - 1 fixed = 415 total (was 416) {color} |
| {color:green}+1{color} | {color:green} shelldocs {color} | {color:green} 0m 2s {color} | {color:green} There were no new shelldocs issues. {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s {color} | {color:green} Patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 25m 22s {color} | {color:green} Patch does not cause any errors with Hadoop 2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.7.1. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 12s {color} | {color:green} Patch does not generate ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 25m 52s {color} | {color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12810385/HBASE-16021_v1.patch |
| JIRA Issue | HBASE-16021 |
| Optional Tests |  asflicense  shellcheck  shelldocs  |
| uname | Linux asf907.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh |
| git revision | master / e486d27 |
| shellcheck | v0.3.3 (This is an old version that has serious bugs. Consider upgrading.) |
| modules | C: . U: . |
| Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/2204/console |
| Powered by | Apache Yetus 0.2.1   http://yetus.apache.org |


This message was automatically generated.



> graceful_stop.sh: Wrap variables in double quote to avoid  "[: too many arguments" error
> ----------------------------------------------------------------------------------------
>
>                 Key: HBASE-16021
>                 URL: https://issues.apache.org/jira/browse/HBASE-16021
>             Project: HBase
>          Issue Type: Bug
>          Components: scripts
>    Affects Versions: 2.0.0
>            Reporter: Samir Ahmic
>            Assignee: Samir Ahmic
>            Priority: Minor
>             Fix For: 2.0.0
>
>         Attachments: HBASE-16021_v1.patch
>
>
> On few places in graceful_stop.sh there is if conditions where variables are not  double quoted which may cause error.  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)